Skip to content

Commit 851390d

Browse files
Re-added all models, removed test
1 parent 2c89c1a commit 851390d

File tree

2 files changed

+0
-26
lines changed

2 files changed

+0
-26
lines changed

orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationAiModel.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66

77
/** Large language models available in Orchestration. */
88
// https://help.sap.com/docs/sap-ai-core/sap-ai-core-service-guide/models-and-scenarios-in-generative-ai-hub
9-
@SuppressWarnings("unused") // tested in OrchestrationTest.orchestrationModelAvailability()
109
public class OrchestrationAiModel extends LLMModuleConfig {
1110

1211
/** IBM Granite 13B chat completions model */

sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/controllers/OrchestrationTest.java

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -147,29 +147,4 @@ void testMaskingPseudonymization() {
147147
.doesNotContain("MASKED_PERSON")
148148
.contains("Mallory");
149149
}
150-
151-
@Test
152-
@DisplayName("Declared OrchestrationAiModels must match Orchestration's list of available models")
153-
@SneakyThrows
154-
void orchestrationModelAvailability() {
155-
// TODO: Change this test to be like ScenarioTest.openAiModelAvailability() once the
156-
// Orchestration service has made the "available models endpoint".
157-
// Right now this test cannot tell if we are lacking models.
158-
159-
// Gather our declared Orchestration models
160-
List<OrchestrationAiModel> declaredOrchestrationModelList = new ArrayList<>();
161-
for (Field field : OrchestrationAiModel.class.getFields()) {
162-
if (field.getType().equals(OrchestrationAiModel.class)) {
163-
declaredOrchestrationModelList.add(((OrchestrationAiModel) field.get(null)));
164-
}
165-
}
166-
167-
for (OrchestrationAiModel model : declaredOrchestrationModelList) {
168-
controller.config = new OrchestrationModuleConfig().withLlmConfig(model);
169-
log.info("Testing completion for model: {}", model.getModelName());
170-
final var completion = controller.completion();
171-
final var requestModel = completion.getOrchestrationResult().getModel();
172-
assertThat(requestModel).contains(model.getModelName());
173-
}
174-
}
175150
}

0 commit comments

Comments
 (0)