feat: [Orchestration] Make getLlmChoice public (#204)

* feat: Orchestration Make getLlmChoice public

* Revert filtering change

Author: MatKuhr

orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationChatResponse.java

@@ -29,7 +29,7 @@ public class OrchestrationChatResponse {
    */
   @Nonnull
   public String getContent() throws OrchestrationClientException {
-    final var choice = getCurrentChoice();
+    final var choice = getChoice();
 
     if ("content_filter".equals(choice.getFinishReason())) {
       throw new OrchestrationClientException("Content filter filtered the output.");
@@ -67,17 +67,17 @@ public List<Message> getAllMessages() {
       messages.add(message);
     }
 
-    messages.add(new AssistantMessage(getCurrentChoice().getMessage().getContent()));
+    messages.add(new AssistantMessage(getChoice().getMessage().getContent()));
     return messages;
   }
 
   /**
-   * Get current choice.
+   * Get the LLM response. Useful for accessing the finish reason or further data like logprobs.
    *
-   * @return The current choice.
+   * @return The (first, in case of multiple) {@link LLMChoice}.
    */
   @Nonnull
-  private LLMChoice getCurrentChoice() {
+  public LLMChoice getChoice() {
     //    We expect choices to be defined and never empty.
     return ((LLMModuleResultSynchronous) originalResponse.getOrchestrationResult())
         .getChoices()

sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/controllers/OrchestrationController.java

@@ -16,13 +16,15 @@
 import java.util.List;
 import java.util.Map;
 import javax.annotation.Nonnull;
+import lombok.extern.slf4j.Slf4j;
 import org.springframework.web.bind.annotation.GetMapping;
 import org.springframework.web.bind.annotation.PathVariable;
 import org.springframework.web.bind.annotation.RequestMapping;
 import org.springframework.web.bind.annotation.RestController;
 
 /** Endpoints for the Orchestration service */
 @RestController
+@Slf4j
 @RequestMapping("/orchestration")
 class OrchestrationController {
   private final OrchestrationClient client = new OrchestrationClient();
@@ -39,7 +41,11 @@ class OrchestrationController {
   OrchestrationChatResponse completion() {
     final var prompt = new OrchestrationPrompt("Hello world! Why is this phrase so famous?");
 
-    return client.chatCompletion(prompt, config);
+    final var result = client.chatCompletion(prompt, config);
+
+    log.info("Our trusty AI answered with: {}", result.getContent());
+
+    return result;
   }
 
   /**

sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/controllers/OrchestrationTest.java

@@ -67,6 +67,7 @@ void testTemplate() {
     assertThat(choices.get(0).getMessage().getContent()).isNotEmpty();
     assertThat(choices.get(0).getMessage().getRole()).isEqualTo("assistant");
     assertThat(choices.get(0).getFinishReason()).isEqualTo("stop");
+    assertThat(result.getChoice()).isSameAs(choices.get(0));
     usage = result.getTokenUsage();
     assertThat(usage.getCompletionTokens()).isGreaterThan(1);
     assertThat(usage.getPromptTokens()).isGreaterThan(1);