Skip to content

Commit 8d264de

Browse files
newtorka-dbot-sdk-js
authored
chore: Enable E2E test for OpenAI models (#350)
* Initial * Formatting --------- Co-authored-by: Alexander Dümont <[email protected]> Co-authored-by: SAP Cloud SDK Bot <[email protected]>
1 parent fdb30da commit 8d264de

File tree

2 files changed

+9
-4
lines changed
  • foundation-models/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai
  • sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/controllers

2 files changed

+9
-4
lines changed

foundation-models/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiModel.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,12 @@ public record OpenAiModel(@Nonnull String name, @Nullable String version) implem
4040
/** Azure OpenAI GPT-4o Mini chat completions model */
4141
public static final OpenAiModel GPT_4O_MINI = new OpenAiModel("gpt-4o-mini", null);
4242

43+
/** Azure OpenAI GPT-o3 Mini chat completions model */
44+
public static final OpenAiModel GPT_O3_MINI = new OpenAiModel("o3-mini", null);
45+
46+
/** Azure OpenAI GPT-o1 chat completions model */
47+
public static final OpenAiModel GPT_O1 = new OpenAiModel("o1", null);
48+
4349
/** Azure OpenAI Text Embedding 3 Large model */
4450
public static final OpenAiModel TEXT_EMBEDDING_3_LARGE =
4551
new OpenAiModel("text-embedding-3-large", null);

sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/controllers/ScenarioTest.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,13 @@
1010
import lombok.SneakyThrows;
1111
import org.junit.jupiter.api.DisplayName;
1212
import org.junit.jupiter.api.Test;
13-
import org.junit.jupiter.api.condition.DisabledIfSystemProperty;
1413

1514
class ScenarioTest {
1615

1716
@Test
18-
@DisplayName("Declared OpenAI models must match AI Core's available OpenAI models")
17+
@DisplayName(
18+
"Declared OpenAI models must be superset of our AI Core account's available OpenAI models")
1919
@SneakyThrows
20-
@DisabledIfSystemProperty(named = "aicore.landscape", matches = "canary")
2120
void openAiModelAvailability() {
2221

2322
// Gather AI Core's list of available OpenAI models
@@ -41,6 +40,6 @@ void openAiModelAvailability() {
4140
}
4241

4342
// Assert that the declared OpenAI models match the expected list
44-
assertThat(declaredOpenAiModelList).hasSameElementsAs(availableOpenAiModels);
43+
assertThat(declaredOpenAiModelList).containsAll(availableOpenAiModels);
4544
}
4645
}

0 commit comments

Comments
 (0)