Skip to content

Commit 9067dca

Browse files
temp fix
1 parent 22b7d68 commit 9067dca

File tree

3 files changed

+27
-24
lines changed

3 files changed

+27
-24
lines changed

core-services/document-grounding/src/test/java/com/sap/ai/sdk/grounding/GroundingClientTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
import com.sap.ai.sdk.grounding.model.DocumentKeyValueListPair;
1515
import com.sap.ai.sdk.grounding.model.DocumentResponse;
1616
import com.sap.ai.sdk.grounding.model.Documents;
17+
import com.sap.ai.sdk.grounding.model.GetPipelines;
1718
import com.sap.ai.sdk.grounding.model.KeyValueListPair;
18-
import com.sap.ai.sdk.grounding.model.Pipelines;
1919
import com.sap.cloud.sdk.cloudplatform.connectivity.DefaultHttpDestination;
2020
import com.sap.cloud.sdk.cloudplatform.connectivity.HttpDestination;
2121
import java.util.UUID;
@@ -35,7 +35,7 @@ public class GroundingClientTest {
3535
void testPipelines() {
3636
final PipelinesApi api = new GroundingClient(SERVICE).pipelines();
3737

38-
final Pipelines allPipelines = api.getAllPipelines("reosurceGroup");
38+
final GetPipelines allPipelines = api.getAllPipelines("reosurceGroup");
3939
assertThat(allPipelines).isNotNull();
4040
assertThat(allPipelines.getResources()).isEmpty();
4141
}
@@ -61,7 +61,7 @@ void testVector() {
6161
});
6262

6363
final UUID collectionId = collections.getResources().get(0).getId();
64-
final Documents documents = api.getAllDocuments("reosurceGroup", collectionId);
64+
final Documents documents = api.getDocumentsByCollectionId("reosurceGroup", collectionId);
6565
assertThat(documents).isNotNull();
6666
final DocumentKeyValueListPair documentMeta =
6767
DocumentKeyValueListPair.create()
@@ -80,7 +80,7 @@ void testVector() {
8080

8181
final UUID documentId = documents.getResources().get(0).getId();
8282
final DocumentResponse document =
83-
api.getDocumentById("reosurceGroup", collectionId, documentId);
83+
api.getDocumentByIdForCollection("reosurceGroup", collectionId, documentId);
8484
assertThat(document).isNotNull();
8585
assertThat(document.getId()).isEqualTo(documentId);
8686
assertThat(document.getMetadata()).isNotNull().containsExactly(documentMeta);

sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/controllers/GroundingController.java

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,9 @@
2020
import com.sap.ai.sdk.grounding.model.DocumentWithoutChunks;
2121
import com.sap.ai.sdk.grounding.model.EmbeddingConfig;
2222
import com.sap.ai.sdk.grounding.model.KeyValueListPair;
23-
import com.sap.ai.sdk.grounding.model.Pipeline;
23+
import com.sap.ai.sdk.grounding.model.RetrievalSearchConfiguration;
2424
import com.sap.ai.sdk.grounding.model.RetrievalSearchFilter;
25-
import com.sap.ai.sdk.grounding.model.RetrievalSearchInput;
26-
import com.sap.ai.sdk.grounding.model.SearchConfiguration;
25+
import com.sap.ai.sdk.grounding.model.SearchInput;
2726
import com.sap.ai.sdk.grounding.model.TextOnlyBaseChunk;
2827
import com.sap.cloud.sdk.services.openapi.core.OpenApiResponse;
2928
import java.time.format.TextStyle;
@@ -64,7 +63,8 @@ Object getAllPipelines(
6463
if ("json".equals(format)) {
6564
return pipelines;
6665
}
67-
final var ids = pipelines.getResources().stream().map(Pipeline::getId).collect(joining(", "));
66+
final var ids = List.of();
67+
// pipelines.getResources().stream().map(getPipeline::getId).collect(joining(", "));
6868
return "Found pipelines with ids: " + ids;
6969
}
7070

@@ -92,8 +92,8 @@ Object searchInDocuments(
9292
.id("question")
9393
.dataRepositoryType(DataRepositoryType.VECTOR)
9494
.dataRepositories(List.of("*"))
95-
.searchConfiguration(SearchConfiguration.create().maxChunkCount(10));
96-
final var q = RetrievalSearchInput.create().query("When was the last upload?").filters(filter);
95+
.searchConfiguration(RetrievalSearchConfiguration.create().maxChunkCount(10));
96+
final var q = SearchInput.create().query("When was the last upload?").filters(filter);
9797
final var results = CLIENT_RETRIEVAL.search(RESOURCE_GROUP, q);
9898

9999
if ("json".equals(format)) {
@@ -102,7 +102,7 @@ Object searchInDocuments(
102102
final var messages =
103103
results.getResults().stream()
104104
.flatMap(resultsInner1 -> resultsInner1.getResults().stream())
105-
.flatMap(result -> result.getDataRepository().getDocuments().stream())
105+
.flatMap(result -> result.getDocuments().stream())
106106
.flatMap(dataRepositorySearchResult -> dataRepositorySearchResult.getChunks().stream())
107107
.map(Chunk::getContent)
108108
.toList();
@@ -127,7 +127,7 @@ Object getAllCollections(
127127
Object getDocumentsByCollectionId(
128128
@Nonnull @PathVariable("id") final UUID collectionId,
129129
@Nullable @RequestParam(value = "format", required = false) final String format) {
130-
final var documents = CLIENT_VECTOR.getAllDocuments(RESOURCE_GROUP, collectionId);
130+
final var documents = CLIENT_VECTOR.getDocumentsByCollectionId(RESOURCE_GROUP, collectionId);
131131
if ("json".equals(format)) {
132132
return documents;
133133
}
@@ -162,7 +162,8 @@ Object createDocument(
162162
final var docMeta = DocumentKeyValueListPair.create().key("purpose").value("testing");
163163
final var doc = BaseDocument.create().chunks(chunk).metadata(docMeta);
164164
final var request = DocumentCreateRequest.create().documents(doc);
165-
final var response = CLIENT_VECTOR.createDocuments(RESOURCE_GROUP, collectionId, request);
165+
final var response =
166+
CLIENT_VECTOR.createCollectionDocuments(RESOURCE_GROUP, collectionId, request);
166167

167168
if ("json".equals(format)) {
168169
return response;
@@ -184,12 +185,12 @@ Object deleteCollection(
184185
final var doc = BaseDocument.create().chunks(chunk).metadata(docMeta);
185186
final var request = DocumentCreateRequest.create().documents(doc);
186187

187-
final var documents = CLIENT_VECTOR.getAllDocuments(RESOURCE_GROUP, collectionId);
188+
final var documents = CLIENT_VECTOR.getDocumentsByCollectionId(RESOURCE_GROUP, collectionId);
188189
final var ids = documents.getResources().stream().map(DocumentWithoutChunks::getId).toList();
189190
log.info("Deleting collection {} with {} documents: {}", collectionId, ids.size(), ids);
190191

191192
for (final var documentId : ids) {
192-
final var del = CLIENT_VECTOR.deleteDocumentById(RESOURCE_GROUP, collectionId, documentId);
193+
final var del = CLIENT_VECTOR.deleteCollectionById(RESOURCE_GROUP, collectionId, documentId);
193194
if (del.getStatusCode() >= 400) {
194195
final var msg = "Document {} could not be deleted, status code [{}], headers: {}";
195196
log.error(msg, documentId, del.getStatusCode(), del.getHeaders());
@@ -209,7 +210,8 @@ Object getDocumentChunksById(
209210
@Nonnull @PathVariable("collectionId") final UUID collectionId,
210211
@Nonnull @PathVariable("documentId") final UUID documentId,
211212
@Nullable @RequestParam(value = "format", required = false) final String format) {
212-
final var document = CLIENT_VECTOR.getDocumentById(RESOURCE_GROUP, collectionId, documentId);
213+
final var document =
214+
CLIENT_VECTOR.getDocumentByIdForCollection(RESOURCE_GROUP, collectionId, documentId);
213215
if ("json".equals(format)) {
214216
return document;
215217
}

sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/controllers/GroundingTest.java

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,12 @@
66

77
import com.sap.ai.sdk.grounding.model.CollectionsListResponse;
88
import com.sap.ai.sdk.grounding.model.DataRepositories;
9+
import com.sap.ai.sdk.grounding.model.DataRepositorySearchResults;
910
import com.sap.ai.sdk.grounding.model.DocumentResponse;
1011
import com.sap.ai.sdk.grounding.model.Documents;
1112
import com.sap.ai.sdk.grounding.model.DocumentsListResponse;
12-
import com.sap.ai.sdk.grounding.model.Pipelines;
13-
import com.sap.ai.sdk.grounding.model.RetievalSearchResults;
13+
import com.sap.ai.sdk.grounding.model.GetPipelines;
14+
import com.sap.ai.sdk.grounding.model.SearchResults;
1415
import com.sap.cloud.sdk.services.openapi.core.OpenApiResponse;
1516
import java.time.format.TextStyle;
1617
import java.util.Locale;
@@ -29,9 +30,9 @@ void testPipelinesGetAll() {
2930
final var controller = new GroundingController();
3031

3132
final var result = controller.getAllPipelines(JSON_FORMAT);
32-
assertThat(result).isInstanceOf(Pipelines.class);
33-
final var pipelinesList = ((Pipelines) result).getResources();
34-
final var pipelinesCount = ((Pipelines) result).getCount();
33+
assertThat(result).isInstanceOf(GetPipelines.class);
34+
final var pipelinesList = ((GetPipelines) result).getResources();
35+
final var pipelinesCount = ((GetPipelines) result).getCount();
3536

3637
// we don't have testable data yet, but the endpoint works without errors
3738
assertThat(pipelinesCount).isEqualTo(0);
@@ -87,9 +88,9 @@ void testCreateDeleteCollection() {
8788

8889
// (4) SEARCH FOR DOCUMENTS
8990
Object search = controller.searchInDocuments(JSON_FORMAT);
90-
assertThat(search).isInstanceOf(RetievalSearchResults.class);
91+
assertThat(search).isInstanceOf(SearchResults.class);
9192
final var dayOfWeek = now().getDayOfWeek().getDisplayName(TextStyle.FULL, Locale.ENGLISH);
92-
this.assertDocumentSearchResult((RetievalSearchResults) search, dayOfWeek);
93+
this.assertDocumentSearchResult((DataRepositorySearchResults) search, dayOfWeek);
9394

9495
// (5) CLEAN UP
9596
Object deletion = controller.deleteCollection(collectionUuid, JSON_FORMAT);
@@ -101,7 +102,7 @@ void testCreateDeleteCollection() {
101102
.hasMessageContaining("404 Not Found");
102103
}
103104

104-
private void assertDocumentSearchResult(RetievalSearchResults search, String dayOfWeek) {
105+
private void assertDocumentSearchResult(DataRepositorySearchResults search, String dayOfWeek) {
105106
assertThat(search.getResults()).isNotEmpty();
106107
for (final var resultsByFilter : search.getResults()) {
107108
assertThat(resultsByFilter.getFilterId()).isEqualTo("question");

0 commit comments

Comments
 (0)