Change tool_calls to camelCase (#176)

Co-authored-by: Jonas Israel <[email protected]>

Author: Jonas-Isr

foundation-models/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/model/OpenAiChatMessage.java

@@ -250,7 +250,7 @@ class OpenAiChatAssistantMessage implements OpenAiChatMessage {
     /** The tool calls generated by the model, such as function calls. */
     @JsonProperty("tool_calls")
     @Getter(onMethod_ = @Nullable)
-    private List<OpenAiChatToolCall> tool_calls;
+    private List<OpenAiChatToolCall> toolCalls;
 
     // TODO: add context
     // https://github.com/Azure/azure-rest-api-specs/blob/07d286359f828bbc7901e86288a5d62b48ae2052/specification/cognitiveservices/data-plane/AzureOpenAI/inference/stable/2024-02-01/inference.json#L1599
@@ -264,12 +264,11 @@ void addDelta(@Nonnull final OpenAiChatAssistantMessage delta) {
         content += delta.getContent();
       }
 
-      if (delta.getTool_calls() != null) {
-        if (tool_calls == null) {
-          tool_calls = new ArrayList<>();
+      if (delta.getToolCalls() != null) {
+        if (toolCalls == null) {
+          toolCalls = new ArrayList<>();
         }
-        // TODO: camel case
-        tool_calls.addAll(delta.getTool_calls());
+        toolCalls.addAll(delta.getToolCalls());
       }
     }
   }

foundation-models/openai/src/test/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiClientTest.java

@@ -241,7 +241,7 @@ void chatCompletion(@Nonnull final Callable<OpenAiChatCompletionOutput> request)
           .isEqualTo(
               "I'm an AI and cannot answer that question as beauty is subjective and varies from person to person.");
       assertThat(choice.getMessage().getRole()).isEqualTo("assistant");
-      assertThat(choice.getMessage().getTool_calls()).isNull();
+      assertThat(choice.getMessage().getToolCalls()).isNull();
 
       OpenAiContentFilterPromptResults contentFilterResults = choice.getContentFilterResults();
       assertThat(contentFilterResults).isNotNull();
@@ -492,7 +492,7 @@ void streamChatCompletionDeltas() throws IOException {
         // the role is only defined in delta 1, but it defaults to "assistant" for all deltas
         assertThat(choices2.getMessage().getRole()).isEqualTo("assistant");
         assertThat(choices2.getMessage().getContent()).isEqualTo("Sure");
-        assertThat(choices2.getMessage().getTool_calls()).isNull();
+        assertThat(choices2.getMessage().getToolCalls()).isNull();
         final var filter2 = choices2.getContentFilterResults();
         assertFilter(filter2);
 
@@ -505,7 +505,7 @@ void streamChatCompletionDeltas() throws IOException {
         // the role is only defined in delta 1, but it defaults to "assistant" for all deltas
         assertThat(delta4Choice.getMessage().getRole()).isEqualTo("assistant");
         assertThat(delta4Choice.getMessage().getContent()).isNull();
-        assertThat(delta4Choice.getMessage().getTool_calls()).isNull();
+        assertThat(delta4Choice.getMessage().getToolCalls()).isNull();
         assertThat(totalOutput.getChoices()).hasSize(1);
         final var choice = totalOutput.getChoices().get(0);
         assertThat(choice.getFinishReason()).isEqualTo("stop");
@@ -514,7 +514,7 @@ void streamChatCompletionDeltas() throws IOException {
         assertThat(choice.getMessage()).isNotNull();
         assertThat(choice.getMessage().getRole()).isEqualTo("assistant");
         assertThat(choice.getMessage().getContent()).isEqualTo("Sure!");
-        assertThat(choice.getMessage().getTool_calls()).isNull();
+        assertThat(choice.getMessage().getToolCalls()).isNull();
         assertThat(totalOutput.getId()).isEqualTo("chatcmpl-A16EvnkgEm6AdxY0NoOmGPjsJucQ1");
         assertThat(totalOutput.getCreated()).isEqualTo(1724825677);
         assertThat(totalOutput.getModel()).isEqualTo("gpt-35-turbo");

sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/controllers/OpenAiTest.java

@@ -68,8 +68,8 @@ void chatCompletionTools() {
 
     final var message = completion.getChoices().get(0).getMessage();
     assertThat(message.getRole()).isEqualTo("assistant");
-    assertThat(message.getTool_calls()).isNotNull();
-    assertThat(message.getTool_calls().get(0).getFunction().getName()).isEqualTo("fibonacci");
+    assertThat(message.getToolCalls()).isNotNull();
+    assertThat(message.getToolCalls().get(0).getFunction().getName()).isEqualTo("fibonacci");
   }
 
   @Test