Revert embedding convenience.

Author: rpanackal

foundation-models/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiEmbeddingsRequestFactory.java

@@ -25,6 +25,8 @@
 import com.sap.ai.sdk.foundationmodels.openai.model2.CreateChatCompletionRequest;
 import com.sap.ai.sdk.foundationmodels.openai.model2.CreateChatCompletionStreamResponse;
 import com.sap.ai.sdk.foundationmodels.openai.model2.CreateChatCompletionStreamResponseChoicesInner;
+import com.sap.ai.sdk.foundationmodels.openai.model2.EmbeddingsCreateRequest;
+import com.sap.ai.sdk.foundationmodels.openai.model2.EmbeddingsCreateRequestInput;
 import com.sap.ai.sdk.foundationmodels.openai.model2.PromptFilterResult;
 import com.sap.cloud.sdk.cloudplatform.connectivity.ApacheHttpClient5Accessor;
 import com.sap.cloud.sdk.cloudplatform.connectivity.ApacheHttpClient5Cache;
@@ -381,7 +383,8 @@ void embedding() {
                     .withBodyFile("embeddingResponse.json")
                     .withHeader("Content-Type", "application/json")));
 
-    final var request = OpenAiEmbeddingsRequestFactory.fromStrings("Hello World");
+    final var request =
+        new EmbeddingsCreateRequest().input(EmbeddingsCreateRequestInput.create("Hello World"));
     final var result = client.embedding(request);
 
     assertThat(result).isNotNull();
@@ -413,7 +416,7 @@ void embedding() {
             .withRequestBody(
                 equalToJson(
                     """
-                      {"input": [ "Hello World" ]}""")));
+                      {"input": "Hello World"}""")));
   }
 
   @Test

foundation-models/openai/src/test/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiClientTest.java

@@ -15,7 +15,6 @@
 import com.sap.ai.sdk.foundationmodels.openai.OpenAiChatCompletionOutput;
 import com.sap.ai.sdk.foundationmodels.openai.OpenAiChatCompletionPrompt;
 import com.sap.ai.sdk.foundationmodels.openai.OpenAiClient;
-import com.sap.ai.sdk.foundationmodels.openai.OpenAiEmbeddingsRequestFactory;
 import com.sap.ai.sdk.foundationmodels.openai.model2.ChatCompletionNamedToolChoice;
 import com.sap.ai.sdk.foundationmodels.openai.model2.ChatCompletionNamedToolChoiceFunction;
 import com.sap.ai.sdk.foundationmodels.openai.model2.ChatCompletionRequestMessageContentPartImage;
@@ -27,6 +26,8 @@
 import com.sap.ai.sdk.foundationmodels.openai.model2.ChatCompletionToolChoiceOption;
 import com.sap.ai.sdk.foundationmodels.openai.model2.CreateChatCompletionRequest;
 import com.sap.ai.sdk.foundationmodels.openai.model2.EmbeddingsCreate200Response;
+import com.sap.ai.sdk.foundationmodels.openai.model2.EmbeddingsCreateRequest;
+import com.sap.ai.sdk.foundationmodels.openai.model2.EmbeddingsCreateRequestInput;
 import com.sap.ai.sdk.foundationmodels.openai.model2.FunctionObject;
 import java.net.URI;
 import java.util.List;
@@ -162,7 +163,8 @@ public OpenAiChatCompletionOutput chatCompletionTools(@Nonnull final String desc
    */
   @Nonnull
   public EmbeddingsCreate200Response embedding(@Nonnull final String input) {
-    final var request = OpenAiEmbeddingsRequestFactory.fromStrings(input);
+    final var request =
+        new EmbeddingsCreateRequest().input(EmbeddingsCreateRequestInput.create(input));
 
     return OpenAiClient.forModel(TEXT_EMBEDDING_ADA_002).embedding(request);
   }