Removed IterableStreamConverter.java

Author: CharlesDuboisSAP

core/pom.xml

@@ -30,12 +30,12 @@
   </developers>
   <properties>
     <project.rootdir>${project.basedir}/../</project.rootdir>
-    <coverage.complexity>45%</coverage.complexity>
-    <coverage.line>53%</coverage.line>
-    <coverage.instruction>51%</coverage.instruction>
-    <coverage.branch>35%</coverage.branch>
-    <coverage.method>56%</coverage.method>
-    <coverage.class>70%</coverage.class>
+    <coverage.complexity>52%</coverage.complexity>
+    <coverage.line>64%</coverage.line>
+    <coverage.instruction>62%</coverage.instruction>
+    <coverage.branch>47%</coverage.branch>
+    <coverage.method>65%</coverage.method>
+    <coverage.class>80%</coverage.class>
   </properties>
 
   <dependencies>

…/openai/IterableStreamConverterTest.java …commons/IterableStreamConverterTest.javafoundation-models/openai/src/test/java/com/sap/ai/sdk/foundationmodels/openai/IterableStreamConverterTest.java renamed to core/src/test/java/com/sap/ai/sdk/core/commons/IterableStreamConverterTest.java foundation-models/openai/src/test/java/com/sap/ai/sdk/foundationmodels/openai/IterableStreamConverterTest.java renamed to core/src/test/java/com/sap/ai/sdk/core/commons/IterableStreamConverterTest.java

@@ -1,4 +1,4 @@
-package com.sap.ai.sdk.foundationmodels.openai;
+package com.sap.ai.sdk.core.commons;
 
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.assertThatThrownBy;
@@ -18,6 +18,7 @@
 import java.nio.charset.StandardCharsets;
 import java.util.concurrent.atomic.AtomicInteger;
 import lombok.SneakyThrows;
+import lombok.experimental.StandardException;
 import org.apache.hc.core5.http.ContentType;
 import org.apache.hc.core5.http.io.entity.InputStreamEntity;
 import org.junit.jupiter.api.DisplayName;
@@ -33,7 +34,7 @@ void testLines() {
     final var inputStream = spy(new ByteArrayInputStream(input.getBytes(StandardCharsets.UTF_8)));
     final var entity = new InputStreamEntity(inputStream, ContentType.TEXT_PLAIN);
 
-    final var sut = IterableStreamConverter.lines(entity);
+    final var sut = IterableStreamConverter.lines(entity, TestClientException::new);
     verify(inputStream, never()).read();
     verify(inputStream, never()).read(any());
     verify(inputStream, never()).read(any(), anyInt(), anyInt());
@@ -69,7 +70,7 @@ void testLinesFindFirst() {
 
     final var entity = new InputStreamEntity(inputStream, ContentType.TEXT_PLAIN);
 
-    final var sut = IterableStreamConverter.lines(entity);
+    final var sut = IterableStreamConverter.lines(entity, TestClientException::new);
     assertThat(sut.findFirst()).contains("Foo Bar");
     verify(inputStream, times(1)).read(any(), anyInt(), anyInt());
     verify(inputStream, never()).close();
@@ -93,14 +94,17 @@ void testLinesThrows() {
 
     final var entity = new InputStreamEntity(inputStream, ContentType.TEXT_PLAIN);
 
-    final var sut = IterableStreamConverter.lines(entity);
+    final var sut = IterableStreamConverter.lines(entity, TestClientException::new);
     assertThatThrownBy(sut::count)
-        .isInstanceOf(OpenAiClientException.class)
+        .isInstanceOf(TestClientException.class)
         .hasMessage("Parsing response content was interrupted.")
         .cause()
         .isInstanceOf(IOException.class)
         .hasMessage("Ups!");
     verify(inputStream, times(2)).read(any(), anyInt(), anyInt());
     verify(inputStream, times(1)).close();
   }
+
+  @StandardException
+  public static class TestClientException extends ClientException {}
 }