Drive by tests

Author: CharlesDuboisSAP

orchestration/src/test/java/com/sap/ai/sdk/orchestration/ConfigToRequestTransformerTest.java

@@ -1,5 +1,6 @@
 package com.sap.ai.sdk.orchestration;
 
+import static com.sap.ai.sdk.orchestration.OrchestrationAiModel.GPT_4O;
 import static com.sap.ai.sdk.orchestration.OrchestrationUnitTest.CUSTOM_GPT_35;
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.assertThatThrownBy;
@@ -101,4 +102,26 @@ void testDpiMaskingConfig() {
         .withFailMessage("withMaskingConfig() should overwrite the existing config and not append")
         .hasSize(1);
   }
+
+  @Test
+  void testLLMConfig() {
+    Map<String, Object> params = Map.of("foo", "bar");
+    String version = "2024-05-13";
+    OrchestrationAiModel aiModel = GPT_4O.withModelParams(params).withModelVersion(version);
+    var config = new OrchestrationModuleConfig().withLlmConfig(aiModel);
+
+    var actual = ConfigToRequestTransformer.toModuleConfigs(config);
+
+    assertThat(actual.getLlmModuleConfig()).isNotNull();
+    assertThat(actual.getLlmModuleConfig().getModelName()).isEqualTo(GPT_4O.getModelName());
+    assertThat(actual.getLlmModuleConfig().getModelParams()).isEqualTo(params);
+    assertThat(actual.getLlmModuleConfig().getModelVersion()).isEqualTo(version);
+
+    assertThat(GPT_4O.getModelParams())
+        .withFailMessage("Static models should be unchanged")
+        .isEmpty();
+    assertThat(GPT_4O.getModelVersion())
+        .withFailMessage("Static models should be unchanged")
+        .isEqualTo("latest");
+  }
 }

pom.xml

@@ -76,11 +76,11 @@
     <enforcer.skipEnforceScopeLombok>false</enforcer.skipEnforceScopeLombok>
     <enforcer.skipBanGeneratedModulesReference>false</enforcer.skipBanGeneratedModulesReference>
     <!-- Test coverage -->
-    <coverage.instruction>74%</coverage.instruction>
+    <coverage.instruction>75%</coverage.instruction>
     <coverage.branch>67%</coverage.branch>
-    <coverage.complexity>67%</coverage.complexity>
-    <coverage.line>75%</coverage.line>
-    <coverage.method>80%</coverage.method>
+    <coverage.complexity>69%</coverage.complexity>
+    <coverage.line>76%</coverage.line>
+    <coverage.method>85%</coverage.method>
     <coverage.class>85%</coverage.class>
   </properties>