Skip to content

Commit ad9a8c1

Browse files
committed
Update to latest changes on main
1 parent 2dea10a commit ad9a8c1

File tree

5 files changed

+10
-28
lines changed

5 files changed

+10
-28
lines changed

orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationClient.java

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
import com.sap.ai.sdk.core.common.ClientResponseHandler;
1313
import com.sap.ai.sdk.core.common.ClientStreamingHandler;
1414
import com.sap.ai.sdk.core.common.StreamedDelta;
15-
import com.sap.ai.sdk.orchestration.model.ChatMessage;
1615
import com.sap.ai.sdk.orchestration.model.CompletionPostRequest;
1716
import com.sap.ai.sdk.orchestration.model.CompletionPostResponse;
1817
import com.sap.ai.sdk.orchestration.model.ModuleConfigs;
@@ -38,25 +37,6 @@
3837
public class OrchestrationClient {
3938
private static final String DEFAULT_SCENARIO = "orchestration";
4039

41-
static final ObjectMapper JACKSON;
42-
43-
static {
44-
JACKSON = getDefaultObjectMapper();
45-
46-
// Add mix-ins
47-
JACKSON.addMixIn(LLMModuleResult.class, JacksonMixins.LLMModuleResultMixIn.class);
48-
JACKSON.addMixIn(
49-
ModuleResultsOutputUnmaskingInner.class,
50-
JacksonMixins.ModuleResultsOutputUnmaskingInnerMixIn.class);
51-
52-
final var module =
53-
new SimpleModule()
54-
.addDeserializer(
55-
ChatMessage.class,
56-
PolymorphicFallbackDeserializer.fromJsonSubTypes(ChatMessage.class))
57-
.setMixInAnnotation(ChatMessage.class, JacksonMixins.NoneTypeInfoMixin.class);
58-
JACKSON.registerModule(module);
59-
}
6040
static final ObjectMapper JACKSON = getOrchestrationObjectMapper();
6141

6242
@Nonnull private final Supplier<HttpDestination> destinationSupplier;

orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationJacksonConfiguration.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import com.fasterxml.jackson.databind.ObjectMapper;
66
import com.fasterxml.jackson.databind.module.SimpleModule;
77
import com.google.common.annotations.Beta;
8-
import com.sap.ai.sdk.orchestration.model.ChatMessagesInner;
8+
import com.sap.ai.sdk.orchestration.model.ChatMessage;
99
import com.sap.ai.sdk.orchestration.model.LLMModuleResult;
1010
import com.sap.ai.sdk.orchestration.model.ModuleResultsOutputUnmaskingInner;
1111
import javax.annotation.Nonnull;
@@ -45,9 +45,9 @@ public static ObjectMapper getOrchestrationObjectMapper() {
4545
final var module =
4646
new SimpleModule()
4747
.addDeserializer(
48-
ChatMessagesInner.class,
49-
PolymorphicFallbackDeserializer.fromJsonSubTypes(ChatMessagesInner.class))
50-
.setMixInAnnotation(ChatMessagesInner.class, JacksonMixins.NoneTypeInfoMixin.class);
48+
ChatMessage.class,
49+
PolymorphicFallbackDeserializer.fromJsonSubTypes(ChatMessage.class))
50+
.setMixInAnnotation(ChatMessage.class, JacksonMixins.NoneTypeInfoMixin.class);
5151
jackson.registerModule(module);
5252
return jackson;
5353
}

orchestration/src/test/java/com/sap/ai/sdk/orchestration/OrchestrationUnitTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,7 @@ void filteringLoose() throws IOException {
309309
.sexual(ALLOW_SAFE_LOW_MEDIUM)
310310
.violence(ALLOW_SAFE_LOW_MEDIUM);
311311

312-
ContentFilter llamaFilter =
312+
final ContentFilter llamaFilter =
313313
() ->
314314
LlamaGuard38bFilterConfig.create()
315315
.type(LlamaGuard38bFilterConfig.TypeEnum.LLAMA_GUARD_3_8B)

orchestration/src/test/java/com/sap/ai/sdk/orchestration/spring/OrchestrationChatResponseTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22

33
import static org.assertj.core.api.Assertions.assertThat;
44

5-
import com.sap.ai.sdk.orchestration.model.ChatMessage;
65
import com.sap.ai.sdk.orchestration.model.LLMChoice;
76
import com.sap.ai.sdk.orchestration.model.LLMModuleResultSynchronous;
7+
import com.sap.ai.sdk.orchestration.model.ResponseChatMessage;
88
import com.sap.ai.sdk.orchestration.model.TokenUsage;
99
import java.util.List;
1010
import org.junit.jupiter.api.Test;
@@ -17,7 +17,7 @@ void testToAssistantMessage() {
1717
var choice =
1818
LLMChoice.create()
1919
.index(0)
20-
.message(ChatMessage.create().role("assistant").content("Hello, world!"))
20+
.message(ResponseChatMessage.create().role("assistant").content("Hello, world!"))
2121
.finishReason("stop");
2222

2323
AssistantMessage message = OrchestrationSpringChatResponse.toAssistantMessage(choice);

orchestration/src/test/resources/groundingRequest.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,9 @@
1717
"template" : [ {
1818
"role" : "system",
1919
"content" : "Context message with embedded grounding results. {{?results}}"
20-
} ]
20+
} ],
21+
"defaults" : { },
22+
"tools" : [ ]
2123
},
2224
"grounding_module_config" : {
2325
"type" : "document_grounding_service",

0 commit comments

Comments
 (0)