Skip to content

Commit b0e6701

Browse files
committed
change method names from addXYZ() to andXYZ()
1 parent dff4fb8 commit b0e6701

File tree

6 files changed

+25
-28
lines changed

6 files changed

+25
-28
lines changed

docs/guides/ORCHESTRATION_CHAT_COMPLETION.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ It's possible to add images and multiple text inputs to a message.
269269
An image can be added to an existing message as follows.
270270

271271
```java
272-
message.addImage("https://url.to/image.jpg");
272+
var newMessage = message.andImage("https://url.to/image.jpg");
273273
```
274274

275275
You can also construct a message with an image directly, using the `MessageContent` class.
@@ -281,7 +281,7 @@ var message = Message.user(MessageContent.image("https://url.to/image.jpg"));
281281
Some AI models, like GPT 4o, support additionally setting the detail level with which the image is read. This can be set via the `DetailLevel` parameter.
282282

283283
```java
284-
message.addImage("https://url.to/image.jpg", ImageItem.DetailLevel.low);
284+
var newMessage = message.andImage("https://url.to/image.jpg", ImageItem.DetailLevel.low);
285285
```
286286
Note, that currently only user messages are supported for image attachments.
287287

@@ -296,7 +296,7 @@ var message = Message.user("What is chess about?", "Answer in two sentences.");
296296
Or you can add additional text inputs to an existing message.
297297

298298
```java
299-
message.addText("Please use many emojis in your answer.");
299+
var newMessage = message.andText("Please use many emojis in your answer.");
300300
```
301301

302302
Note, that only user and system messages are supported for multiple text inputs.

orchestration/src/main/java/com/sap/ai/sdk/orchestration/AssistantMessage.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
package com.sap.ai.sdk.orchestration;
22

3-
import javax.annotation.Nonnull;
4-
53
import com.google.common.annotations.Beta;
4+
import javax.annotation.Nonnull;
65
import lombok.Getter;
76
import lombok.Value;
87
import lombok.experimental.Accessors;

orchestration/src/main/java/com/sap/ai/sdk/orchestration/SystemMessage.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
11
package com.sap.ai.sdk.orchestration;
22

3+
import com.google.common.annotations.Beta;
34
import java.util.List;
45
import java.util.stream.Stream;
56
import javax.annotation.Nonnull;
67
import javax.annotation.Nullable;
7-
8-
import com.google.common.annotations.Beta;
98
import lombok.Getter;
109
import lombok.Value;
1110
import lombok.experimental.Accessors;
@@ -50,7 +49,7 @@ public SystemMessage(@Nonnull final MessageContent messageContent) {
5049
* @return the new message.
5150
*/
5251
@Nonnull
53-
public SystemMessage addText(@Nonnull final String... messages) {
52+
public SystemMessage andText(@Nonnull final String... messages) {
5453
return new SystemMessage(
5554
new MessageContent(
5655
Stream.concat(
@@ -66,7 +65,7 @@ public SystemMessage addText(@Nonnull final String... messages) {
6665
* @return the new message.
6766
*/
6867
@Nonnull
69-
public SystemMessage add(@Nonnull final MessageContent... messageContents) {
68+
public SystemMessage and(@Nonnull final MessageContent... messageContents) {
7069
final List<ContentItem> combinedItems =
7170
Stream.concat(
7271
content.contentItemList().stream(),

orchestration/src/main/java/com/sap/ai/sdk/orchestration/UserMessage.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
11
package com.sap.ai.sdk.orchestration;
22

3+
import com.google.common.annotations.Beta;
34
import java.util.List;
45
import java.util.stream.Stream;
56
import javax.annotation.Nonnull;
67
import javax.annotation.Nullable;
7-
8-
import com.google.common.annotations.Beta;
98
import lombok.Getter;
109
import lombok.Value;
1110
import lombok.experimental.Accessors;
@@ -49,7 +48,7 @@ public UserMessage(@Nonnull final MessageContent messageContent) {
4948
* @return the new message.
5049
*/
5150
@Nonnull
52-
public UserMessage addText(@Nonnull final String... messages) {
51+
public UserMessage andText(@Nonnull final String... messages) {
5352
return new UserMessage(
5453
new MessageContent(
5554
Stream.concat(
@@ -65,7 +64,7 @@ public UserMessage addText(@Nonnull final String... messages) {
6564
* @return the new message.
6665
*/
6766
@Nonnull
68-
public UserMessage addImage(
67+
public UserMessage andImage(
6968
@Nonnull final String imageUrl, @Nullable final ImageItem.DetailLevel detailLevel) {
7069
return new UserMessage(
7170
new MessageContent(
@@ -82,7 +81,7 @@ public UserMessage addImage(
8281
* @return the new message.
8382
*/
8483
@Nonnull
85-
public UserMessage addImage(@Nonnull final String imageUrl) {
84+
public UserMessage andImage(@Nonnull final String imageUrl) {
8685
return new UserMessage(
8786
new MessageContent(
8887
Stream.concat(content.contentItemList().stream(), Stream.of(new ImageItem(imageUrl)))
@@ -96,7 +95,7 @@ public UserMessage addImage(@Nonnull final String imageUrl) {
9695
* @return the new message.
9796
*/
9897
@Nonnull
99-
public UserMessage add(@Nonnull final MessageContent... messageContents) {
98+
public UserMessage and(@Nonnull final MessageContent... messageContents) {
10099
final List<ContentItem> combinedItems =
101100
Stream.concat(
102101
content.contentItemList().stream(),

orchestration/src/test/java/com/sap/ai/sdk/orchestration/OrchestrationUnitTest.java

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -695,11 +695,11 @@ void testMultiMessage() throws IOException {
695695

696696
var messageWithTwoTexts =
697697
Message.system("Please answer in exactly two sentences.")
698-
.addText("Start the first sentence with the word 'Well'.");
698+
.andText("Start the first sentence with the word 'Well'.");
699699

700700
var messageWithImage =
701701
Message.user("What is in this image?")
702-
.addImage(
702+
.andImage(
703703
"https://upload.wikimedia.org/wikipedia/commons/thumb/5/59/SAP_2011_logo.svg/440px-SAP_2011_logo.svg.png");
704704
var prompt =
705705
new OrchestrationPrompt(messageWithImage).messageHistory(List.of(messageWithTwoTexts));
@@ -791,26 +791,26 @@ void testMultiMessage() throws IOException {
791791
@Test
792792
void testMessageConstruction() {
793793
var userMessageTwoTexts = Message.user("Text 1", "Text 2");
794-
var userMessageTwoTextsAddText = Message.user("Text 1").addText("Text 2");
795-
var userMessageTwoTextsAdd = Message.user("Text 1").add(MessageContent.text("Text 2"));
794+
var userMessageTwoTextsAddText = Message.user("Text 1").andText("Text 2");
795+
var userMessageTwoTextsAdd = Message.user("Text 1").and(MessageContent.text("Text 2"));
796796
var userMessageTwoTextsContent = Message.user(MessageContent.text("Text 1", "Text 2"));
797797
assertThat(userMessageTwoTexts).isEqualTo(userMessageTwoTextsAddText);
798798
assertThat(userMessageTwoTextsAddText).isEqualTo(userMessageTwoTextsAdd);
799799
assertThat(userMessageTwoTextsAdd).isEqualTo(userMessageTwoTextsContent);
800800

801-
var userMessageWithImageAddImage = Message.user("Text 1").addImage("url");
802-
var userMessageWithImageAdd = Message.user("Text 1").add(MessageContent.image("url"));
801+
var userMessageWithImageAddImage = Message.user("Text 1").andImage("url");
802+
var userMessageWithImageAdd = Message.user("Text 1").and(MessageContent.image("url"));
803803
assertThat(userMessageWithImageAddImage).isEqualTo(userMessageWithImageAdd);
804804

805805
var userMessageWithImageDetailAddImage =
806-
Message.user("Text 1").addImage("url", ImageItem.DetailLevel.low);
806+
Message.user("Text 1").andImage("url", ImageItem.DetailLevel.low);
807807
var userMessageWithImageDetailAdd =
808-
Message.user("Text 1").add(MessageContent.image("url", ImageItem.DetailLevel.low));
808+
Message.user("Text 1").and(MessageContent.image("url", ImageItem.DetailLevel.low));
809809
assertThat(userMessageWithImageDetailAddImage).isEqualTo(userMessageWithImageDetailAdd);
810810

811811
var systemMessageTwoTexts = Message.system("Text 1", "Text 2");
812-
var systemMessageTwoTextsAddText = Message.system("Text 1").addText("Text 2");
813-
var systemMessageTwoTextsAdd = Message.system("Text 1").add(MessageContent.text("Text 2"));
812+
var systemMessageTwoTextsAddText = Message.system("Text 1").andText("Text 2");
813+
var systemMessageTwoTextsAdd = Message.system("Text 1").and(MessageContent.text("Text 2"));
814814
var systemMessageTwoTextsContent = Message.system(MessageContent.text("Text 1", "Text 2"));
815815
assertThat(systemMessageTwoTexts).isEqualTo(systemMessageTwoTextsAddText);
816816
assertThat(systemMessageTwoTextsAddText).isEqualTo(systemMessageTwoTextsAdd);

sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/services/OrchestrationService.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ public OrchestrationChatResponse imageInput(@Nonnull final String pathToImage) {
8181
new OrchestrationModuleConfig().withLlmConfig(customGpt4o);
8282

8383
final var multiMessage =
84-
Message.user("What is in this image?").addImage(pathToImage, ImageItem.DetailLevel.low);
84+
Message.user("What is in this image?").andImage(pathToImage, ImageItem.DetailLevel.low);
8585
final var prompt = new OrchestrationPrompt(multiMessage);
8686
return client.chatCompletion(prompt, llmWithImageSupportConfig);
8787
}
@@ -95,8 +95,8 @@ public OrchestrationChatResponse imageInput(@Nonnull final String pathToImage) {
9595
public OrchestrationChatResponse multiStringInput(@Nonnull final List<String> questions) {
9696
final var multiMessage =
9797
Message.user(questions.get(0))
98-
.addText(questions.get(1))
99-
.add(MessageContent.text(questions.get(2)));
98+
.andText(questions.get(1))
99+
.and(MessageContent.text(questions.get(2)));
100100
final var prompt = new OrchestrationPrompt(multiMessage);
101101
return client.chatCompletion(prompt, config);
102102
}

0 commit comments

Comments
 (0)