Skip to content

Commit b7d7f6e

Browse files
MatKuhrMatKuhr
authored
[DevOps] Skip Code Generation By Default (#123)
* DevOps Skip Code Generation By Default * Fix pom file
1 parent 22b1362 commit b7d7f6e

File tree

3 files changed

+94
-92
lines changed

3 files changed

+94
-92
lines changed

‎.github/workflows/continuous-integration.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ jobs:
5050
5151
- name: "Build SDK"
5252
run: |
53-
MVN_ARGS="${{ env.MVN_MULTI_THREADED_ARGS }} clean install -DskipTests -DskipFormatting"
53+
MVN_ARGS="${{ env.MVN_MULTI_THREADED_ARGS }} clean install -Dgenerate -DskipTests -DskipFormatting"
5454
mvn $MVN_ARGS
5555
5656
- name: "Verify Local Changes"

‎core/pom.xml‎

Lines changed: 47 additions & 56 deletions
Original file line numberDiff line numberDiff line change
@@ -142,62 +142,53 @@
142142
</dependency>
143143
</dependencies>
144144

145-
<build>
146-
<plugins>
147-
<plugin>
148-
<artifactId>maven-clean-plugin</artifactId>
149-
<configuration>
150-
<filesets>
151-
<fileset>
152-
<directory>${project.basedir}/src/main/java/com/sap/ai/sdk/core/client</directory>
153-
<includes>
154-
<include>**/*</include>
155-
</includes>
156-
</fileset>
157-
</filesets>
158-
</configuration>
159-
<executions>
160-
<execution>
161-
<id>delete-aicore-generated-client</id>
162-
</execution>
163-
</executions>
164-
</plugin>
165-
<plugin>
166-
<groupId>com.sap.cloud.sdk.datamodel</groupId>
167-
<artifactId>openapi-generator-maven-plugin</artifactId>
168-
<configuration>
169-
<outputDirectory>${project.basedir}/src/main/java</outputDirectory>
170-
<apiMaturity>released</apiMaturity>
171-
<enableOneOfAnyOfGeneration>true</enableOneOfAnyOfGeneration>
172-
<compileScope>COMPILE</compileScope>
173-
<!-- Do not delete the output directory because it contains non-generated code -->
174-
<!-- The generated client is instead deleted by the maven-clean-plugin here above -->
175-
<deleteOutputDirectory>false</deleteOutputDirectory>
176-
</configuration>
177-
<executions>
178-
<execution>
179-
<id>aicore</id>
180-
<goals>
181-
<goal>generate</goal>
182-
</goals>
183-
<phase>generate-sources</phase>
145+
<profiles>
146+
<profile>
147+
<id>generate</id>
148+
<activation>
149+
<activeByDefault>false</activeByDefault>
150+
<property>
151+
<name>generate</name>
152+
</property>
153+
</activation>
154+
<build>
155+
<plugins>
156+
<plugin>
157+
<groupId>com.sap.cloud.sdk.datamodel</groupId>
158+
<artifactId>openapi-generator-maven-plugin</artifactId>
184159
<configuration>
185-
<inputSpec>${project.basedir}/src/main/resources/spec/aicore.yaml</inputSpec>
186-
<apiPackage>com.sap.ai.sdk.core.client</apiPackage>
187-
<modelPackage>com.sap.ai.sdk.core.client.model</modelPackage>
188-
<additionalProperties>
189-
<pojoBuilderMethodName>create</pojoBuilderMethodName>
190-
<pojoBuildMethodName/>
191-
<pojoConstructorVisibility>protected</pojoConstructorVisibility>
192-
<enumUnknownDefaultCase>true</enumUnknownDefaultCase>
193-
<removeOperationIdPrefix>true</removeOperationIdPrefix>
194-
<removeOperationIdPrefixDelimiter>\.</removeOperationIdPrefixDelimiter>
195-
<removeOperationIdPrefixCount>3</removeOperationIdPrefixCount>
196-
</additionalProperties>
160+
<outputDirectory>${project.basedir}/src/main/java</outputDirectory>
161+
<apiMaturity>released</apiMaturity>
162+
<enableOneOfAnyOfGeneration>true</enableOneOfAnyOfGeneration>
163+
<compileScope>COMPILE</compileScope>
164+
<deleteOutputDirectory>true</deleteOutputDirectory>
197165
</configuration>
198-
</execution>
199-
</executions>
200-
</plugin>
201-
</plugins>
202-
</build>
166+
<executions>
167+
<execution>
168+
<id>aicore</id>
169+
<goals>
170+
<goal>generate</goal>
171+
</goals>
172+
<phase>generate-sources</phase>
173+
<configuration>
174+
<inputSpec>${project.basedir}/src/main/resources/spec/aicore.yaml</inputSpec>
175+
<apiPackage>com.sap.ai.sdk.core.client</apiPackage>
176+
<modelPackage>com.sap.ai.sdk.core.client.model</modelPackage>
177+
<additionalProperties>
178+
<pojoBuilderMethodName>create</pojoBuilderMethodName>
179+
<pojoBuildMethodName/>
180+
<pojoConstructorVisibility>protected</pojoConstructorVisibility>
181+
<enumUnknownDefaultCase>true</enumUnknownDefaultCase>
182+
<removeOperationIdPrefix>true</removeOperationIdPrefix>
183+
<removeOperationIdPrefixDelimiter>\.</removeOperationIdPrefixDelimiter>
184+
<removeOperationIdPrefixCount>3</removeOperationIdPrefixCount>
185+
</additionalProperties>
186+
</configuration>
187+
</execution>
188+
</executions>
189+
</plugin>
190+
</plugins>
191+
</build>
192+
</profile>
193+
</profiles>
203194
</project>

‎orchestration/pom.xml‎

Lines changed: 46 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -120,41 +120,52 @@
120120
</dependency>
121121
</dependencies>
122122

123-
<build>
124-
<plugins>
125-
<plugin>
126-
<groupId>com.sap.cloud.sdk.datamodel</groupId>
127-
<artifactId>openapi-generator-maven-plugin</artifactId>
128-
<configuration>
129-
<skip>true</skip>
130-
<!-- skip automatic generation until we can omit API classes from code generation -->
131-
<outputDirectory>${project.basedir}/src/main/java</outputDirectory>
132-
<apiMaturity>beta</apiMaturity>
133-
<enableOneOfAnyOfGeneration>true</enableOneOfAnyOfGeneration>
134-
<compileScope>COMPILE</compileScope>
135-
<deleteOutputDirectory>true</deleteOutputDirectory>
136-
</configuration>
137-
<executions>
138-
<execution>
139-
<id>orchestration</id>
140-
<goals>
141-
<goal>generate</goal>
142-
</goals>
143-
<phase>generate-sources</phase>
123+
<profiles>
124+
<profile>
125+
<id>generate</id>
126+
<activation>
127+
<activeByDefault>false</activeByDefault>
128+
<property>
129+
<name>generate</name>
130+
</property>
131+
</activation>
132+
<build>
133+
<plugins>
134+
<plugin>
135+
<groupId>com.sap.cloud.sdk.datamodel</groupId>
136+
<artifactId>openapi-generator-maven-plugin</artifactId>
144137
<configuration>
145-
<inputSpec>${project.basedir}/src/main/resources/spec/orchestration.yaml</inputSpec>
146-
<apiPackage>com.sap.ai.sdk.orchestration.client</apiPackage>
147-
<modelPackage>com.sap.ai.sdk.orchestration.client.model</modelPackage>
148-
<additionalProperties>
149-
<pojoBuilderMethodName>create</pojoBuilderMethodName>
150-
<pojoBuildMethodName/>
151-
<pojoConstructorVisibility>protected</pojoConstructorVisibility>
152-
<enumUnknownDefaultCase>true</enumUnknownDefaultCase>
153-
</additionalProperties>
138+
<skip>true</skip>
139+
<!-- skip automatic generation until we can omit API classes from code generation -->
140+
<outputDirectory>${project.basedir}/src/main/java</outputDirectory>
141+
<apiMaturity>beta</apiMaturity>
142+
<enableOneOfAnyOfGeneration>true</enableOneOfAnyOfGeneration>
143+
<compileScope>COMPILE</compileScope>
144+
<deleteOutputDirectory>true</deleteOutputDirectory>
154145
</configuration>
155-
</execution>
156-
</executions>
157-
</plugin>
158-
</plugins>
159-
</build>
146+
<executions>
147+
<execution>
148+
<id>orchestration</id>
149+
<goals>
150+
<goal>generate</goal>
151+
</goals>
152+
<phase>generate-sources</phase>
153+
<configuration>
154+
<inputSpec>${project.basedir}/src/main/resources/spec/orchestration.yaml</inputSpec>
155+
<apiPackage>com.sap.ai.sdk.orchestration.client</apiPackage>
156+
<modelPackage>com.sap.ai.sdk.orchestration.client.model</modelPackage>
157+
<additionalProperties>
158+
<pojoBuilderMethodName>create</pojoBuilderMethodName>
159+
<pojoBuildMethodName/>
160+
<pojoConstructorVisibility>protected</pojoConstructorVisibility>
161+
<enumUnknownDefaultCase>true</enumUnknownDefaultCase>
162+
</additionalProperties>
163+
</configuration>
164+
</execution>
165+
</executions>
166+
</plugin>
167+
</plugins>
168+
</build>
169+
</profile>
170+
</profiles>
160171
</project>

0 commit comments

Comments
 (0)