Skip to content

Commit bc7bbe6

Browse files
committed
replace removed springframework.ai methods
1 parent 06877ab commit bc7bbe6

File tree

6 files changed

+27
-14
lines changed

6 files changed

+27
-14
lines changed

foundation-models/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/spring/OpenAiChatModel.java

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,11 @@ public Flux<ChatResponse> stream(@Nonnull final Prompt prompt) {
107107
});
108108
return flux.map(
109109
delta -> {
110-
val assistantMessage = new AssistantMessage(delta.getDeltaContent(), Map.of());
110+
val assistantMessage =
111+
AssistantMessage.builder()
112+
.content(delta.getDeltaContent())
113+
.properties(Map.of())
114+
.build();
111115
val metadata =
112116
ChatGenerationMetadata.builder().finishReason(delta.getFinishReason()).build();
113117
return new ChatResponse(List.of(new Generation(assistantMessage, metadata)));
@@ -173,7 +177,12 @@ private static Generation toGeneration(
173177
}
174178
}
175179

176-
val assistantMessage = new AssistantMessage(message.getContent(), Map.of(), calls);
180+
val assistantMessage =
181+
AssistantMessage.builder()
182+
.content(message.getContent())
183+
.properties(Map.of())
184+
.toolCalls(calls)
185+
.build();
177186
return new Generation(assistantMessage, metadata.build());
178187
}
179188

foundation-models/openai/src/test/java/com/sap/ai/sdk/foundationmodels/openai/spring/EmbeddingModelTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
import org.junit.jupiter.api.DisplayName;
2020
import org.junit.jupiter.api.Test;
2121
import org.springframework.ai.document.Document;
22-
import org.springframework.ai.embedding.EmbeddingOptionsBuilder;
22+
import org.springframework.ai.embedding.EmbeddingOptions;
2323
import org.springframework.ai.embedding.EmbeddingRequest;
2424

2525
class EmbeddingModelTest {
@@ -36,7 +36,7 @@ void setUp() {
3636
void testCallWithValidEmbeddingRequest() {
3737
val texts = List.of("Some text");
3838
val springAiRequest =
39-
new EmbeddingRequest(texts, EmbeddingOptionsBuilder.builder().withDimensions(128).build());
39+
new EmbeddingRequest(texts, EmbeddingOptions.builder().dimensions(128).build());
4040

4141
val expectedOpenAiResponse =
4242
new ObjectMapper()
@@ -67,7 +67,7 @@ void testCallWithValidEmbeddingRequest() {
6767
void testCallWithModelOptionSetThrows() {
6868
val springAiRequest =
6969
new EmbeddingRequest(
70-
List.of("Some text"), EmbeddingOptionsBuilder.builder().withModel("model").build());
70+
List.of("Some text"), EmbeddingOptions.builder().model("model").build());
7171

7272
val model = new OpenAiSpringEmbeddingModel(client);
7373

orchestration/src/main/java/com/sap/ai/sdk/orchestration/spring/OrchestrationSpringChatResponse.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,12 @@ static Generation toGeneration(@Nonnull final LLMChoice choice) {
5959
toolCall.getFunction().getArguments()))
6060
.toList();
6161

62-
val message = new AssistantMessage(choice.getMessage().getContent(), Map.of(), toolCalls);
62+
val message =
63+
AssistantMessage.builder()
64+
.content(choice.getMessage().getContent())
65+
.properties(Map.of())
66+
.toolCalls(toolCalls)
67+
.build();
6368
return new Generation(message, metadata.build());
6469
}
6570

orchestration/src/test/java/com/sap/ai/sdk/orchestration/spring/OrchestrationEmbeddingModelTest.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
import org.junit.jupiter.api.Test;
2525
import org.springframework.ai.document.MetadataMode;
2626
import org.springframework.ai.embedding.EmbeddingOptions;
27-
import org.springframework.ai.embedding.EmbeddingOptionsBuilder;
2827
import org.springframework.ai.embedding.EmbeddingRequest;
2928

3029
@WireMockTest
@@ -37,7 +36,7 @@ class OrchestrationEmbeddingModelTest {
3736

3837
@BeforeEach
3938
void setup(WireMockRuntimeInfo server) {
40-
options = EmbeddingOptionsBuilder.builder().withModel("text-embedding-3-small").build();
39+
options = EmbeddingOptions.builder().model("text-embedding-3-small").build();
4140

4241
final var destination = DefaultHttpDestination.builder(server.getHttpBaseUrl()).build();
4342
final var client = new OrchestrationClient(destination);
@@ -79,7 +78,7 @@ void testEmbeddingText() throws IOException {
7978
@Description("Tests that model must name must be set and request option precedes over default")
8079
void testEmbeddingWithMissingModelNameThrows() {
8180
final var request =
82-
new EmbeddingRequest(List.of("Hello World"), EmbeddingOptionsBuilder.builder().build());
81+
new EmbeddingRequest(List.of("Hello World"), EmbeddingOptions.builder().build());
8382

8483
assertThatThrownBy(() -> model.call(request))
8584
.isInstanceOf(NullPointerException.class)

sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/services/SpringAiOpenAiService.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
import org.springframework.ai.chat.model.ChatResponse;
1717
import org.springframework.ai.chat.prompt.Prompt;
1818
import org.springframework.ai.document.Document;
19-
import org.springframework.ai.embedding.EmbeddingOptionsBuilder;
19+
import org.springframework.ai.embedding.EmbeddingOptions;
2020
import org.springframework.ai.embedding.EmbeddingRequest;
2121
import org.springframework.ai.embedding.EmbeddingResponse;
2222
import org.springframework.ai.model.tool.DefaultToolCallingChatOptions;
@@ -40,7 +40,7 @@ public class SpringAiOpenAiService {
4040
*/
4141
@Nonnull
4242
public EmbeddingResponse embedStrings() {
43-
final var options = EmbeddingOptionsBuilder.builder().withDimensions(128).build();
43+
final var options = EmbeddingOptions.builder().dimensions(128).build();
4444
final var springAiRequest =
4545
new EmbeddingRequest(List.of("The quick brown fox jumps over the lazy dog."), options);
4646

sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/services/SpringAiOrchestrationService.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
import org.springframework.ai.chat.model.ChatResponse;
3232
import org.springframework.ai.chat.prompt.Prompt;
3333
import org.springframework.ai.chat.prompt.PromptTemplate;
34-
import org.springframework.ai.embedding.EmbeddingOptionsBuilder;
34+
import org.springframework.ai.embedding.EmbeddingOptions;
3535
import org.springframework.ai.support.ToolCallbacks;
3636
import org.springframework.ai.tool.ToolCallbackProvider;
3737
import org.springframework.beans.factory.annotation.Autowired;
@@ -276,8 +276,8 @@ public Translation responseFormat() {
276276
@Nonnull
277277
public float[] embed(@Nonnull final String inputText) {
278278
val embedOptions =
279-
EmbeddingOptionsBuilder.builder()
280-
.withModel(OrchestrationEmbeddingModel.TEXT_EMBEDDING_3_SMALL.name())
279+
EmbeddingOptions.builder()
280+
.model(OrchestrationEmbeddingModel.TEXT_EMBEDDING_3_SMALL.name())
281281
.build();
282282
return new OrchestrationSpringEmbeddingModel(embedOptions).embed(inputText);
283283
}

0 commit comments

Comments
 (0)