Skip to content

Commit bd60969

Browse files
committed
Splitting Test and updating minor comments.
1 parent 48984a2 commit bd60969

File tree

2 files changed

+13
-8
lines changed

2 files changed

+13
-8
lines changed

orchestration/src/main/java/com/sap/ai/sdk/orchestration/DpiMasking.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
@RequiredArgsConstructor(access = AccessLevel.PRIVATE)
3535
public class DpiMasking implements MaskingProvider {
3636
@Nonnull DPIConfig.MethodEnum maskingMethod;
37-
@Nonnull List<DPIEntityConfig> entitiesDTO;
37+
@Nonnull List<DPIEntityConfig> entitiesConfig;
3838
@With boolean maskGroundingInput;
3939
@Nonnull List<String> allowList;
4040

@@ -77,11 +77,11 @@ public static class Builder {
7777
@Nonnull
7878
public DpiMasking withEntities(
7979
@Nonnull final DPIEntities entity, @Nonnull final DPIEntities... entities) {
80-
val entitiesDTO =
80+
val entitiesConfig =
8181
Stream.concat(Stream.of(entity), Arrays.stream(entities))
8282
.map(it -> (DPIEntityConfig) DPIStandardEntity.create().type(it))
8383
.toList();
84-
return new DpiMasking(maskingMethod, entitiesDTO, false, List.of());
84+
return new DpiMasking(maskingMethod, entitiesConfig, false, List.of());
8585
}
8686

8787
/**
@@ -121,7 +121,7 @@ public DpiMasking withRegex(@Nonnull final String regex, @Nonnull final String r
121121
DPIMethodConstant.create()
122122
.method(DPIMethodConstant.MethodEnum.CONSTANT)
123123
.value(replacement));
124-
val newEntities = new java.util.ArrayList<>(entitiesDTO);
124+
val newEntities = new java.util.ArrayList<>(entitiesConfig);
125125
newEntities.add(customEntity);
126126
return new DpiMasking(maskingMethod, newEntities, maskGroundingInput, allowList);
127127
}
@@ -134,7 +134,7 @@ public DpiMasking withRegex(@Nonnull final String regex, @Nonnull final String r
134134
*/
135135
@Nonnull
136136
public DpiMasking withAllowList(@Nonnull final List<String> allowList) {
137-
return new DpiMasking(maskingMethod, entitiesDTO, maskGroundingInput, allowList);
137+
return new DpiMasking(maskingMethod, entitiesConfig, maskGroundingInput, allowList);
138138
}
139139

140140
@Nonnull
@@ -143,7 +143,7 @@ public DPIConfig createConfig() {
143143
return DPIConfig.create()
144144
.type(SAP_DATA_PRIVACY_INTEGRATION)
145145
.method(maskingMethod)
146-
.entities(entitiesDTO)
146+
.entities(entitiesConfig)
147147
.maskGroundingInput(DPIConfigMaskGroundingInput.create().enabled(maskGroundingInput))
148148
.allowlist(allowList);
149149
}

orchestration/src/test/java/com/sap/ai/sdk/orchestration/OrchestrationModuleConfigTest.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,16 +106,21 @@ void testDpiMaskingConfig() {
106106
assertThat(((MaskingModuleConfigProviders) configModified.getMaskingConfig()).getProviders())
107107
.withFailMessage("withMaskingConfig() should overwrite the existing config and not append")
108108
.hasSize(1);
109+
}
110+
111+
@Test
112+
void testCustomRegex() {
109113

110114
var masking =
111115
DpiMasking.anonymization()
112116
.withRegex("\\d{3}-\\d{2}-\\d{4}", "***-**-****")
113117
.withRegex("\\d{2}-\\d{2}-\\d{5}", "**-**-*****");
114-
config = config.withMaskingConfig(masking);
118+
var config = new OrchestrationModuleConfig().withLlmConfig(GPT_4O).withMaskingConfig(masking);
115119
assertThat(config.getMaskingConfig()).isNotNull();
116120
assertThat(((MaskingModuleConfigProviders) config.getMaskingConfig()).getProviders())
117121
.hasSize(1);
118-
dpiConfig = ((MaskingModuleConfigProviders) config.getMaskingConfig()).getProviders().get(0);
122+
DPIConfig dpiConfig =
123+
((MaskingModuleConfigProviders) config.getMaskingConfig()).getProviders().get(0);
119124
assertThat(dpiConfig.getMethod()).isEqualTo(DPIConfig.MethodEnum.ANONYMIZATION);
120125
assertThat(dpiConfig.getEntities()).hasSize(2);
121126
assertThat(((DPICustomEntity) dpiConfig.getEntities().get(0)).getRegex())

0 commit comments

Comments
 (0)