Removed isError

Author: CharlesDuboisSAP

core/src/main/java/com/sap/ai/sdk/core/common/ClientStreamingHandler.java

@@ -1,6 +1,7 @@
 package com.sap.ai.sdk.core.common;
 
 import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.databind.JsonNode;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.google.common.annotations.Beta;
 import java.io.IOException;
@@ -78,12 +79,12 @@ public Stream<D> handleStreamingResponse(@Nonnull final ClassicHttpResponse resp
             line -> {
               final String data = line.substring(5); // remove "data: "
               try {
-                final D delta = objectMapper.readValue(data, successType);
-                if (delta.isError()) {
+                final JsonNode jsonNode = objectMapper.readTree(data);
+                if (jsonNode.has("error")) {
                   throwErrorType(response, data);
                 }
-                return delta;
-              } catch (final IOException e) { // exception message e gets lost
+                return objectMapper.treeToValue(jsonNode, successType);
+              } catch (final IOException e) {
                 log.error("Failed to parse delta chunk to type {}", successType);
                 final String message = "Failed to parse delta chunk";
                 throw exceptionFactory.build(message, e).setHttpResponse(response);

core/src/main/java/com/sap/ai/sdk/core/common/StreamedDelta.java

@@ -42,11 +42,4 @@ public interface StreamedDelta {
    */
   @Nullable
   String getFinishReason();
-
-  /**
-   * Indicates if the delta is an error of type {@link ClientError}
-   *
-   * @return true if the delta is an error, false otherwise.
-   */
-  boolean isError();
 }

core/src/test/java/com/sap/ai/sdk/core/common/ClientStreamingHandlerTest.java

@@ -40,11 +40,6 @@ public String getDeltaContent() {
     public String getFinishReason() {
       return finishReason;
     }
-
-    @Override
-    public boolean isError() {
-      return false;
-    }
   }
 
   @SneakyThrows

foundation-models/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiChatCompletionDelta.java

@@ -51,11 +51,6 @@ public String getFinishReason() {
     return null;
   }
 
-  @Override
-  public boolean isError() {
-    return originalResponse.getCustomFieldNames().contains("error");
-  }
-
   /**
    * Retrieves the completion usage from the response, or null if it is not available.
    *

foundation-models/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/model/OpenAiChatCompletionDelta.java

@@ -21,11 +21,6 @@ public class OpenAiChatCompletionDelta extends OpenAiCompletionOutput implements
   @Getter(onMethod_ = @Nonnull)
   private List<OpenAiDeltaChatCompletionChoice> choices;
 
-  /** error field in case of an error. */
-  @JsonProperty("error")
-  @Getter(onMethod_ = @Nullable)
-  private Object error;
-
   /**
    * Can be used in conjunction with the seed request parameter to understand when backend changes
    * have been made that might impact determinism.
@@ -64,9 +59,4 @@ && getChoices().get(0).getIndex() == 0) {
     }
     return null;
   }
-
-  @Override
-  public boolean isError() {
-    return error != null;
-  }
 }

orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationChatCompletionDelta.java

@@ -31,9 +31,4 @@ public String getDeltaContent() {
   public String getFinishReason() {
     return getFinalResult().getChoices().get(0).getFinishReason();
   }
-
-  @Override
-  public boolean isError() {
-    return getCustomFieldNames().contains("error");
-  }
 }