Review suggestion

Author: rpanackal

core/src/main/java/com/sap/ai/sdk/core/common/ClientResponseHandler.java

@@ -36,10 +36,10 @@ public class ClientResponseHandler<T, R extends ClientError, E extends ClientExc
   @Nonnull final Class<T> successType;
 
   /** The HTTP error response type */
-  @Nonnull protected final Class<R> errorType;
+  @Nonnull final Class<R> errorType;
 
   /** The factory to create exceptions for Http 4xx/5xx responses. */
-  @Nonnull protected final ClientExceptionFactory<E, R> exceptionFactory;
+  @Nonnull final ClientExceptionFactory<E, R> exceptionFactory;
 
   /** The parses for JSON responses, will be private once we can remove mixins */
   @Nonnull ObjectMapper objectMapper = getDefaultObjectMapper();

core/src/test/java/com/sap/ai/sdk/core/common/ClientStreamingHandlerTest.java

@@ -44,7 +44,7 @@ public String getFinishReason() {
 
   @SneakyThrows
   @Test
-  void testHandleStreamingResponse_variousScenarios() {
+  void testHandleStreamingResponse() {
     var sut =
         new ClientStreamingHandler<>(
             MyStreamedDelta.class, MyError.class, new MyExceptionFactory());
@@ -97,12 +97,12 @@ void testHandleStreamingResponse_variousScenarios() {
     assertThat(stream2).isEmpty();
 
     var stream3 = sut.handleStreamingResponse(response);
-    assertThatThrownBy(() -> stream3.toList())
+    assertThatThrownBy(stream3::toList)
         .isInstanceOf(MyException.class)
         .hasMessageContaining("Failed to parse response");
 
     var stream4 = sut.handleStreamingResponse(response);
-    assertThatThrownBy(() -> stream4.toList())
+    assertThatThrownBy(stream4::toList)
         .isInstanceOf(MyException.class)
         .hasMessageContaining("Failed to parse delta chunk")
         .hasCauseInstanceOf(JsonParseException.class);

sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/controllers/OrchestrationController.java

@@ -131,13 +131,13 @@ Object inputFiltering(
     } catch (OrchestrationInputFilterException e) {
       final var msg =
           new StringBuilder(
-              "Failed to obtain a response as the content was flagged by input filter. Error %d"
+              "[Http %d] Failed to obtain a response as the content was flagged by input filter. "
                   .formatted(e.getStatusCode()));
 
       Optional.ofNullable(e.getAzureContentSafetyInput())
-          .map(AzureContentSafetyInput::getHate)
+          .map(AzureContentSafetyInput::getViolence)
           .filter(rating -> rating.compareTo(policy.getAzureThreshold()) > 0)
-          .ifPresent(rating -> msg.append("Hate score %d".formatted(rating.getValue())));
+          .ifPresent(rating -> msg.append("Violence score %d".formatted(rating.getValue())));
 
       log.debug(msg.toString(), e);
       return ResponseEntity.internalServerError().body(msg.toString());
@@ -163,12 +163,12 @@ Object outputFiltering(
     } catch (OrchestrationOutputFilterException e) {
       final var msg =
           new StringBuilder(
-              "Failed to obtain a response as the content was flagged by output filter.");
+              "Failed to obtain a response as the content was flagged by output filter. ");
 
       Optional.ofNullable(e.getAzureContentSafetyOutput())
-          .map(AzureContentSafetyOutput::getHate)
+          .map(AzureContentSafetyOutput::getViolence)
           .filter(rating -> rating.compareTo(policy.getAzureThreshold()) > 0)
-          .ifPresent(rating -> msg.append("Hate score %d ".formatted(rating.getValue())));
+          .ifPresent(rating -> msg.append("Violence score %d ".formatted(rating.getValue())));
 
       log.debug(msg.toString(), e);
       return ResponseEntity.internalServerError().body(msg.toString());
@@ -190,9 +190,12 @@ Object llamaGuardInputFiltering(
     try {
       response = service.llamaGuardInputFilter(enabled);
     } catch (OrchestrationInputFilterException e) {
-      final var msg =
-          "Failed to obtain a response as the content was flagged by input filter. Error %d"
+      var msg =
+          "[Http %d] Failed to obtain a response as the content was flagged by input filter. "
               .formatted(e.getStatusCode());
+      if(e.getLlamaGuard38b() != null){
+        msg += " Violent crimes are %s".formatted(e.getLlamaGuard38b().isViolentCrimes());
+      }
       log.debug(msg, e);
       return ResponseEntity.internalServerError().body(msg);
     }