Skip to content

Commit d91ca3b

Browse files
committed
Rename convenience methods to withXyz()
1 parent 3dd3085 commit d91ca3b

File tree

5 files changed

+11
-11
lines changed

5 files changed

+11
-11
lines changed

orchestration/src/main/java/com/sap/ai/sdk/orchestration/SystemMessage.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ public SystemMessage(@Nonnull final MessageContent messageContent) {
4646
* @return the new message.
4747
*/
4848
@Nonnull
49-
public SystemMessage andText(@Nonnull final String message) {
49+
public SystemMessage withText(@Nonnull final String message) {
5050
final var contentItems = new LinkedList<>(content.contentItemList());
5151
contentItems.add(new TextItem(message));
5252
return new SystemMessage(new MessageContent(contentItems));

orchestration/src/main/java/com/sap/ai/sdk/orchestration/UserMessage.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ public UserMessage(@Nonnull final String message) {
3939
* @return the new message.
4040
*/
4141
@Nonnull
42-
public UserMessage andText(@Nonnull final String message) {
42+
public UserMessage withText(@Nonnull final String message) {
4343
final var contentItems = new LinkedList<>(content.contentItemList());
4444
contentItems.add(new TextItem(message));
4545
return new UserMessage(new MessageContent(contentItems));
@@ -53,7 +53,7 @@ public UserMessage andText(@Nonnull final String message) {
5353
* @return the new message.
5454
*/
5555
@Nonnull
56-
public UserMessage andImage(
56+
public UserMessage withImage(
5757
@Nonnull final String imageUrl, @Nonnull final ImageItem.DetailLevel detailLevel) {
5858
final var contentItems = new LinkedList<>(content.contentItemList());
5959
contentItems.add(new ImageItem(imageUrl, detailLevel));
@@ -67,7 +67,7 @@ public UserMessage andImage(
6767
* @return the new message.
6868
*/
6969
@Nonnull
70-
public UserMessage andImage(@Nonnull final String imageUrl) {
70+
public UserMessage withImage(@Nonnull final String imageUrl) {
7171
final var contentItems = new LinkedList<>(content.contentItemList());
7272
contentItems.add(new ImageItem(imageUrl));
7373
return new UserMessage(new MessageContent(contentItems));

orchestration/src/test/java/com/sap/ai/sdk/orchestration/OrchestrationConvenienceUnitTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,9 @@ void testMessageConstructionImage() {
2525
new UserMessage(new MessageContent(List.of(new ImageItem("url"))));
2626
assertThat(userMessageOnlyImageBase).isEqualTo(userMessageOnlyImageConvenience);
2727

28-
var userMessageWithImage = Message.user("Text 1").andImage("url");
28+
var userMessageWithImage = Message.user("Text 1").withImage("url");
2929
var userMessageWithImageAndDetail =
30-
Message.user("Text 1").andImage("url", ImageItem.DetailLevel.AUTO);
30+
Message.user("Text 1").withImage("url", ImageItem.DetailLevel.AUTO);
3131
assertThat(userMessageWithImage).isEqualTo(userMessageWithImageAndDetail);
3232
}
3333
}

orchestration/src/test/java/com/sap/ai/sdk/orchestration/OrchestrationUnitTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -687,12 +687,12 @@ void testMultiMessage() throws IOException {
687687

688688
var messageWithTwoTexts =
689689
Message.system("Please answer in exactly two sentences.")
690-
.andText("Start the first sentence with the word 'Well'.");
690+
.withText("Start the first sentence with the word 'Well'.");
691691

692692
var messageWithImage =
693693
Message.user("What is in this image?")
694-
.andText("And what is the main color?")
695-
.andImage(
694+
.withText("And what is the main color?")
695+
.withImage(
696696
"https://upload.wikimedia.org/wikipedia/commons/thumb/5/59/SAP_2011_logo.svg/440px-SAP_2011_logo.svg.png");
697697
var prompt =
698698
new OrchestrationPrompt(messageWithImage).messageHistory(List.of(messageWithTwoTexts));

sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/services/OrchestrationService.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ public OrchestrationChatResponse imageInput(@Nonnull final String pathToImage) {
6666
new OrchestrationModuleConfig().withLlmConfig(GPT_4O_MINI);
6767

6868
final var multiMessage =
69-
Message.user("What is in this image?").andImage(pathToImage, ImageItem.DetailLevel.LOW);
69+
Message.user("What is in this image?").withImage(pathToImage, ImageItem.DetailLevel.LOW);
7070
final var prompt = new OrchestrationPrompt(multiMessage);
7171
return client.chatCompletion(prompt, llmWithImageSupportConfig);
7272
}
@@ -79,7 +79,7 @@ public OrchestrationChatResponse imageInput(@Nonnull final String pathToImage) {
7979
@Nonnull
8080
public OrchestrationChatResponse multiStringInput(@Nonnull final List<String> questions) {
8181
final var multiMessage =
82-
Message.user(questions.get(0)).andText(questions.get(1)).andText(questions.get(2));
82+
Message.user(questions.get(0)).withText(questions.get(1)).withText(questions.get(2));
8383
final var prompt = new OrchestrationPrompt(multiMessage);
8484
return client.chatCompletion(prompt, config);
8585
}

0 commit comments

Comments
 (0)