Fixing PR comments

Author: n-o-u-r-h-a-n

orchestration/src/main/java/com/sap/ai/sdk/orchestration/DpiMasking.java

@@ -105,6 +105,18 @@ public DpiMasking withRegex(@Nonnull final String regex, @Nonnull final String r
     }
   }
 
+  /**
+   * Specifies a custom regex pattern for masking.
+   *
+   * @param regex The regex pattern to match
+   * @param replacement The replacement string
+   * @return A new {@link DpiMasking} instance
+   */
+  @Nonnull
+  public DpiMasking withRegex(@Nonnull final String regex, @Nonnull final String replacement) {
+    return new DpiMasking(maskingMethod, entities, customEntities, maskGroundingInput, allowList);
+  }
+
   /**
    * Set words that should not be masked.
    *

sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/controllers/OrchestrationController.java

@@ -216,6 +216,17 @@ Object maskingAnonymization(
     return response.getContent();
   }
 
+  @GetMapping("/maskingRegex")
+  @Nonnull
+    Object maskingRegex(
+        @Nullable @RequestParam(value = "format", required = false) final String format) {
+        final var response = service.maskingRegex();
+        if ("json".equals(format)) {
+        return response;
+        }
+        return response.getContent();
+    }
+
   @GetMapping("/completion/{resourceGroup}")
   @Nonnull
   Object completionWithResourceGroup(

sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/services/OrchestrationService.java

@@ -274,19 +274,18 @@ public OrchestrationChatResponse maskingAnonymization(@Nonnull final DPIEntities
 
     return client.chatCompletion(prompt, configWithMasking);
   }
-
-  /**
-   * Let the orchestration service evaluate the feedback on the AI SDK provided by a hypothetical
-   * user. Anonymize any patient IDs given as they are not relevant for judging the sentiment of the
-   * feedback.
-   *
-   * @link <a
-   *     href="https://help.sap.com/docs/sap-ai-core/sap-ai-core-service-guide/data-masking">SAP AI
-   *     Core: Orchestration - Data Masking</a>
-   * @return the assistant response object
-   */
+    /**
+     * Let the orchestration service evaluate the feedback on the AI SDK provided by a hypothetical
+     * user. Mask any patient IDs given as they are not relevant for judging the sentiment of the
+     * feedback.
+     *
+     * @link <a
+     *     href="https://help.sap.com/docs/sap-ai-core/sap-ai-core-service-guide/data-masking">SAP AI
+     *     Core: Orchestration - Data Masking</a>
+     * @return the assistant response object
+     */
   @Nonnull
-  public OrchestrationChatResponse maskingCustomAnonymization() {
+  public OrchestrationChatResponse maskingRegex() {
     val systemMessage = Message.system("Repeat following messages");
     val userMessage = Message.user("The patient id is patient_id_123.");
 

sample-code/spring-app/src/main/resources/static/index.html

@@ -380,6 +380,23 @@ <h2>Orchestration</h2>
                                         </div>
                                     </div>
                                 </li>
+                                <li class="list-group-item">
+                                    <div class="info-tooltip">
+                                        <button type="submit"
+                                                formaction="/orchestration/maskingRegex"
+                                                class="link-offset-2-hover link-underline link-underline-opacity-0 link-underline-opacity-75-hover endpoint">
+                                            <code>/orchestration/maskingRegex</code>
+                                        </button>
+                                        <div class="tooltip-content">
+                                            Let the orchestration service evaluate the feedback on
+                                            the AI SDK provided by a
+                                            hypothetical
+                                            user. Mask any patient IDs given as they are not relevant for judging the
+                                            sentiment of the
+                                            feedback.
+                                        </div>
+                                    </div>
+                                </li>
                                 <li class="list-group-item">
                                     <div class="info-tooltip">
                                         <button type="submit"

sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/controllers/OrchestrationTest.java

@@ -151,8 +151,8 @@ void testMaskingAnonymization() {
   }
 
   @Test
-  void testMaskingCustomAnonymization() {
-    var response = service.maskingCustomAnonymization();
+  void testMaskingRegex() {
+    var response = service.maskingRegex();
     var result = response.getOriginalResponse();
     var llmChoice = result.getFinalResult().getChoices().get(0);
     assertThat(llmChoice.getFinishReason()).isEqualTo("stop");