Skip to content

Commit e0170b7

Browse files
committed
Merge branch 'main' into fix-sample-app-messages
2 parents fef0d03 + 11c03a0 commit e0170b7

File tree

4 files changed

+15
-14
lines changed

4 files changed

+15
-14
lines changed

docs/guides/AI_CORE_DEPLOYMENT.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -73,12 +73,12 @@ Use the following code snippet to create a deployment in SAP AI Core:
7373
```java
7474
var api = new DeploymentApi();
7575
var resourceGroupId = "default";
76+
var configurationId = "12345-123-123-123-123456abcdefg";
7677

77-
AiDeploymentCreationRequest request =
78-
AiDeploymentCreationRequest.create().configurationId("12345-123-123-123-123456abcdefg");
79-
AiDeploymentCreationResponse deployment = api.create(resourceGroupId, request);
78+
var request = AiDeploymentCreationRequest.create().configurationId(configurationId);
79+
var deployment = api.create(resourceGroupId, request);
8080

81-
var id = deployment.getId();
81+
String id = deployment.getId();
8282
AiExecutionStatus status = deployment.getStatus();
8383
```
8484

docs/guides/OPENAI_CHAT_COMPLETION.md

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ In addition to the prerequisites above, we assume you have already set up the fo
9090
### Simple chat completion
9191

9292
```java
93-
OpenAiChatCompletionOutput result =
93+
var result =
9494
OpenAiClient.forModel(GPT_35_TURBO)
9595
.withSystemPrompt("You are a helpful AI")
9696
.chatCompletion("Hello World! Why is this phrase so famous?");
@@ -117,8 +117,7 @@ var userMessage =
117117
var request =
118118
new OpenAiChatCompletionParameters().addMessages(systemMessage, userMessage);
119119

120-
OpenAiChatCompletionOutput result =
121-
OpenAiClient.forModel(GPT_35_TURBO).chatCompletion(request);
120+
var result = OpenAiClient.forModel(GPT_35_TURBO).chatCompletion(request);
122121

123122
String resultMessage = result.getContent();
124123
```
@@ -177,12 +176,12 @@ Any asynchronous library can be used, such as the classic Thread API.
177176
```java
178177
var message = "Can you give me the first 100 numbers of the Fibonacci sequence?";
179178

180-
OpenAiChatMessage.OpenAiChatUserMessage userMessage =
179+
var userMessage =
181180
new OpenAiChatMessage.OpenAiChatUserMessage().addText(message);
182-
OpenAiChatCompletionParameters requestParameters =
181+
var requestParameters =
183182
new OpenAiChatCompletionParameters().addMessages(userMessage);
184183

185-
OpenAiClient client = OpenAiClient.forModel(GPT_35_TURBO);
184+
var client = OpenAiClient.forModel(GPT_35_TURBO);
186185
var totalOutput = new OpenAiChatCompletionOutput();
187186

188187
// Prepare the stream before starting the thread to handle any initialization exceptions
@@ -216,7 +215,7 @@ Boot's `ResponseBodyEmitter` to stream the chat completion delta messages to the
216215
Get the embeddings of a text input in list of float values:
217216

218217
```java
219-
OpenAiEmbeddingParameters request = new OpenAiEmbeddingParameters().setInput("Hello World");
218+
var request = new OpenAiEmbeddingParameters().setInput("Hello World");
220219

221220
OpenAiEmbeddingOutput embedding = OpenAiClient.forModel(TEXT_EMBEDDING_ADA_002).embedding(request);
222221
```

foundation-models/openai/src/test/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiClientTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -377,7 +377,9 @@ void embedding() {
377377

378378
verify(
379379
postRequestedFor(urlPathEqualTo("/embeddings"))
380-
.withRequestBody(equalToJson("""
380+
.withRequestBody(
381+
equalToJson(
382+
"""
381383
{"input":["Hello World"]}""")));
382384
}
383385

pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@
6767
<dotenv-java.version>3.1.0</dotenv-java.version>
6868
<mockito.version>5.15.2</mockito.version>
6969
<!-- Formatting -->
70-
<spotless.version>2.43.0</spotless.version>
70+
<spotless.version>2.44.1</spotless.version>
7171
<spotless.skip>false</spotless.skip>
7272
<!-- Quality assurance -->
7373
<enforcer.skip>false</enforcer.skip>
@@ -783,7 +783,7 @@ https://gitbox.apache.org/repos/asf?p=maven-pmd-plugin.git;a=blob_plain;f=src/ma
783783
<plugin>
784784
<groupId>org.sonatype.central</groupId>
785785
<artifactId>central-publishing-maven-plugin</artifactId>
786-
<version>0.6.0</version>
786+
<version>0.7.0</version>
787787
<extensions>true</extensions>
788788
<configuration>
789789
<deploymentName>SAP AI SDK ${project.version}</deploymentName>

0 commit comments

Comments
 (0)