Work in progress

Author: Jonas-Isr

orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationAiModel.java

@@ -3,10 +3,12 @@
 import com.sap.ai.sdk.orchestration.client.model.LLMModuleConfig;
 import java.util.Map;
 import javax.annotation.Nonnull;
+import lombok.Getter;
 
 /** Large language models available in Orchestration. */
 // https://help.sap.com/docs/sap-ai-core/sap-ai-core-service-guide/models-and-scenarios-in-generative-ai-hub
-public class OrchestrationAiModel extends LLMModuleConfig {
+public class OrchestrationAiModel {
+  @Getter private final LLMModuleConfig config;
 
   /** IBM Granite 13B chat completions model */
   public static final OrchestrationAiModel IBM_GRANITE_13B_CHAT =
@@ -114,7 +116,15 @@ public class OrchestrationAiModel extends LLMModuleConfig {
       new OrchestrationAiModel("gemini-1.5-flash");
 
   OrchestrationAiModel(@Nonnull final String modelName) {
-    setModelName(modelName);
-    setModelParams(Map.of());
+    config = LLMModuleConfig.create().modelName(modelName).modelParams(Map.of());
+  }
+
+  private OrchestrationAiModel(
+      @Nonnull final String modelName, Map<String, ? extends Number> modelParams) {
+    config = LLMModuleConfig.create().modelName(modelName).modelParams(modelParams);
+  }
+
+  public OrchestrationAiModel modelParams(Map<String, ? extends Number> modelParams) {
+    return new OrchestrationAiModel(config.getModelName(), modelParams);
   }
 }

orchestration/src/test/java/com/sap/ai/sdk/orchestration/OrchestrationUnitTest.java

@@ -57,12 +57,14 @@
 @WireMockTest
 class OrchestrationUnitTest {
   static final LLMModuleConfig LLM_CONFIG =
-      OrchestrationAiModel.GPT_35_TURBO_16K.modelParams(
-          Map.of(
-              "max_tokens", 50,
-              "temperature", 0.1,
-              "frequency_penalty", 0,
-              "presence_penalty", 0));
+      OrchestrationAiModel.GPT_35_TURBO_16K
+          .modelParams(
+              Map.of(
+                  "max_tokens", 50,
+                  "temperature", 0.1,
+                  "frequency_penalty", 0,
+                  "presence_penalty", 0))
+          .getConfig();
   private final Function<String, InputStream> fileLoader =
       filename -> Objects.requireNonNull(getClass().getClassLoader().getResourceAsStream(filename));
 

sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/controllers/OrchestrationController.java

@@ -33,7 +33,7 @@
 class OrchestrationController {
 
   private final OrchestrationClient client = new OrchestrationClient();
-  OrchestrationModuleConfig config = new OrchestrationModuleConfig().withLlmConfig(GPT_35_TURBO);
+  OrchestrationModuleConfig config = new OrchestrationModuleConfig().withLlmConfig(GPT_35_TURBO.getConfig());
 
   /**
    * Chat request to OpenAI through the Orchestration service with a simple prompt.