Updated Test cases (#27)

This commit includes the changes required to make the outdated test cases consistent with the current implementation.
+
removing the soon to be deprecated(ginkgo v2) ginkgo behavior of passing Done channel in test cases.

Author: raheel-ahmad

cf_cli_java_plugin.go

@@ -83,7 +83,7 @@ func (c *JavaPlugin) Run(cliConnection plugin.CliConnection, args []string) {
 }
 
 // DoRun is an internal method that we use to wrap the cmd package with CommandExecutor for test purposes
-func (c *JavaPlugin) DoRun(commandExecutor cmd.CommandExecutor, uuidGenerator uuid.UUIDGenerator, util utils.CfJavaPluginUtilImpl, args []string) (string, error) {
+func (c *JavaPlugin) DoRun(commandExecutor cmd.CommandExecutor, uuidGenerator uuid.UUIDGenerator, util utils.CfJavaPluginUtil, args []string) (string, error) {
 	traceLogger := trace.NewLogger(os.Stdout, true, os.Getenv("CF_TRACE"), "")
 	ui := terminal.NewUI(os.Stdin, os.Stdout, terminal.NewTeePrinter(os.Stdout), traceLogger)
 
@@ -103,7 +103,7 @@ func (c *JavaPlugin) DoRun(commandExecutor cmd.CommandExecutor, uuidGenerator uu
 	return output, err
 }
 
-func (c *JavaPlugin) execute(commandExecutor cmd.CommandExecutor, uuidGenerator uuid.UUIDGenerator, util utils.CfJavaPluginUtilImpl, args []string) (string, error) {
+func (c *JavaPlugin) execute(commandExecutor cmd.CommandExecutor, uuidGenerator uuid.UUIDGenerator, util utils.CfJavaPluginUtil, args []string) (string, error) {
 	if len(args) == 0 {
 		return "", &InvalidUsageError{message: "No command provided"}
 	}
@@ -254,18 +254,18 @@ func (c *JavaPlugin) execute(commandExecutor cmd.CommandExecutor, uuidGenerator
 			heapdumpFileName = finalFile
 			fmt.Println("Successfully created heap dump in application container at: " + heapdumpFileName)
 		} else {
-		    fmt.Println("Failed to find heap dump in application container")
-		    fmt.Println(finalFile)
-		    fmt.Println(heapdumpFileName)
-		    fmt.Println(fspath)
-		    return "", err
+			fmt.Println("Failed to find heap dump in application container")
+			fmt.Println(finalFile)
+			fmt.Println(heapdumpFileName)
+			fmt.Println(fspath)
+			return "", err
 		}
 
 		if copyToLocal {
 			localFileFullPath := localDir + "/" + applicationName + "-heapdump-" + uuidGenerator.Generate() + ".hprof"
 			err = util.CopyOverCat(applicationName, heapdumpFileName, localFileFullPath)
 			if err == nil {
-				fmt.Println("Heap dump filed saved to: " + localFileFullPath)
+				fmt.Println("Heap dump file saved to: " + localFileFullPath)
 			} else {
 				return "", err
 			}
@@ -278,7 +278,7 @@ func (c *JavaPlugin) execute(commandExecutor cmd.CommandExecutor, uuidGenerator
 			if err != nil {
 				return "", err
 			}
-			fmt.Println("Heap dump filed deleted in app container")
+			fmt.Println("Heap dump file deleted in app container")
 		}
 	}
 	// We keep this around to make the compiler happy, but commandExecutor.Execute will cause an os.Exit

cf_cli_java_plugin_suite_test.go

@@ -1,4 +1,4 @@
-package main_test
+package main
 
 import (
 	ginkgo "github.com/onsi/ginkgo"