Simpler refactoring than before due to bugs

Author: parttimenerd

.golangci.yml

@@ -28,31 +28,24 @@ linters:
 
     # Architecture and interface linters (key for your request)
     - interfacebloat   # Detect interfaces with too many methods
-    - ireturn          # Accept interfaces, return concrete types
     - unparam          # Report unused function parameters
 
     # Code quality linters
     - asciicheck       # Check for non-ASCII identifiers
     - bidichk          # Check for dangerous unicode sequences
     - bodyclose        # Check HTTP response body is closed
     - contextcheck     # Check context usage
-    - cyclop           # Check cyclomatic complexity
     - dupl             # Check for code duplication
     - durationcheck    # Check duration multiplication
     - errname          # Check error naming conventions
     - errorlint        # Check error wrapping
     - exhaustive       # Check enum switch exhaustiveness
-    - funlen           # Check function length
-    - gocognit         # Check cognitive complexity
     - goconst          # Find repeated strings that could be constants
-    - gocritic         # Comprehensive Go source code linter
-    - gocyclo          # Check cyclomatic complexity
     - godox            # Find TODO, FIXME, etc. comments
     - goprintffuncname # Check printf-style function names
     - gosec            # Security-focused linter
     - misspell         # Check for misspellings
     - nakedret         # Check naked returns
-    - nestif           # Check deeply nested if statements
     - nilerr           # Check nil error returns
     - nolintlint       # Check nolint directives
     - predeclared      # Check for shadowed predeclared identifiers
@@ -81,3 +74,11 @@ linters:
     - maintidx        # Maintainability index can be subjective
     - godot           # Check comments end with period
     - lll              # Check line length
+    - ireturn          # Interface return types are sometimes necessary
+    # ignore for now
+    - nestif
+    - gocognit
+    - gocyclo          # Check cyclomatic complexity
+    - cyclop           # Check cyclomatic complexity
+    - funlen           # Check function length
+    - gocritic

README.md

@@ -214,7 +214,11 @@ USAGE:
      jcmd (supports --args)
         Run a JCMD command on a running Java application via --args, downloads
         and deletes all files that are created in the current folder, use
-        '--no-download' to prevent this
+        '--no-download' to prevent this. Environment variables available:
+        @FSPATH (writable directory path, always set), @ARGS (command
+        arguments), @APP_NAME (application name), @FILE_NAME (generated filename
+        for file operations without UUID), and @STATIC_FILE_NAME (without UUID).
+        Use single quotes around --args to prevent shell expansion.
 
      jfr-start
         Start a Java Flight Recorder default recording on a running Java
@@ -255,7 +259,11 @@ USAGE:
         the current folder. Don't use in combination with asprof-* commands.
         Downloads and deletes all files that are created in the current folder,
         if not using 'start' asprof command, use '--no-download' to prevent
-        this.
+        this. Environment variables available: @FSPATH (writable directory path,
+        always set), @ARGS (command arguments), @APP_NAME (application name),
+        @FILE_NAME (generated filename for file operations), and
+        @STATIC_FILE_NAME (without UUID). Use single quotes around --args to
+        prevent shell expansion.
 
      asprof-start-cpu (recent SapMachine only)
         Start an async-profiler CPU-time profile recording on a running Java
@@ -280,9 +288,12 @@ USAGE:
         Get the status of async-profiler on a running Java application
 
 OPTIONS:
-   -app-instance-index       -i, [index], select to which instance of the app to connect
    -args                     -a, Miscellaneous arguments to pass to the command (if supported) in the
-                               container, be aware to end it with a space if it is a simple option
+                               container, be aware to end it with a space if it is a simple option. For
+                               commands that create arbitrary files (jcmd, asprof), the environment
+                               variables @FSPATH, @ARGS, @APP_NAME, @FILE_NAME, and @STATIC_FILE_NAME are
+                               available in --args to reference the working directory path, arguments,
+                               application name, and generated file name respectively.
    -container-dir            -cd, the directory path in the container that the heap dump/JFR/... file will be
                                 saved to
    -dry-run                  -n, just output to command line what would be executed
@@ -293,6 +304,7 @@ OPTIONS:
    -no-download              -nd, don't download the heap dump/JFR/... file to local, only keep it in the
                                 container, implies '--keep'
    -verbose                  -v, enable verbose output for the plugin
+   -app-instance-index       -i [index], select to which instance of the app to connect
 
 </pre>
 

TESTING.md

@@ -2,7 +2,8 @@
 
 ## 🎯 Overview
 
-The CF Java Plugin now includes comprehensive CI/CD integration with automated testing, linting, and quality assurance for both Go and Python codebases.
+The CF Java Plugin now includes comprehensive CI/CD integration with automated testing, linting,
+and quality assurance for both Go and Python codebases.
 
 ## 🏗️ CI/CD Pipeline
 
@@ -27,6 +28,7 @@ The CF Java Plugin now includes comprehensive CI/CD integration with automated t
 ### Smart Python Detection
 
 The CI automatically detects if the Python test suite exists by checking for:
+
 - `test/requirements.txt`
 - `test/setup.sh`
 
@@ -35,11 +37,13 @@ If found, runs Python linting validation. **Note: Python test execution is tempo
 ## 🔒 Pre-commit Hooks
 
 ### Installation
+
 ```bash
 ./setup-dev-env.sh  # One-time setup
 ```
 
 ### What It Checks
+
 - ✅ Go code formatting (`go fmt`)
 - ✅ Go static analysis (`go vet`)
 - ✅ Python linting (flake8) - if test suite exists
@@ -49,19 +53,23 @@ If found, runs Python linting validation. **Note: Python test execution is tempo
 - ✅ Markdown linting (markdownlint) - checks git-tracked files
 
 ### Hook Behavior
+
 - **Auto-fixes**: Python formatting and import sorting
 - **Blocks commits**: On critical linting issues
 - **Warnings**: For non-critical issues or missing Python suite
 
 ## 🧪 Python Test Suite Integration
 
 ### Linting Standards
+
 - **[flake8](https://flake8.pycqa.org/)**: Line length 120, ignores E203,W503
 - **[black](https://black.readthedocs.io/)**: Line length 120, compatible with flake8
 - **[isort](https://pycqa.github.io/isort/)**: Black-compatible profile for import sorting
-- **[markdownlint](https://github.com/DavidAnson/markdownlint)**: Automated markdown formatting (120 char limit, git-tracked files only)
+- **[markdownlint](https://github.com/DavidAnson/markdownlint)**: Automated markdown formatting
+  (120 char limit, git-tracked files only)
 
 ### Manual Usage
+
 ```bash
 ./scripts/lint-go.sh check         # Check Go code formatting and static analysis
 ./scripts/lint-go.sh fix           # Auto-fix Go code issues
@@ -73,6 +81,7 @@ If found, runs Python linting validation. **Note: Python test execution is tempo
 ```
 
 ### Test Execution
+
 ```bash
 cd test
 ./setup.sh               # Setup environment
@@ -82,20 +91,23 @@ cd test
 **CI Status**: Python tests are currently disabled in CI workflows but can be run locally.
 
 ### Coverage Reporting
+
 - Generated in XML format for Codecov integration
 - Covers the `framework` module
 - Includes terminal output for local development
 
 ## 🛠️ Development Workflow
 
 ### First-time Setup
+
 ```bash
 git clone <repository>
 cd cf-cli-java-plugin
 ./setup-dev-env.sh
 ```
 
 ### Daily Development
+
 ```bash
 # Make changes
 code cf-java-plugin.code-workspace
@@ -111,6 +123,7 @@ git push origin feature-branch
 ```
 
 ### Manual Testing
+
 ```bash
 # Test pre-commit hooks
 .git/hooks/pre-commit
@@ -125,15 +138,18 @@ cd test && pytest test_jfr.py -v
 ## 📊 Quality Metrics
 
 ### Go Code Quality
+
 - Formatting enforcement via `go fmt`
 - Static analysis via `go vet`
 
 ### Python Code Quality
+
 - Style compliance: flake8 (PEP 8 + custom rules)
 - Formatting: black (consistent style)
 - Import organization: isort (proper import ordering)
 
 ### Markdown Code Quality
+
 - Style compliance: markdownlint (120 char limit, git-tracked files only)
 - Automated formatting with relaxed rules for compatibility
 
@@ -168,6 +184,7 @@ For running Python tests in CI that require Cloud Foundry credentials, configure
 ### Environment Variable Usage
 
 The Python test framework automatically uses these environment variables:
+
 - Falls back to `test_config.yml` if environment variables are not set
 - Supports both file-based and environment-based configuration
 - CI workflows pass secrets as environment variables to test processes