Changes from Code Review

* rename FullVcapEnvFieldSupplier (typo)
* change test case to demonstrate numerical custom field values

Signed-off-by: Karsten Schnitter <[email protected]>

Author: KarstenSchnitter

cf-java-logging-support-core/src/main/java/com/sap/hcp/cf/logging/common/serialization/FullVcapEnvFieldFupplier.java

@@ -0,0 +1,8 @@
+package com.sap.hcp.cf.logging.common.serialization;
+
+public class FullVcapEnvFieldSupplier extends VcapEnvFieldSupplier {
+
+    public FullVcapEnvFieldSupplier() {
+        super(true);
+    }
+}

cf-java-logging-support-core/src/main/java/com/sap/hcp/cf/logging/common/serialization/FullVcapEnvFieldSupplier.java

@@ -52,12 +52,12 @@ public void customFields() throws Exception {
         Object[] arguments = new Object[] { //
                                             new Object(), //
                                             CustomField.customField("key", "value"), //
-                                            CustomField.customField("this", "that") };
+                                            CustomField.customField("number", Double.valueOf(123.456d)) };
         when(event.getArgumentArray()).thenReturn(arguments);
 
         Map<String, Object> fields = fieldSupplier.map(event);
         assertThat(fields, hasEntry("key", "value"));
-        assertThat(fields, hasEntry("this", "that"));
+        assertThat(fields, hasEntry("number", Double.valueOf(123.456d)));
     }
 
     @Test

cf-java-logging-support-logback/src/test/java/com/sap/hcp/cf/logback/encoder/EventContextFieldSupplierTest.java

@@ -5,7 +5,7 @@
 		class="ch.qos.logback.core.ConsoleAppender">
 		<encoder class="com.sap.hcp.cf.logback.encoder.JsonEncoder">
 			<sendDefaultValues>true</sendDefaultValues>
-			<contextFieldSupplier>com.sap.hcp.cf.logging.common.serialization.FullVcapEnvFieldFupplier</contextFieldSupplier>
+			<contextFieldSupplier>com.sap.hcp.cf.logging.common.serialization.FullVcapEnvFieldSupplier</contextFieldSupplier>
 			<customFieldMdcKeyName>custom-field</customFieldMdcKeyName>
 			<customFieldMdcKeyName>test-field</customFieldMdcKeyName>
 			<customFieldMdcKeyName>retained-field</customFieldMdcKeyName>