Skip to content

Commit 37c9bfa

Browse files
Create valid json in case of null-msg for logback
Change-Id: Ie7b9f7d08a5d2ce9451a585e7d1598b3b263aa1a
1 parent 1ba2925 commit 37c9bfa

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed

cf-java-logging-support-core/src/main/java/com/sap/hcp/cf/logging/common/converter/DefaultMessageConverter.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,10 @@ public void convert(String message, StringBuilder appendTo) {
4848
} else {
4949
appendTo.append(result);
5050
}
51+
} else {
52+
appendTo.append("null");
5153
}
54+
5255
}
5356

5457
private String flattenMsg(String msg) {

cf-java-logging-support-core/src/test/java/com/sap/hcp/cf/logging/common/converter/TestJsonMessageConverter.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,4 +114,11 @@ public void testObjNestedBrackets() {
114114
assertThat(formatMsg(jmc, logMsg), is(nestedBracketsMsg));
115115
}
116116

117+
@Test
118+
public void testNullMessage() {
119+
String logMsg = null;
120+
DefaultMessageConverter jmc = new DefaultMessageConverter();
121+
assertThat(formatMsg(jmc, logMsg), is("null"));
122+
}
123+
117124
}

0 commit comments

Comments
 (0)