Add support for HTTP header x-correlation-id #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The request instrumentation creates a correlation id. This used to look into the HTTP headers x-correlationid and x-vcap-request-id. This new implementation additionally looks into x-correlation-id with priority between the two other headers. Signed-off-by: Karsten Schnitter <[email protected]>
KarstenSchnitter
requested review from
juergen-walter,
christiand93 and
nicklas-dohrn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The request instrumentation creates a correlation id. This used to look into the HTTP headers
x-CorrelationIDandx-vcap-request-id. This new implementation additionally looks intox-correlation-idwith priority between the two other headers.The downside of this change is, that it might not be aligned with the Gorouter logs. The Gorouter might log either HTTP header
x-CorrelationIDand/orx-correlation-id. But it will always create anx-vcap-request-idwhich is seen by the application. This might create deviations in log parsing for correlation ids, when the newly supported header is used.