Update implementation

Author: a-d

datamodel/openapi/openapi-generator/src/main/java/com/sap/cloud/sdk/datamodel/openapi/generator/GenerationConfigurationConverter.java

@@ -111,13 +111,13 @@ private static void setGlobalSettings( @Nonnull final GenerationConfiguration co
         GlobalSettings.setProperty(CodegenConstants.HIDE_GENERATION_TIMESTAMP, Boolean.TRUE.toString());
     }
 
-    private static String getAllowedIds( @Nonnull final GenerationConfiguration config, @Nonnull final String property )
+    static String getAllowedIds( @Nonnull final GenerationConfiguration config, @Nonnull final String property )
     {
         final var allowIds = config.getAdditionalProperties().get(property);
         if( allowIds == null || allowIds.isBlank() ) {
             return "";
         }
-        return String.join(",", allowIds.trim().split("\\s+"));
+        return String.join(",", allowIds.trim().split("\\W+"));
     }
 
     private static OpenAPI parseOpenApiSpec( @Nonnull final String inputSpecFile )

datamodel/openapi/openapi-generator/src/test/java/com/sap/cloud/sdk/datamodel/openapi/generator/GenerationConfigurationConverterTest.java

@@ -10,6 +10,7 @@
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.io.TempDir;
 
+import com.google.common.collect.ImmutableMap;
 import com.sap.cloud.sdk.datamodel.openapi.generator.model.GenerationConfiguration;
 
 class GenerationConfigurationConverterTest
@@ -35,6 +36,37 @@ void testCopyrightHeaderResolution()
         assertThat(resultNoHeader).isNull();
     }
 
+    @Test
+    void testGetAllowedIds()
+    {
+        // assertion definition: given input -> expected output
+        final var assertions =
+            ImmutableMap
+                .<String, String> builder()
+                .put("", "") // empty
+                .put("\n", "") // newline
+                .put("Foo", "Foo") // single
+                .put("Foo,Bar", "Foo,Bar") // list
+                .put("Foo;Bar", "Foo,Bar") // custom separator
+                .put("Foo  Bar", "Foo,Bar") // space separator
+                .put("Foo \n Bar", "Foo,Bar") // new-line separator
+                .build();
+
+        // feed the assertion input arguments into the config
+        var configBuilder = GenerationConfiguration.builder();
+        int i = 0;
+        for( String input : assertions.keySet() ) {
+            configBuilder.additionalProperty("property" + (i++), input);
+        }
+        var config = configBuilder.build();
+
+        // run the test
+        int j = 0;
+        for( String output : assertions.values() ) {
+            assertThat(GenerationConfigurationConverter.getAllowedIds(config, "property" + (j++))).isEqualTo(output);
+        }
+    }
+
     private GenerationConfiguration.GenerationConfigurationBuilder createBasicConfig()
     {
         return GenerationConfiguration