-
Notifications
You must be signed in to change notification settings - Fork 23
chore: Migrate release process to maven central #866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
newtork
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't checked whether all plugin configurations are migrated correctly. It's a lot.
* Update to version 0.47.0 * Reset release notes * Update to version 0.48.0-SNAPSHOT
This reverts commit cc4a5f7.
| <artifactId>maven-checkstyle-plugin</artifactId> | ||
| <version>3.6.0</version> | ||
| <configuration> | ||
| <skip>true</skip> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Question) Do you need to skip this plugin if it isn't really defined for the module?
| </plugin> | ||
| <plugin> | ||
| <groupId>org.projectlombok</groupId> | ||
| <artifactId>lombok-maven-plugin</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Question) Can we omit plugin declarations targetting source-code, when the BOM wouldn't have any?
newtork
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really wished the plugin properties diff was smaller.
Context
This PR migrates the release process of Cloud SDK to the new maven central endpoint. It also makes the release process more consistent with the release process of AI SDK.
You can find the successful test runs in the forked repository:
Feature scope:
https://central.sonatype.com/api/v1/publisher/uploadnowDefinition of Done
Error handling created / updated & covered by the tests aboveDocumentation updatedRelease notes updated