chore: remove generics

Author: KavithaSiva

packages/odata-common/src/selectable/edm-type-field.ts

@@ -49,8 +49,7 @@ export class EdmTypeField<
     DeSerializersT extends DeSerializers,
     EdmT extends EdmTypeShared<'any'>,
     NullableT extends boolean = false,
-    SelectableT extends boolean = false,
-    PrecisionT extends number = 0
+    SelectableT extends boolean = false
   >
   extends Field<EntityT, NullableT, SelectableT>
   implements EntityIdentifiable<EntityT, DeSerializersT>
@@ -64,14 +63,15 @@ export class EdmTypeField<
    * @param edmType - Type of the field according to the metadata description.
    * @param _deSerializers - (De-)serializers used for transformation.
    * @param fieldOptions - Optional settings for this field.
+   * @param precision - Optional precision provided for this field.
    */
   constructor(
     fieldName: string,
     readonly _fieldOf: ConstructorOrField<EntityT>,
     readonly edmType: EdmT,
     public _deSerializers: DeSerializersT, // Only necessary for the type, unused otherwise
     fieldOptions?: FieldOptions<NullableT, SelectableT>,
-    precision?: PrecisionT
+    precision?: number
   ) {
     super(fieldName, getEntityConstructor(_fieldOf), fieldOptions, precision);
   }

packages/odata-common/src/selectable/field-builder.ts

@@ -110,6 +110,7 @@ export class FieldBuilder<
    * @param fieldName - Name of the field.
    * @param edmType - EDM type of the field.
    * @param isNullable - Whether the field is nullable.
+   * @param precision - Precision provided for the field.
    * @returns An EDM type field.
    */
   buildEdmTypeField<
@@ -143,10 +144,17 @@ export class FieldBuilder<
       isOrderableEdmType(edmType) ? OrderableEdmTypeField : EdmTypeField
     ) as typeof EdmTypeField;
 
-    return new ctor(fieldName, this.fieldOf, edmType, this.deSerializers, {
-      isNullable,
-      isSelectable
-    }, precision);
+    return new ctor(
+      fieldName,
+      this.fieldOf,
+      edmType,
+      this.deSerializers,
+      {
+        isNullable,
+        isSelectable
+      },
+      precision
+    );
   }
 
   /**

packages/odata-common/src/selectable/field.ts

@@ -64,6 +64,7 @@ export class Field<
    * @param _fieldName - Actual name of the field used in the OData request.
    * @param _entityConstructor - Constructor type of the entity the field belongs to.
    * @param fieldOptions - Optional settings for this field.
+   * @param precision - Optional precision provided for this field.
    */
   constructor(
     readonly _fieldName: string,

packages/odata-common/src/selectable/orderable-edm-type-field.ts

@@ -17,9 +17,8 @@ export class OrderableEdmTypeField<
   DeSerializersT extends DeSerializers,
   EdmT extends EdmTypeShared<'any'>,
   NullableT extends boolean = false,
-  SelectableT extends boolean = false,
-  PrecisionT extends number = 0,
-> extends EdmTypeField<EntityT, DeSerializersT, EdmT, NullableT, SelectableT, PrecisionT> {
+  SelectableT extends boolean = false
+> extends EdmTypeField<EntityT, DeSerializersT, EdmT, NullableT, SelectableT> {
   /**
    * Creates an instance of Filter for this field and the given value using the operator 'gt', i.e. `>`.
    * @param value - Value to be used in the filter.

packages/odata-v4/src/de-serializers/converters.ts

@@ -42,7 +42,11 @@ export function deserializeDateTimeOffsetToMoment(
 /**
  * @internal
  */
-export function serializeToDateTimeOffset(value: moment.Moment, precision: number): string {
+export function serializeToDateTimeOffset(
+  value: moment.Moment,
+  precision?: number
+): string {
+  console.log('Precision being logged in the serialiser', precision);
   return value.utc().format('YYYY-MM-DDTHH:mm:ss.SSS') + 'Z';
 }
 

packages/odata-v4/src/request-builder/update-request-builder.spec.ts

@@ -20,6 +20,7 @@ function createTestEntity() {
     .keyPropertyString(keyPropString)
     .keyDateProperty(keyPropDate)
     .int32Property(int32Prop)
+    .dateTimeOffSetProperty(keyPropDate)
     .build();
 }
 

test-packages/test-services-odata-v4/test-service/TestEntityApi.ts

@@ -239,8 +239,7 @@ export class TestEntityApi<
       DeSerializersT,
       'Edm.DateTimeOffset',
       true,
-      true,
-      2
+      true
     >;
     DURATION_PROPERTY: OrderableEdmTypeField<
       TestEntity<DeSerializers>,