Skip to content

Commit e09754a

Browse files
authored
fix: added generateESM flag to packageJson options (#6172)
* bugfix: added generateESM flag to packageJson options corresponding test * Added missing changeset file * Fixed PR pipeline * Changeset: added change type * Modifies changeset file and added a failing test
1 parent 24303ef commit e09754a

File tree

3 files changed

+30
-1
lines changed

3 files changed

+30
-1
lines changed

.changeset/cool-tigers-make.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@sap-cloud-sdk/openapi': minor
3+
---
4+
5+
[Fixed Issue] Fix missing `type: module` in generated `package.json` when `--generateESM` option is enabled.

packages/openapi-generator/src/file-serializer/package-json.spec.ts

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,4 +21,27 @@ describe('packageJson', () => {
2121
);
2222
expect(parsed.license).toBe('UNLICENSED');
2323
});
24+
25+
it('includes type module when generateESM is true', () => {
26+
const parsed = JSON.parse(
27+
packageJson({
28+
npmPackageName: 'workflow-service',
29+
description: 'description',
30+
sdkVersion: '1.35.0',
31+
generateESM: true
32+
})
33+
);
34+
expect(parsed.type).toBe('module');
35+
});
36+
37+
it('includes type module when generateESM is undefined', () => {
38+
const parsed = JSON.parse(
39+
packageJson({
40+
npmPackageName: 'workflow-service',
41+
description: 'description',
42+
sdkVersion: '1.35.0'
43+
})
44+
);
45+
expect(parsed.type).toBeUndefined();
46+
});
2447
});

packages/openapi-generator/src/generator.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -344,7 +344,8 @@ async function generatePackageJson(
344344
packageJson({
345345
npmPackageName: openApiDocument.serviceOptions.packageName,
346346
description: packageDescription(openApiDocument.serviceName),
347-
sdkVersion: await getSdkVersion()
347+
sdkVersion: await getSdkVersion(),
348+
generateESM: options.generateESM
348349
}),
349350
createFileOptions
350351
);

0 commit comments

Comments
 (0)