fix: Handle arrays of enum strings correctly (#6156)

* Handle arrays of enum strings correctly

Without this change an array of enums will result in e.g.:

export type Model1 = {
  values: 'A' | 'B' | 'C'[];
} & Record<string, any>;

which means the value can be either "A", "B", or "C"[], which is wrong.

* chore: add tests covering array-of-enums types

* chore: add changeset

* chore: fmt

* chore: move stringArrayEnum into TestEntity & rm singleValueArrayEnum

* chore: remove outdated files

---------

Co-authored-by: David Knaack <[email protected]>
Co-authored-by: Deeksha Sinha <[email protected]>

Author: 3 people

.changeset/fair-ends-drop.md

@@ -0,0 +1,5 @@
+---
+'@sap-cloud-sdk/openapi-generator': patch
+---
+
+[Fixed Issue] Improve the handling of arrays of enums

packages/openapi-generator/src/file-serializer/schema.spec.ts

@@ -303,6 +303,18 @@ describe('serializeSchema for xOf schemas', () => {
   });
 });
 
+it('serializes array schemas for enum', () => {
+  expect(
+    serializeSchema({
+      type: 'array',
+      items: {
+        type: 'string',
+        enum: ["'One'", "'Two'"]
+      }
+    })
+  ).toEqual("('One' | 'Two')[]");
+});
+
 it('serializeSchema serializes not schema', () => {
   expect(
     serializeSchema({

packages/openapi-generator/src/file-serializer/schema.ts

@@ -34,7 +34,7 @@ export function serializeSchema(schema: OpenApiSchema): string {
     const type = serializeSchema(schema.items);
     return schema.uniqueItems
       ? `Set<${type}>`
-      : ['properties', 'allOf', 'oneOf', 'anyOf'].some(
+      : ['properties', 'allOf', 'oneOf', 'anyOf', 'enum'].some(
             prop => prop in schema.items
           )
         ? `(${type})[]`