Skip to content

Commit 8aaf7c3

Browse files
authored
Adapt to optimized IAS server API (#1359)
1 parent 3e9cd03 commit 8aaf7c3

File tree

43 files changed

+220
-162
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

43 files changed

+220
-162
lines changed

CHANGELOG.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,18 @@
11
# Change Log
22
All notable changes to this project will be documented in this file.
33

4+
## 3.3.0
5+
**Breaking Change [java-security-test]**: To validate mocked XSUAA tokens issued by java-security-test module, the UAA_DOMAIN property of the service configuration must now include the port of the Wiremock server.\
6+
Likewise for validating IAS tokens, the trusted *domains* array of the service configuration also needs to include the Wiremock URL including the port.\
7+
The full wiremock URL is available via SecurityTestContext#getWireMockServer#baseUrl.
8+
9+
*Note*: If you are building your configuration via SecurityTestContext#getOAuth2ServiceConfigurationBuilderFromFile, this will already be preconfigured correctly, but you must not overwrite these properties with only "localhost".
10+
11+
- [java-security]
12+
- [XSUAA/IAS] Adapt optimized server API
13+
- [spring-xsuaa]
14+
- Adapt optimized server API
15+
416
## 3.2.1
517
Hot fix for the CVE-2023-5072
618

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ The SAP Cloud Security Services Integration is published to maven central: https
124124
<dependency>
125125
<groupId>com.sap.cloud.security</groupId>
126126
<artifactId>java-bom</artifactId>
127-
<version>3.2.1</version>
127+
<version>3.3.0</version>
128128
<scope>import</scope>
129129
<type>pom</type>
130130
</dependency>

bom/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
<groupId>com.sap.cloud.security</groupId>
1010
<artifactId>java-bom</artifactId>
11-
<version>3.2.1</version>
11+
<version>3.3.0</version>
1212
<packaging>pom</packaging>
1313
<name>java-bom</name>
1414

env/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<parent>
1010
<groupId>com.sap.cloud.security.xsuaa</groupId>
1111
<artifactId>parent</artifactId>
12-
<version>3.2.1</version>
12+
<version>3.3.0</version>
1313
</parent>
1414

1515
<groupId>com.sap.cloud.security</groupId>

java-api/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@
55
<dependency>
66
<groupId>com.sap.cloud.security</groupId>
77
<artifactId>java-api</artifactId>
8-
<version>3.2.1</version>
8+
<version>3.3.0</version>
99
</dependency>
1010
```

java-api/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<parent>
1010
<groupId>com.sap.cloud.security.xsuaa</groupId>
1111
<artifactId>parent</artifactId>
12-
<version>3.2.1</version>
12+
<version>3.3.0</version>
1313
</parent>
1414

1515
<groupId>com.sap.cloud.security</groupId>

java-security-it/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<parent>
1010
<artifactId>parent</artifactId>
1111
<groupId>com.sap.cloud.security.xsuaa</groupId>
12-
<version>3.2.1</version>
12+
<version>3.3.0</version>
1313
</parent>
1414

1515
<artifactId>java-security-it</artifactId>

java-security-it/src/test/java/com/sap/cloud/security/test/integration/XsuaaIntegrationTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ public void xsuaaTokenValidationFails_withIasCombiningValidator() {
8383
ValidationResult result = tokenValidator.validate(token);
8484
assertThat(result.isValid()).isFalse();
8585
assertThat(result.getErrorDescription()).startsWith(
86-
"Issuer is not trusted because issuer 'http://auth.com' doesn't match any of these domains '[myauth.com]' of the identity provider");
86+
"Issuer http://auth.com was not a trusted domain or a subdomain of the trusted domains [myauth.com].");
8787
}
8888

8989
@Test

java-security-it/src/test/java/com/sap/cloud/security/test/integration/ssrf/JavaSSRFAttackTest.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77

88
import com.sap.cloud.security.config.OAuth2ServiceConfigurationBuilder;
99
import com.sap.cloud.security.config.Service;
10-
import com.sap.cloud.security.config.ServiceConstants;
1110
import com.sap.cloud.security.test.RSAKeys;
1211
import com.sap.cloud.security.test.extension.SecurityTestExtension;
1312
import com.sap.cloud.security.token.Token;
@@ -65,9 +64,8 @@ class JavaSSRFAttackTest {
6564
void maliciousPartOfJwksIsNotUsedToObtainToken(String jwksUrl, boolean isValid)
6665
throws IOException, NoSuchAlgorithmException, InvalidKeySpecException {
6766
OAuth2ServiceConfigurationBuilder configuration =
68-
extension.getContext()
69-
.getOAuth2ServiceConfigurationBuilderFromFile("/xsuaa/vcap_services-single.json")
70-
.withProperty(ServiceConstants.XSUAA.UAA_DOMAIN, extension.getContext().getWireMockServer().baseUrl());
67+
extension.getContext().getOAuth2ServiceConfigurationBuilderFromFile("/xsuaa/vcap_services-single.json");
68+
7169
Token token;
7270
if (isValid) {
7371
token = extension.getContext().getJwtGeneratorFromFile("/xsuaa/token.json")

java-security-it/src/test/java/com/sap/cloud/security/test/performance/SpringSecurityPerformanceIT.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ private OAuth2ServiceConfigurationBuilder createXsuaaConfigurationBuilder() {
8080

8181
private OAuth2ServiceConfigurationBuilder createIasConfigurationBuilder() {
8282
return OAuth2ServiceConfigurationBuilder.forService(IAS)
83-
.withDomains(SecurityTest.DEFAULT_DOMAIN)
83+
.withDomains(securityIasTest.getWireMockServer().baseUrl())
8484
.withClientId(SecurityTest.DEFAULT_CLIENT_ID);
8585
}
8686
}

0 commit comments

Comments
 (0)