Skip to content

Commit bc22564

Browse files
authored
1.11.1 (#311)
* 1.11.1 * Update y_check_db_access_in_ut.clas.abap * Update y_check_db_access_in_ut.clas.testclasses.abap * Update changelog.txt
1 parent 1e81692 commit bc22564

File tree

4 files changed

+49
-1
lines changed

4 files changed

+49
-1
lines changed

changelog.txt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,10 @@ Upgrade Note
1212
------------------
1313
Whenever you upgrade code pal for ABAP, it is highly recommended to execute the Y_CI_CHECK_REGISTRATION report to activate/reactivate the Checks (SE38 transaction) and regenerate the respective code inspector variant (SCI transaction)
1414

15+
2021-01-18 v1.11.1
16+
------------------
17+
* Dump in DB access in UT (#309)
18+
1519
2021-01-18 v1.11.0
1620
------------------
1721
* CHECK position after comments (#301)

src/checks/y_check_db_access_in_ut.clas.abap

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,9 @@ CLASS y_check_db_access_in_ut DEFINITION PUBLIC INHERITING FROM y_check_base CRE
2929
METHODS is_internal_table IMPORTING statement TYPE sstmnt
3030
RETURNING VALUE(result) TYPE abap_bool.
3131

32+
METHODS is_an_attribution IMPORTING statement TYPE sstmnt
33+
RETURNING VALUE(result) TYPE abap_bool.
34+
3235
ENDCLASS.
3336

3437

@@ -74,6 +77,10 @@ CLASS y_check_db_access_in_ut IMPLEMENTATION.
7477
CONTINUE.
7578
ENDIF.
7679

80+
IF is_an_attribution( statement ) = abap_true.
81+
CONTINUE.
82+
ENDIF.
83+
7784
IF has_ddic_itab_same_syntax( <token_not_allowed> ) = abap_true
7885
AND is_internal_table( statement ) = abap_true.
7986
CONTINUE.
@@ -168,4 +175,12 @@ CLASS y_check_db_access_in_ut IMPLEMENTATION.
168175

169176
result = xsdbool( is_persistent_object( table ) = abap_false ).
170177
ENDMETHOD.
178+
179+
180+
METHOD is_an_attribution.
181+
DATA(second_token) = get_token_abs( statement-from + 1 ).
182+
result = xsdbool( second_token = '=' ).
183+
ENDMETHOD.
184+
185+
171186
ENDCLASS.

src/checks/y_check_db_access_in_ut.clas.testclasses.abap

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -438,3 +438,32 @@ CLASS ltc_exec_sql IMPLEMENTATION.
438438
ENDMETHOD.
439439

440440
ENDCLASS.
441+
442+
443+
444+
CLASS ltc_attribution DEFINITION INHERITING FROM ltc_risk_harmless FOR TESTING RISK LEVEL HARMLESS DURATION SHORT.
445+
PROTECTED SECTION.
446+
METHODS get_code_without_issue REDEFINITION.
447+
ENDCLASS.
448+
449+
CLASS ltc_attribution IMPLEMENTATION.
450+
451+
METHOD get_code_without_issue.
452+
result = VALUE #(
453+
( ' REPORT unit_test. ' )
454+
455+
( ' CLASS example DEFINITION FOR TESTING RISK LEVEL HARMLESS DURATION SHORT. ' )
456+
( ' PUBLIC SECTION. ' )
457+
( ' METHODS example FOR TESTING. ' )
458+
( ' ENDCLASS.' )
459+
460+
( ' CLASS example IMPLEMENTATION. ' )
461+
( ' METHOD example. ' )
462+
( ' DATA update TYPE abap_bool. ' )
463+
( ' update = space. ' )
464+
( ' ENDMETHOD. ' )
465+
( ' ENDCLASS. ' )
466+
).
467+
ENDMETHOD.
468+
469+
ENDCLASS.

src/y_code_pal_version.intf.abap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
INTERFACE y_code_pal_version PUBLIC.
2-
CONSTANTS abap TYPE string VALUE '1.11.0' ##NO_TEXT.
2+
CONSTANTS abap TYPE string VALUE '1.11.1' ##NO_TEXT.
33
ENDINTERFACE.

0 commit comments

Comments
 (0)