fixes

Author: lucasborin

src/checks/y_check_comment_usage.clas.abap

@@ -33,9 +33,11 @@ CLASS y_check_comment_usage IMPLEMENTATION.
     settings-threshold = 10.
     settings-documentation = |{ c_docs_path-checks }comment-usage.md|.
 
-    relevant_statement_types = VALUE #( BASE relevant_statement_types
-                                      ( scan_struc_stmnt_type-class_definition )
-                                      ( scan_struc_stmnt_type-interface ) ).
+    relevant_statement_types = VALUE #( ( scan_struc_stmnt_type-class_pool )
+                                        ( scan_struc_stmnt_type-report )
+                                        ( scan_struc_stmnt_type-program )
+                                        ( scan_struc_stmnt_type-function_pool )
+                                        ( scan_struc_stmnt_type-interface_pool ) ).
 
     set_check_message( 'Percentage of comments must be lower than &3% of the productive code! (&2%>=&3%) (&1 lines found)' ).
   ENDMETHOD.

src/checks/y_check_pseudo_comment_usage.clas.abap

@@ -54,8 +54,9 @@ CLASS y_check_pseudo_comment_usage IMPLEMENTATION.
     settings-apply_on_productive_code = abap_true.
     settings-prio = c_note.
 
-    relevant_statement_types = VALUE #( ).
-    relevant_structure_types = VALUE #( ).
+    relevant_statement_types = VALUE #( BASE relevant_statement_types
+                                      ( scan_struc_stmnt_type-class_definition )
+                                      ( scan_struc_stmnt_type-interface ) ).
 
     set_check_message( '&1 pseudo comments!' ).
 

src/foundation/y_check_base.clas.abap

@@ -54,7 +54,12 @@ CLASS y_check_base DEFINITION PUBLIC ABSTRACT
     DATA use_default_attributes TYPE abap_bool VALUE abap_true ##NO_TEXT.
     DATA attributes_maintained TYPE abap_bool.
 
+    "! <p class="shorttext synchronized" lang="en">Relevant Statement Types for Inspection</p>
+    "! There are default values set in the Y_CHECK_BASE, and you can reuse the constants available in the 'scan_struc_stmnt_type' structure to enhance or change it.
     DATA relevant_statement_types TYPE TABLE OF sstruc-stmnt_type.
+
+    "! <p class="shorttext synchronized" lang="en">Relevant Structure Types for Inspection</p>
+    "! There are default values set in the Y_CHECK_BASE, and you can reuse the constants available in the 'scan_struc_type' structure to enhance or change it.
     DATA relevant_structure_types TYPE TABLE OF sstruc-type.
 
     METHODS execute_check.
@@ -73,7 +78,7 @@ CLASS y_check_base DEFINITION PUBLIC ABSTRACT
     METHODS get_code IMPORTING message_prio  TYPE sychar01
                      RETURNING VALUE(result) TYPE sci_errc.
 
-    "! <p class="shorttext synchronized" lang="en">Inspect All Structures</p>
+    "! <p class="shorttext synchronized" lang="en">Inspect Structures</p>
     METHODS inspect_structures.
 
     "! <p class="shorttext synchronized" lang="en">Inspect Statements of a Structure</p>
@@ -152,8 +157,6 @@ CLASS y_check_base DEFINITION PUBLIC ABSTRACT
     METHODS get_application_component IMPORTING level         TYPE slevel
                                       RETURNING VALUE(result) TYPE df14l-ps_posid.
 
-    METHODS are_relevant_types_set RETURNING VALUE(result) TYPE abap_bool.
-
 ENDCLASS.
 
 
@@ -771,8 +774,6 @@ CLASS y_check_base IMPLEMENTATION.
 
 
   METHOD should_skip_type.
-    CHECK are_relevant_types_set( ) = abap_true.
-
     result = xsdbool(     is_statement_type_relevant( structure ) = abap_false
                       AND is_structure_type_relevant( structure ) = abap_false ).
   ENDMETHOD.
@@ -816,10 +817,4 @@ CLASS y_check_base IMPLEMENTATION.
   ENDMETHOD.
 
 
-  METHOD are_relevant_types_set.
-    result = xsdbool(    relevant_statement_types IS NOT INITIAL
-                      OR relevant_structure_types IS NOT INITIAL ).
-  ENDMETHOD.
-
-
 ENDCLASS.

src/foundation/y_check_base.clas.xml

@@ -79,14 +79,26 @@
      <CLSNAME>Y_CHECK_BASE</CLSNAME>
      <CMPNAME>INSPECT_STRUCTURES</CMPNAME>
      <LANGU>E</LANGU>
-     <DESCRIPT>Inspect All Structures</DESCRIPT>
+     <DESCRIPT>Inspect Structures</DESCRIPT>
     </SEOCOMPOTX>
     <SEOCOMPOTX>
      <CLSNAME>Y_CHECK_BASE</CLSNAME>
      <CMPNAME>INSPECT_TOKENS</CMPNAME>
      <LANGU>E</LANGU>
      <DESCRIPT>Inspect Tokens of a Statement</DESCRIPT>
     </SEOCOMPOTX>
+    <SEOCOMPOTX>
+     <CLSNAME>Y_CHECK_BASE</CLSNAME>
+     <CMPNAME>RELEVANT_STATEMENT_TYPES</CMPNAME>
+     <LANGU>E</LANGU>
+     <DESCRIPT>Relevant Statement Types for Inspection</DESCRIPT>
+    </SEOCOMPOTX>
+    <SEOCOMPOTX>
+     <CLSNAME>Y_CHECK_BASE</CLSNAME>
+     <CMPNAME>RELEVANT_STRUCTURE_TYPES</CMPNAME>
+     <LANGU>E</LANGU>
+     <DESCRIPT>Relevant Structure Types for Inspection</DESCRIPT>
+    </SEOCOMPOTX>
     <SEOCOMPOTX>
      <CLSNAME>Y_CHECK_BASE</CLSNAME>
      <CMPNAME>SETTINGS</CMPNAME>

src/foundation/y_ci_check_registration.prog.abap

@@ -24,9 +24,9 @@ CONSTANTS: BEGIN OF reference,
              error                TYPE c LENGTH 1 VALUE 'E',
            END OF reference.
 
-CLASS lcl_check_registration DEFINITION. "#EC NUM_PUBLIC_ATTR
+CLASS lcl_check_registration DEFINITION.
   PUBLIC SECTION.
-    CLASS-DATA name_tab TYPE STANDARD TABLE OF scitests-name.
+    CLASS-DATA name_tab TYPE STANDARD TABLE OF scitests-name READ-ONLY.
 
     CLASS-METHODS select_object_list
       RETURNING VALUE(result) LIKE name_tab