Skip to content

Commit deaf7ce

Browse files
authored
1.13.1 (#349)
* 1.13.1 * closes #333 (#351) * Y_CHECK_DB_ACCESS_IN_UT on INSERT INTO internal table (#350) * solves #348 * Update changelog.txt
1 parent 524ccae commit deaf7ce

5 files changed

+44
-6
lines changed

changelog.txt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,10 @@ Upgrade Note
1212
------------------
1313
Whenever you upgrade code pal for ABAP, it is highly recommended to execute the Y_CI_CHECK_REGISTRATION report to activate/reactivate the Checks (SE38 transaction) and regenerate the respective code inspector variant (SCI transaction)
1414

15+
2021-04-05 v.1.13.1
16+
------------------
17+
* Y_CHECK_DB_ACCESS_IN_UT on INSERT INTO internal table (#348)
18+
1519
2021-03-24 v.1.13.0
1620
------------------
1721
* y_ref_scan_manager_double

src/checks/y_check_db_access_in_ut.clas.abap

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,13 +130,15 @@ CLASS Y_CHECK_DB_ACCESS_IN_UT IMPLEMENTATION.
130130
METHOD is_internal_table.
131131
DATA(second_token) = get_token_abs( statement-from + 1 ).
132132
DATA(third_token) = get_token_abs( statement-from + 2 ).
133+
DATA(fourth_token) = get_token_abs( statement-from + 2 ).
133134

134135
IF second_token = keys-into.
135136
RETURN.
136137
ENDIF.
137138

138139
DATA(table_name) = COND #( WHEN second_token = keys-from THEN third_token
139-
ELSE second_token ).
140+
WHEN third_token = keys-into THEN fourth_token
141+
ELSE second_token ).
140142

141143
result = xsdbool( is_persistent_object( table_name ) = abap_false ).
142144
ENDMETHOD.
@@ -272,4 +274,6 @@ CLASS Y_CHECK_DB_ACCESS_IN_UT IMPLEMENTATION.
272274
OR token-str = check_for-delete
273275
OR token-str = check_for-insert ).
274276
ENDMETHOD.
277+
278+
275279
ENDCLASS.

src/checks/y_check_db_access_in_ut.clas.testclasses.abap

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -440,12 +440,12 @@ CLASS ltc_exec_sql IMPLEMENTATION.
440440
ENDCLASS.
441441

442442

443-
CLASS ltc_attribution DEFINITION INHERITING FROM ltc_risk_harmless FOR TESTING RISK LEVEL HARMLESS DURATION SHORT.
443+
CLASS ltc_itab DEFINITION INHERITING FROM ltc_risk_harmless FOR TESTING RISK LEVEL HARMLESS DURATION SHORT.
444444
PROTECTED SECTION.
445445
METHODS get_code_without_issue REDEFINITION.
446446
ENDCLASS.
447447

448-
CLASS ltc_attribution IMPLEMENTATION.
448+
CLASS ltc_itab IMPLEMENTATION.
449449

450450
METHOD get_code_without_issue.
451451
result = VALUE #(
@@ -458,8 +458,9 @@ CLASS ltc_attribution IMPLEMENTATION.
458458

459459
( ' CLASS example IMPLEMENTATION. ' )
460460
( ' METHOD example. ' )
461-
( ' DATA update TYPE abap_bool. ' )
462-
( ' update = space. ' )
461+
( ' DATA mt_messages TYPE symsg_tab. ' )
462+
( ' DATA message TYPE symsg. ' )
463+
( ' INSERT message INTO TABLE mt_messages. ' )
463464
( ' ENDMETHOD. ' )
464465
( ' ENDCLASS. ' )
465466
).

src/checks/y_check_self_reference.clas.testclasses.abap

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,3 +73,32 @@ CLASS ltc_method IMPLEMENTATION.
7373
ENDMETHOD.
7474

7575
ENDCLASS.
76+
77+
78+
CLASS ltc_attribute DEFINITION INHERITING FROM ltc_method FOR TESTING RISK LEVEL HARMLESS DURATION SHORT.
79+
PROTECTED SECTION.
80+
METHODS get_code_without_issue REDEFINITION.
81+
ENDCLASS.
82+
83+
CLASS ltc_attribute IMPLEMENTATION.
84+
85+
METHOD get_code_without_issue.
86+
result = VALUE #(
87+
( 'REPORT y_example. ' )
88+
89+
( ' CLASS y_example DEFINITION. ' )
90+
( ' PUBLIC SECTION. ' )
91+
( ' METHODS constructor IMPORTING name TYPE string. ' )
92+
( ' PRIVATE SECTION. ' )
93+
( ' DATA name TYPE string. ' )
94+
( ' ENDCLASS. ' )
95+
96+
( ' CLASS y_example IMPLEMENTATION. ' )
97+
( ' METHOD constructor. ' )
98+
( ' me->name = name. ' )
99+
( ' ENDMETHOD. ' )
100+
( ' ENDCLASS. ' )
101+
).
102+
ENDMETHOD.
103+
104+
ENDCLASS.

src/y_code_pal_version.intf.abap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
INTERFACE y_code_pal_version PUBLIC.
2-
CONSTANTS abap TYPE string VALUE '1.13.0' ##NO_TEXT.
2+
CONSTANTS abap TYPE string VALUE '1.13.1' ##NO_TEXT.
33
ENDINTERFACE.

0 commit comments

Comments
 (0)