saving progress

solves #295
probably solves #296
changes pseudo comment position (must adjust documentation as well)
new attributs to handle relevant statement/structure types

Author: lucasborin

src/checks/y_check_boolean_input_param.clas.abap

@@ -1,19 +1,22 @@
 CLASS y_check_boolean_input_param DEFINITION PUBLIC INHERITING FROM y_check_base CREATE PUBLIC .
   PUBLIC SECTION.
     METHODS constructor.
+
   PROTECTED SECTION.
-    METHODS execute_check REDEFINITION.
     METHODS inspect_tokens REDEFINITION.
+
   PRIVATE SECTION.
     METHODS is_setter_method IMPORTING statement TYPE sstmnt
                              RETURNING VALUE(result) TYPE abap_bool.
+
     METHODS has_boolean_input_param IMPORTING statement TYPE sstmnt
                                     RETURNING VALUE(result) TYPE abap_bool.
 ENDCLASS.
 
 
 CLASS y_check_boolean_input_param IMPLEMENTATION.
 
+
   METHOD constructor.
     super->constructor( ).
 
@@ -22,35 +25,12 @@ CLASS y_check_boolean_input_param IMPLEMENTATION.
     settings-threshold = 0.
     settings-documentation = |{ c_docs_path-checks }boolean-input-parameter.md|.
 
+    relevant_statement_types = VALUE #( ( scan_struc_stmnt_type-class_definition ) ).
+    relevant_structure_types = VALUE #( ).
+
     set_check_message( 'Split method instead of Boolean input parameter!' ).
   ENDMETHOD.
 
-  METHOD execute_check.
-    LOOP AT ref_scan_manager->get_structures( ) ASSIGNING FIELD-SYMBOL(<structure>)
-       WHERE stmnt_type = scan_struc_stmnt_type-class_definition.
-
-      is_testcode = test_code_detector->is_testcode( <structure> ).
-
-      TRY.
-          DATA(check_configuration) = check_configurations[ apply_on_testcode = abap_true ].
-        CATCH cx_sy_itab_line_not_found.
-          IF is_testcode EQ abap_true.
-            CONTINUE.
-          ENDIF.
-      ENDTRY.
-
-      DATA(index) = <structure>-stmnt_from.
-
-      LOOP AT ref_scan_manager->get_statements( ) ASSIGNING FIELD-SYMBOL(<statement>)
-        FROM <structure>-stmnt_from TO <structure>-stmnt_to.
-
-        inspect_tokens( index = index
-                        structure = <structure>
-                        statement = <statement> ).
-        index = index + 1.
-      ENDLOOP.
-    ENDLOOP.
-  ENDMETHOD.
 
   METHOD inspect_tokens.
 
@@ -71,14 +51,16 @@ CLASS y_check_boolean_input_param IMPLEMENTATION.
 
   ENDMETHOD.
 
+
   METHOD is_setter_method.
     DATA(method_name) = get_token_abs( statement-from + 1 ).
     result = COND #( WHEN method_name CS 'SET_' THEN abap_true ).
   ENDMETHOD.
 
+
   METHOD has_boolean_input_param.
     DATA(skip) = abap_true.
-    LOOP AT ref_scan_manager->get_tokens( ) ASSIGNING FIELD-SYMBOL(<token>)
+    LOOP AT ref_scan_manager->tokens ASSIGNING FIELD-SYMBOL(<token>)
     FROM statement-from TO statement-to.
 
       IF <token>-str = 'IMPORTING'.
@@ -101,4 +83,5 @@ CLASS y_check_boolean_input_param IMPLEMENTATION.
     ENDLOOP.
   ENDMETHOD.
 
+
 ENDCLASS.

src/checks/y_check_branch_coverage.clas.abap

@@ -1,9 +1,11 @@
 CLASS y_check_branch_coverage DEFINITION PUBLIC INHERITING FROM y_check_base CREATE PUBLIC .
   PUBLIC SECTION.
     METHODS constructor.
+
   PROTECTED SECTION.
     METHODS execute_check REDEFINITION.
     METHODS inspect_tokens REDEFINITION.
+
 ENDCLASS.
 
 

src/checks/y_check_call_method_usage.clas.abap

@@ -1,13 +1,10 @@
-CLASS y_check_call_method_usage DEFINITION
-  PUBLIC
-  INHERITING FROM y_check_base
-  CREATE PUBLIC .
-
+CLASS y_check_call_method_usage DEFINITION PUBLIC INHERITING FROM y_check_base CREATE PUBLIC .
   PUBLIC SECTION.
     METHODS constructor .
+
   PROTECTED SECTION.
     METHODS inspect_tokens REDEFINITION.
-  PRIVATE SECTION.
+
 ENDCLASS.
 
 
@@ -49,4 +46,6 @@ CLASS y_check_call_method_usage IMPLEMENTATION.
                    error_priority      = check_configuration-prio ).
     ENDIF.
   ENDMETHOD.
+
+
 ENDCLASS.

src/checks/y_check_chain_decl_usage.clas.abap

@@ -1,11 +1,15 @@
-CLASS y_check_chain_decl_usage DEFINITION PUBLIC INHERITING FROM y_check_base CREATE PUBLIC .
+CLASS y_check_chain_decl_usage DEFINITION PUBLIC INHERITING FROM y_check_base CREATE PUBLIC.
   PUBLIC SECTION.
     METHODS constructor.
+
   PROTECTED SECTION.
     METHODS inspect_tokens REDEFINITION.
+
   PRIVATE SECTION.
     DATA rows_with_colon TYPE STANDARD TABLE OF stmnt_crow.
+
     METHODS has_error_not_raised_yet IMPORTING statement TYPE sstmnt RETURNING VALUE(result) TYPE abap_bool.
+
 ENDCLASS.
 
 

src/checks/y_check_check_in_loop.clas.abap

@@ -3,7 +3,6 @@ CLASS y_check_check_in_loop DEFINITION PUBLIC INHERITING FROM y_check_base CREAT
     METHODS constructor .
 
   PROTECTED SECTION.
-    METHODS execute_check REDEFINITION.
     METHODS inspect_tokens REDEFINITION.
 
   PRIVATE SECTION.
@@ -25,35 +24,10 @@ CLASS y_check_check_in_loop IMPLEMENTATION.
     settings-threshold = 0.
     settings-documentation = |{ c_docs_path-checks }check-in-loop.md|.
 
-    set_check_message( 'Use an IF statement in combination with CONTINUE instead CHECK!' ).
-  ENDMETHOD.
-
-
-  METHOD execute_check.
-    LOOP AT ref_scan_manager->get_structures( ) ASSIGNING FIELD-SYMBOL(<structure>)
-    WHERE stmnt_type EQ scan_struc_stmnt_type-check.
-
-      is_testcode = test_code_detector->is_testcode( <structure> ).
+    relevant_statement_types = VALUE #( ( scan_struc_stmnt_type-check ) ).
+    relevant_structure_types = VALUE #( ).
 
-      TRY.
-          DATA(check_configuration) = check_configurations[ apply_on_testcode = abap_true ].
-        CATCH cx_sy_itab_line_not_found.
-          IF is_testcode EQ abap_true.
-            CONTINUE.
-          ENDIF.
-      ENDTRY.
-
-      DATA(index) = <structure>-stmnt_from.
-
-      LOOP AT ref_scan_manager->get_statements( ) ASSIGNING FIELD-SYMBOL(<statement>)
-      FROM <structure>-stmnt_from TO <structure>-stmnt_to.
-
-        inspect_tokens( index = index
-                        structure = <structure>
-                        statement = <statement> ).
-        index = index + 1.
-      ENDLOOP.
-    ENDLOOP.
+    set_check_message( 'Use an IF statement in combination with CONTINUE instead CHECK!' ).
   ENDMETHOD.
 
 
@@ -75,12 +49,9 @@ CLASS y_check_check_in_loop IMPLEMENTATION.
 
 
   METHOD get_back_statement.
-    DATA(structures) = ref_scan_manager->get_structures( ).
-    DATA(statements) = ref_scan_manager->get_statements( ).
-
     TRY.
-        DATA(back_structure) = structures[ structure-back ].
-        result = statements[ back_structure-stmnt_from ].
+        DATA(back_structure) = ref_scan_manager->structures[ structure-back ].
+        result = ref_scan_manager->statements[ back_structure-stmnt_from ].
       CATCH cx_sy_itab_line_not_found.
         CLEAR result.
     ENDTRY.

src/checks/y_check_check_stmnt_position.clas.abap

@@ -71,9 +71,7 @@ CLASS y_check_check_stmnt_position IMPLEMENTATION.
 
 
   METHOD has_wrong_position.
-    DATA(statements) = ref_scan_manager->get_statements( ).
-
-    LOOP AT ref_scan_manager->get_statements( ) ASSIGNING FIELD-SYMBOL(<statement>)
+    LOOP AT ref_scan_manager->statements ASSIGNING FIELD-SYMBOL(<statement>)
     FROM structure-stmnt_from TO structure-stmnt_to.
       IF <statement>-number = check-number.
         RETURN.
@@ -87,7 +85,7 @@ CLASS y_check_check_stmnt_position IMPLEMENTATION.
 
 
   METHOD is_check_in_loop.
-    LOOP AT ref_scan_manager->get_tokens( ) ASSIGNING FIELD-SYMBOL(<token>)
+    LOOP AT ref_scan_manager->tokens ASSIGNING FIELD-SYMBOL(<token>)
     FROM structure-stmnt_from TO check-from
     WHERE str = 'LOOP'
     OR str = 'ENDLOOP'.

src/checks/y_check_comment_position.clas.abap

@@ -63,11 +63,9 @@ CLASS Y_CHECK_COMMENT_POSITION IMPLEMENTATION.
 
 
   METHOD has_wrong_position.
-    DATA(tokens) = ref_scan_manager->get_tokens( ).
-
     TRY.
-        DATA(previous_token) = tokens[ statement-to - 1 ].
-        DATA(current_token) = tokens[ statement-to ].
+        DATA(previous_token) = ref_scan_manager->tokens[ statement-to - 1 ].
+        DATA(current_token) = ref_scan_manager->tokens[ statement-to ].
       CATCH cx_sy_itab_line_not_found.
         RETURN.
     ENDTRY.
@@ -132,9 +130,8 @@ CLASS Y_CHECK_COMMENT_POSITION IMPLEMENTATION.
 
 
   METHOD get_next_token.
-    DATA(tokens) = ref_scan_manager->get_tokens( ).
     DATA(next_position) = current_position + 1.
-    result = tokens[ next_position ].
+    result = ref_scan_manager->tokens[ next_position ].
     IF is_pragma( result ) = abap_true.
       result = get_next_token( next_position ).
     ENDIF.

src/checks/y_check_comment_type.clas.abap

@@ -40,7 +40,7 @@ CLASS y_check_comment_type IMPLEMENTATION.
   ENDMETHOD.
 
   METHOD has_wrong_comment_type.
-    LOOP AT ref_scan_manager->get_tokens( ) ASSIGNING FIELD-SYMBOL(<token>)
+    LOOP AT ref_scan_manager->tokens ASSIGNING FIELD-SYMBOL(<token>)
     FROM statement-from TO statement-to.
       IF get_first_character( <token> ) = '*'
       AND get_second_character( <token> ) <> '&'.