Skip to content

Commit 1e66896

Browse files
mushegh-sapmushegh-sap
committed
fix: add border radius to error messages in dropdown and combobox components
1 parent 1d64753 commit 1e66896

File tree

3 files changed

+18
-12
lines changed

3 files changed

+18
-12
lines changed

‎packages/ui-components/test/__snapshots__/UITextfield.test.tsx.snap‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ Object {
88
"borderBottom": "1px solid var(--vscode-inputValidation-errorBorder)",
99
"borderColor": "var(--vscode-inputValidation-errorBorder)",
1010
"borderLeft": "1px solid var(--vscode-inputValidation-errorBorder)",
11+
"borderRadius": "var(--vscode-cornerRadius-small)",
1112
"borderRight": "1px solid var(--vscode-inputValidation-errorBorder)",
1213
"color": "var(--vscode-input-foreground)",
1314
"margin": 0,
@@ -110,6 +111,7 @@ Object {
110111
"borderBottom": "1px solid var(--vscode-inputValidation-errorBorder)",
111112
"borderColor": "var(--vscode-inputValidation-errorBorder)",
112113
"borderLeft": "1px solid var(--vscode-inputValidation-errorBorder)",
114+
"borderRadius": "var(--vscode-cornerRadius-small)",
113115
"borderRight": "1px solid var(--vscode-inputValidation-errorBorder)",
114116
"color": "var(--vscode-input-foreground)",
115117
"margin": 0,
@@ -212,6 +214,7 @@ Object {
212214
"borderBottom": "1px solid var(--vscode-inputValidation-errorBorder)",
213215
"borderColor": "var(--vscode-inputValidation-errorBorder)",
214216
"borderLeft": "1px solid var(--vscode-inputValidation-errorBorder)",
217+
"borderRadius": "var(--vscode-cornerRadius-small)",
215218
"borderRight": "1px solid var(--vscode-inputValidation-errorBorder)",
216219
"color": "var(--vscode-input-foreground)",
217220
"margin": 0,
@@ -314,6 +317,7 @@ Object {
314317
"borderBottom": "1px solid var(--vscode-inputValidation-errorBorder)",
315318
"borderColor": "var(--vscode-inputValidation-errorBorder)",
316319
"borderLeft": "1px solid var(--vscode-inputValidation-errorBorder)",
320+
"borderRadius": "var(--vscode-cornerRadius-small)",
317321
"borderRight": "1px solid var(--vscode-inputValidation-errorBorder)",
318322
"color": "var(--vscode-input-foreground)",
319323
"margin": 0,
@@ -409,6 +413,7 @@ Object {
409413
"borderBottom": "1px solid var(--vscode-inputValidation-errorBorder)",
410414
"borderColor": "var(--vscode-inputValidation-errorBorder)",
411415
"borderLeft": "1px solid var(--vscode-inputValidation-errorBorder)",
416+
"borderRadius": "var(--vscode-cornerRadius-small)",
412417
"borderRight": "1px solid var(--vscode-inputValidation-errorBorder)",
413418
"color": "var(--vscode-input-foreground)",
414419
"margin": 0,
@@ -504,6 +509,7 @@ Object {
504509
"borderBottom": "1px solid var(--vscode-inputValidation-infoBorder)",
505510
"borderColor": "var(--vscode-inputValidation-infoBorder)",
506511
"borderLeft": "1px solid var(--vscode-inputValidation-infoBorder)",
512+
"borderRadius": "var(--vscode-cornerRadius-small)",
507513
"borderRight": "1px solid var(--vscode-inputValidation-infoBorder)",
508514
"color": "var(--vscode-input-foreground)",
509515
"margin": 0,
@@ -599,6 +605,7 @@ Object {
599605
"borderBottom": "1px solid var(--vscode-inputValidation-warningBorder)",
600606
"borderColor": "var(--vscode-inputValidation-warningBorder)",
601607
"borderLeft": "1px solid var(--vscode-inputValidation-warningBorder)",
608+
"borderRadius": "var(--vscode-cornerRadius-small)",
602609
"borderRight": "1px solid var(--vscode-inputValidation-warningBorder)",
603610
"color": "var(--vscode-input-foreground)",
604611
"margin": 0,
@@ -694,6 +701,7 @@ Object {
694701
"borderBottom": "1px solid var(--vscode-inputValidation-errorBorder)",
695702
"borderColor": "var(--vscode-inputValidation-errorBorder)",
696703
"borderLeft": "1px solid var(--vscode-inputValidation-errorBorder)",
704+
"borderRadius": "var(--vscode-cornerRadius-small)",
697705
"borderRight": "1px solid var(--vscode-inputValidation-errorBorder)",
698706
"color": "var(--vscode-input-foreground)",
699707
"margin": 0,
@@ -791,6 +799,7 @@ Object {
791799
"borderBottom": "1px solid var(--vscode-inputValidation-errorBorder)",
792800
"borderColor": "var(--vscode-inputValidation-errorBorder)",
793801
"borderLeft": "1px solid var(--vscode-inputValidation-errorBorder)",
802+
"borderRadius": "var(--vscode-cornerRadius-small)",
794803
"borderRight": "1px solid var(--vscode-inputValidation-errorBorder)",
795804
"color": "var(--vscode-input-foreground)",
796805
"margin": 0,
@@ -897,6 +906,7 @@ Object {
897906
"borderBottom": "1px solid var(--vscode-inputValidation-errorBorder)",
898907
"borderColor": "var(--vscode-inputValidation-errorBorder)",
899908
"borderLeft": "1px solid var(--vscode-inputValidation-errorBorder)",
909+
"borderRadius": "var(--vscode-cornerRadius-small)",
900910
"borderRight": "1px solid var(--vscode-inputValidation-errorBorder)",
901911
"color": "var(--vscode-input-foreground)",
902912
"margin": 0,
@@ -992,6 +1002,7 @@ Object {
9921002
"borderBottom": "1px solid var(--vscode-inputValidation-errorBorder)",
9931003
"borderColor": "var(--vscode-inputValidation-errorBorder)",
9941004
"borderLeft": "1px solid var(--vscode-inputValidation-errorBorder)",
1005+
"borderRadius": "var(--vscode-cornerRadius-small)",
9951006
"borderRight": "1px solid var(--vscode-inputValidation-errorBorder)",
9961007
"color": "var(--vscode-input-foreground)",
9971008
"margin": 0,
@@ -1087,6 +1098,7 @@ Object {
10871098
"borderBottom": "1px solid var(--vscode-inputValidation-errorBorder)",
10881099
"borderColor": "var(--vscode-inputValidation-errorBorder)",
10891100
"borderLeft": "1px solid var(--vscode-inputValidation-errorBorder)",
1101+
"borderRadius": "var(--vscode-cornerRadius-small)",
10901102
"borderRight": "1px solid var(--vscode-inputValidation-errorBorder)",
10911103
"color": "var(--vscode-input-foreground)",
10921104
"margin": 0,
@@ -1191,6 +1203,7 @@ Object {
11911203
"borderBottom": "1px solid var(--vscode-inputValidation-errorBorder)",
11921204
"borderColor": "var(--vscode-inputValidation-errorBorder)",
11931205
"borderLeft": "1px solid var(--vscode-inputValidation-errorBorder)",
1206+
"borderRadius": "var(--vscode-cornerRadius-small)",
11941207
"borderRight": "1px solid var(--vscode-inputValidation-errorBorder)",
11951208
"color": "var(--vscode-input-foreground)",
11961209
"margin": 0,
@@ -1284,6 +1297,7 @@ Object {
12841297
"borderBottom": "1px solid var(--vscode-inputValidation-errorBorder)",
12851298
"borderColor": "var(--vscode-inputValidation-errorBorder)",
12861299
"borderLeft": "1px solid var(--vscode-inputValidation-errorBorder)",
1300+
"borderRadius": "var(--vscode-cornerRadius-small)",
12871301
"borderRight": "1px solid var(--vscode-inputValidation-errorBorder)",
12881302
"color": "var(--vscode-input-foreground)",
12891303
"margin": 0,

‎packages/ui-components/test/unit/components/UICombobox.test.tsx‎

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -73,18 +73,13 @@ describe('<UIComboBox />', () => {
7373
{},
7474
`
7575
Object {
76-
"__shadowConfig__": Object {
77-
"__isShadowConfig__": true,
78-
"inShadow": false,
79-
"stylesheetKey": "ComboBox",
80-
"window": [Window],
81-
},
8276
"errorMessage": Array [
8377
Object {
8478
"backgroundColor": "var(--vscode-inputValidation-errorBackground)",
8579
"borderBottom": "1px solid var(--vscode-inputValidation-errorBorder)",
8680
"borderColor": "var(--vscode-inputValidation-errorBorder)",
8781
"borderLeft": "1px solid var(--vscode-inputValidation-errorBorder)",
82+
"borderRadius": "var(--vscode-cornerRadius-small)",
8883
"borderRight": "1px solid var(--vscode-inputValidation-errorBorder)",
8984
"color": "var(--vscode-input-foreground)",
9085
"margin": 0,
@@ -113,18 +108,13 @@ describe('<UIComboBox />', () => {
113108
{},
114109
`
115110
Object {
116-
"__shadowConfig__": Object {
117-
"__isShadowConfig__": true,
118-
"inShadow": false,
119-
"stylesheetKey": "ComboBox",
120-
"window": [Window],
121-
},
122111
"errorMessage": Array [
123112
Object {
124113
"backgroundColor": "var(--vscode-inputValidation-errorBackground)",
125114
"borderBottom": "1px solid var(--vscode-inputValidation-errorBorder)",
126115
"borderColor": "var(--vscode-inputValidation-errorBorder)",
127116
"borderLeft": "1px solid var(--vscode-inputValidation-errorBorder)",
117+
"borderRadius": "var(--vscode-cornerRadius-small)",
128118
"borderRight": "1px solid var(--vscode-inputValidation-errorBorder)",
129119
"color": "var(--vscode-input-foreground)",
130120
"margin": 0,

‎packages/ui-components/test/unit/components/UIDropdown.test.tsx‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ describe('<UIDropdown />', () => {
5757
"borderBottom": "1px solid var(--vscode-inputValidation-errorBorder)",
5858
"borderColor": "var(--vscode-inputValidation-errorBorder)",
5959
"borderLeft": "1px solid var(--vscode-inputValidation-errorBorder)",
60+
"borderRadius": "var(--vscode-cornerRadius-small)",
6061
"borderRight": "1px solid var(--vscode-inputValidation-errorBorder)",
6162
"color": "var(--vscode-input-foreground)",
6263
"margin": 0,
@@ -89,6 +90,7 @@ describe('<UIDropdown />', () => {
8990
"borderBottom": "1px solid var(--vscode-inputValidation-errorBorder)",
9091
"borderColor": "var(--vscode-inputValidation-errorBorder)",
9192
"borderLeft": "1px solid var(--vscode-inputValidation-errorBorder)",
93+
"borderRadius": "var(--vscode-cornerRadius-small)",
9294
"borderRight": "1px solid var(--vscode-inputValidation-errorBorder)",
9395
"color": "var(--vscode-input-foreground)",
9496
"margin": 0,

0 commit comments

Comments
 (0)