bug6122: also refactor TableWrapper to use SelectionCheckboxColumn.createHeader()

axeluhl · axeluhl · commit 755d34b5c45c · 2025-12-27T21:42:31.000+01:00
diff --git a/java/com.sap.sailing.dashboards.gwt/.settings/com.gwtplugins.gwt.eclipse.core.prefs b/java/com.sap.sailing.dashboards.gwt/.settings/com.gwtplugins.gwt.eclipse.core.prefs
@@ -6,6 +6,7 @@
 //gwtVersion_/opt/gwt-2.12.4=2.12.4
 //gwtVersion_/usr/local/gwt-2.11.0=2.11.0
 //gwtVersion_/usr/local/gwt-2.12.2=2.12.2
+//gwtVersion_/usr/local/gwt-2.12.4=2.12.4
 eclipse.preferences.version=1
 entryPointModules=
 filesCopiedToWebInfLib=
diff --git a/java/com.sap.sailing.datamining.shared/.settings/com.gwtplugins.gwt.eclipse.core.prefs b/java/com.sap.sailing.datamining.shared/.settings/com.gwtplugins.gwt.eclipse.core.prefs
@@ -4,6 +4,7 @@
 //gwtVersion_/opt/gwt-2.12.4=2.12.4
 //gwtVersion_/usr/local/gwt-2.11.0=2.11.0
 //gwtVersion_/usr/local/gwt-2.12.2=2.12.2
+//gwtVersion_/usr/local/gwt-2.12.4=2.12.4
 eclipse.preferences.version=1
 entryPointModules=
 filesCopiedToWebInfLib=
diff --git a/java/com.sap.sailing.datamining/.settings/com.gwtplugins.gwt.eclipse.core.prefs b/java/com.sap.sailing.datamining/.settings/com.gwtplugins.gwt.eclipse.core.prefs
@@ -4,6 +4,7 @@
 //gwtVersion_/opt/gwt-2.12.4=2.12.4
 //gwtVersion_/usr/local/gwt-2.11.0=2.11.0
 //gwtVersion_/usr/local/gwt-2.12.2=2.12.2
+//gwtVersion_/usr/local/gwt-2.12.4=2.12.4
 eclipse.preferences.version=1
 entryPointModules=
 filesCopiedToWebInfLib=
diff --git a/java/com.sap.sailing.gwt.ui/.settings/com.gwtplugins.gwt.eclipse.core.prefs b/java/com.sap.sailing.gwt.ui/.settings/com.gwtplugins.gwt.eclipse.core.prefs
@@ -5,6 +5,7 @@
 //gwtVersion_/opt/gwt-2.12.4=2.12.4
 //gwtVersion_/usr/local/gwt-2.11.0=2.11.0
 //gwtVersion_/usr/local/gwt-2.12.2=2.12.2
+//gwtVersion_/usr/local/gwt-2.12.4=2.12.4
 eclipse.preferences.version=1
 entryPointModules=
 filesCopiedToWebInfLib=
diff --git a/java/com.sap.sailing.polars.datamining.shared/.settings/com.gwtplugins.gwt.eclipse.core.prefs b/java/com.sap.sailing.polars.datamining.shared/.settings/com.gwtplugins.gwt.eclipse.core.prefs
@@ -4,6 +4,7 @@
 //gwtVersion_/opt/gwt-2.12.4=2.12.4
 //gwtVersion_/usr/local/gwt-2.11.0=2.11.0
 //gwtVersion_/usr/local/gwt-2.12.2=2.12.2
+//gwtVersion_/usr/local/gwt-2.12.4=2.12.4
 eclipse.preferences.version=1
 entryPointModules=
 filesCopiedToWebInfLib=
diff --git a/java/com.sap.sailing.simulator/.settings/com.gwtplugins.gwt.eclipse.core.prefs b/java/com.sap.sailing.simulator/.settings/com.gwtplugins.gwt.eclipse.core.prefs
@@ -4,6 +4,7 @@
 //gwtVersion_/opt/gwt-2.12.4=2.12.4
 //gwtVersion_/usr/local/gwt-2.11.0=2.11.0
 //gwtVersion_/usr/local/gwt-2.12.2=2.12.2
+//gwtVersion_/usr/local/gwt-2.12.4=2.12.4
 eclipse.preferences.version=1
 entryPointModules=
 filesCopiedToWebInfLib=
diff --git a/java/com.sap.sse.common/.settings/com.gwtplugins.gwt.eclipse.core.prefs b/java/com.sap.sse.common/.settings/com.gwtplugins.gwt.eclipse.core.prefs
@@ -4,6 +4,7 @@
 //gwtVersion_/opt/gwt-2.12.4=2.12.4
 //gwtVersion_/usr/local/gwt-2.11.0=2.11.0
 //gwtVersion_/usr/local/gwt-2.12.2=2.12.2
+//gwtVersion_/usr/local/gwt-2.12.4=2.12.4
 eclipse.preferences.version=1
 entryPointModules=
 filesCopiedToWebInfLib=
diff --git a/java/com.sap.sse.gwt.adminconsole/.settings/com.gwtplugins.gwt.eclipse.core.prefs b/java/com.sap.sse.gwt.adminconsole/.settings/com.gwtplugins.gwt.eclipse.core.prefs
@@ -5,6 +5,7 @@
 //gwtVersion_/opt/gwt-2.12.4=2.12.4
 //gwtVersion_/usr/local/gwt-2.11.0=2.11.0
 //gwtVersion_/usr/local/gwt-2.12.2=2.12.2
+//gwtVersion_/usr/local/gwt-2.12.4=2.12.4
 eclipse.preferences.version=1
 entryPointModules=
 filesCopiedToWebInfLib=
diff --git a/java/com.sap.sse.gwt.test/.settings/com.gwtplugins.gwt.eclipse.core.prefs b/java/com.sap.sse.gwt.test/.settings/com.gwtplugins.gwt.eclipse.core.prefs
@@ -5,6 +5,7 @@
 //gwtVersion_/opt/gwt-2.12.4=2.12.4
 //gwtVersion_/usr/local/gwt-2.11.0=2.11.0
 //gwtVersion_/usr/local/gwt-2.12.2=2.12.2
+//gwtVersion_/usr/local/gwt-2.12.4=2.12.4
 eclipse.preferences.version=1
 entryPointModules=
 filesCopiedToWebInfLib=
diff --git a/java/com.sap.sse.gwt/.settings/com.gwtplugins.gwt.eclipse.core.prefs b/java/com.sap.sse.gwt/.settings/com.gwtplugins.gwt.eclipse.core.prefs
@@ -5,6 +5,7 @@
 //gwtVersion_/opt/gwt-2.12.4=2.12.4
 //gwtVersion_/usr/local/gwt-2.11.0=2.11.0
 //gwtVersion_/usr/local/gwt-2.12.2=2.12.2
+//gwtVersion_/usr/local/gwt-2.12.4=2.12.4
 eclipse.preferences.version=1
 entryPointModules=
 filesCopiedToWebInfLib=
diff --git a/java/com.sap.sse.gwt/src/com/sap/sse/gwt/client/celltable/TableWrapper.java b/java/com.sap.sse.gwt/src/com/sap/sse/gwt/client/celltable/TableWrapper.java
@@ -6,6 +6,7 @@
 import com.google.gwt.core.client.GWT;
 import com.google.gwt.user.cellview.client.Column;
 import com.google.gwt.user.cellview.client.ColumnSortEvent.ListHandler;
+import com.google.gwt.user.cellview.client.Header;
 import com.google.gwt.user.cellview.client.SimplePager;
 import com.google.gwt.user.cellview.client.TextColumn;
 import com.google.gwt.user.client.ui.IsWidget;
@@ -20,8 +21,6 @@
 import com.sap.sse.gwt.client.ErrorReporter;
 import com.sap.sse.gwt.client.StringMessages;
 import com.sap.sse.gwt.client.panels.AbstractFilterablePanel;
-import com.google.gwt.user.cellview.client.Header;
-import com.google.gwt.cell.client.CheckboxCell;
 
 /**
  * The {@link #getTable() table} created and wrapped by this object offers already a {@link ListHandler} for sorting.
@@ -241,32 +240,11 @@ public void registerSelectionModelOnNewDataProvider(ListDataProvider<T> dataProv
                     getTableRes().cellTableStyle().cellTableCheckboxColumnCell(), entityIdentityComparator, dataProvider,
                     table);
             columnSortHandler.setComparator(selectionCheckboxColumn, selectionCheckboxColumn.getComparator());
-            selectionCheckboxColumn.setSortable(false);
             @SuppressWarnings("unchecked")
             final S typedSelectionModel = (S) selectionCheckboxColumn.getSelectionModel();
             selectionModel = typedSelectionModel;
             table.setSelectionModel(selectionModel, selectionCheckboxColumn.getSelectionManager());
-            final CheckboxCell selectAllCell = new CheckboxCell();
-            final Header<Boolean> selectAllHeader = new Header<Boolean>(selectAllCell) {
-                @Override
-                public Boolean getValue() {
-                    return false;
-                }
-            };
-            selectAllHeader.setUpdater(value -> {
-                for (final T mp : dataProvider.getList()) {
-                    if (selectionModel != null) {
-                        selectionModel.setSelected(mp, value);
-                    }
-                }
-            });
-            selectionModel.addSelectionChangeHandler(e -> {
-                if (selectionModel.getSelectedSet().isEmpty()) {
-                    selectAllCell.setViewData(/* key */ selectAllHeader.getValue(), false);
-                } else if (selectionModel.getSelectedSet().size() == dataProvider.getList().size()) {
-                    selectAllCell.setViewData(/* key */ selectAllHeader.getValue(), true);
-                }
-            });
+            final Header<Boolean> selectAllHeader = selectionCheckboxColumn.createHeader();
             table.addColumn(selectionCheckboxColumn, selectAllHeader);
         } else {
             @SuppressWarnings("unchecked")
diff --git a/java/com.sap.sse.security.common/.settings/com.gwtplugins.gwt.eclipse.core.prefs b/java/com.sap.sse.security.common/.settings/com.gwtplugins.gwt.eclipse.core.prefs
@@ -4,6 +4,7 @@
 //gwtVersion_/opt/gwt-2.12.4=2.12.4
 //gwtVersion_/usr/local/gwt-2.11.0=2.11.0
 //gwtVersion_/usr/local/gwt-2.12.2=2.12.2
+//gwtVersion_/usr/local/gwt-2.12.4=2.12.4
 eclipse.preferences.version=1
 entryPointModules=
 filesCopiedToWebInfLib=
diff --git a/java/com.sap.sse.security.ui/.settings/com.gwtplugins.gwt.eclipse.core.prefs b/java/com.sap.sse.security.ui/.settings/com.gwtplugins.gwt.eclipse.core.prefs
@@ -5,6 +5,7 @@
 //gwtVersion_/opt/gwt-2.12.4=2.12.4
 //gwtVersion_/usr/local/gwt-2.11.0=2.11.0
 //gwtVersion_/usr/local/gwt-2.12.2=2.12.2
+//gwtVersion_/usr/local/gwt-2.12.4=2.12.4
 eclipse.preferences.version=1
 entryPointModules=
 filesCopiedToWebInfLib=
