fix: Account set flow with "refershOnSuccess" optional + AboutMe.kt loading banner

Author: tal-mi

.github/workflows/bits&bytes_develop_tfa_push_debug.yml

@@ -54,7 +54,7 @@ jobs:
 
         upsert_string app/src/main/res/values/strings.xml "asset_statements" '${{ secrets.BITS_N_BYTES_ASSET_STATEMENTS }}'
         upsert_string app/src/variant/res/values/strings.xml "asset_statements" '${{ secrets.BITS_N_BYTES_ASSET_STATEMENTS }}'
-      
+
     - name: Add Google required resources to strings.xml resource (actual value for demo only)
       run: |
         sed -i '/<\/resources>/i \    <string name="google_server_client_id">${{ secrets.GOOGLE_WEB_SERVER_CLIENT_ID }}</string>' app/src/main/res/values/strings.xml

app/src/main/java/com/sap/cdc/bitsnbytes/feature/auth/AuthenticationFlowDelegate.kt

@@ -178,7 +178,10 @@ class AuthenticationFlowDelegate(context: Context) {
         parameters: MutableMap<String, String> = mutableMapOf(),
         authCallbacks: AuthCallbacks.() -> Unit
     ) {
-        authenticationService.account().set(parameters) {
+        authenticationService.account().set(
+            parameters = parameters,
+            refreshOnSuccess = true
+        ) {
             // Register original callbacks first
             authCallbacks()
 

app/src/main/java/com/sap/cdc/bitsnbytes/ui/view/screens/AboutMe.kt

@@ -34,7 +34,7 @@ import androidx.compose.ui.unit.dp
 import androidx.compose.ui.unit.sp
 import com.sap.cdc.bitsnbytes.apptheme.AppTheme
 import com.sap.cdc.bitsnbytes.ui.view.composables.ActionOutlineInverseButton
-import com.sap.cdc.bitsnbytes.ui.view.composables.IndeterminateLinearIndicator
+import com.sap.cdc.bitsnbytes.ui.view.composables.LoadingStateColumn
 import com.sap.cdc.bitsnbytes.ui.view.composables.SimpleErrorMessages
 import com.sap.cdc.bitsnbytes.ui.view.composables.SuccessBanner
 import com.sap.cdc.bitsnbytes.ui.viewmodel.AccountViewModelPreview
@@ -71,11 +71,12 @@ fun AboutMeView(viewModel: IAccountViewModel) {
         )
     }
 
-    Column(
+    LoadingStateColumn(
         modifier = Modifier
             .background(Color(0xFFF5F5F5))
             .fillMaxWidth()
             .fillMaxHeight(),
+        loading = loading
     ) {
         // About me section header with gray background
         Box(
@@ -166,7 +167,6 @@ fun AboutMeView(viewModel: IAccountViewModel) {
             }
         }
 
-        Spacer(modifier = Modifier.weight(1f))
 
         // Error message
         if (setError.isNotEmpty()) {
@@ -207,17 +207,6 @@ fun AboutMeView(viewModel: IAccountViewModel) {
             )
         }
 
-        // Loading indicator
-        if (loading) {
-            Box(
-                modifier = Modifier
-                    .fillMaxWidth()
-                    .padding(top = 16.dp)
-            ) {
-                IndeterminateLinearIndicator(loading)
-            }
-        }
-
         // Auto-hide after 2 seconds
         if (showBanner) {
             LaunchedEffect(Unit) {

library/src/main/java/com/sap/cdc/android/sdk/feature/auth/flow/account/AuthAccountFlow.kt

@@ -57,6 +57,7 @@ class AuthAccountFlow(coreClient: CoreClient, sessionService: SessionService) :
      */
     suspend fun setAccountInfo(
         parameters: MutableMap<String, String>? = mutableMapOf(),
+        refreshOnSuccess: Boolean = false,
         callbacks: AuthCallbacks,
     ) {
         CDCDebuggable.log(
@@ -78,8 +79,15 @@ class AuthAccountFlow(coreClient: CoreClient, sessionService: SessionService) :
         }
 
         // Success case
-        val authSuccess = createAuthSuccess(request)
-        callbacks.onSuccess?.invoke(authSuccess)
+        if (!refreshOnSuccess) {
+            // If not refreshing, return the current response
+            val authSuccess = createAuthSuccess(request)
+            callbacks.onSuccess?.invoke(authSuccess)
+            return
+        }
+
+        // Perform a getAccountInfo to refresh the data
+        getAccountInfo(mutableMapOf(), callbacks)
     }
 
     /**

library/src/main/java/com/sap/cdc/android/sdk/feature/auth/flow/account/IAuthAccount.kt

@@ -13,7 +13,8 @@ interface IAuthAccount {
 
     suspend fun set(
         parameters: MutableMap<String, String>,
-        configure: AuthCallbacks.() -> Unit
+        refreshOnSuccess: Boolean = false,
+        configure: AuthCallbacks.() -> Unit,
     )
 
     suspend fun authCode(
@@ -37,10 +38,12 @@ internal class AuthAccount(
 
     override suspend fun set(
         parameters: MutableMap<String, String>,
-        configure: AuthCallbacks.() -> Unit
+        refreshOnSuccess: Boolean,
+        configure: AuthCallbacks.() -> Unit,
     ) {
         val callbacks = AuthCallbacks().apply(configure)
-        AuthAccountFlow(coreClient, sessionService).setAccountInfo(parameters, callbacks)
+        AuthAccountFlow(coreClient, sessionService).setAccountInfo(
+            parameters = parameters, refreshOnSuccess = refreshOnSuccess, callbacks = callbacks)
     }
 
     override suspend fun authCode(