Add DistributedTransactionCommitFailureError (#483)

Author: kasium

CHANGES.rst

@@ -5,6 +5,7 @@ Changelog
 -----
 
 - Added ``NumberOfTransactionsExceededError`` to ``sqlalchemy_hana.errors``
+- Added ``DistributedTransactionCommitFailureError`` to ``sqlalchemy_hana.errors``
 
 4.1.0
 -----

pyproject.toml

@@ -46,7 +46,7 @@ maintainers = [
 name = "sqlalchemy-hana"
 readme = "README.rst"
 requires-python = "~=3.10"
-version = "4.1.0"
+version = "4.2.0"
 
 [project.optional-dependencies]
 alembic = ["alembic~=1.12"]

sqlalchemy_hana/errors.py

@@ -100,6 +100,10 @@ class NumberOfTransactionsExceededError(HANAError):
     """Exception raised when the number of allowed transactions is exceeded."""
 
 
+class DistributedTransactionCommitFailureError(StatementExecutionError):
+    """Exception raised when a distributed transaction commit fails."""
+
+
 def convert_dbapi_error(dbapi_error: DBAPIError) -> DBAPIError:
     """Takes a :py:exc:`sqlalchemy.exc.DBAPIError` and returns a more specific error if possible.
 
@@ -189,6 +193,9 @@ def convert_dbapi_error(dbapi_error: DBAPIError) -> DBAPIError:
         and "exceed maximum number of transactions" in error.errortext
     ):
         return NumberOfTransactionsExceededError.from_dbapi_error(dbapi_error)
+    # 149 -> ERR_TX_DIST_2PC_FAILURE
+    if error.errorcode == 149:
+        return DistributedTransactionCommitFailureError.from_dbapi_error(dbapi_error)
     return dbapi_error
 
 

test/test_errors.py

@@ -13,6 +13,7 @@
     DatabaseOutOfMemoryError,
     DatabaseOverloadedError,
     DeadlockError,
+    DistributedTransactionCommitFailureError,
     InvalidObjectNameError,
     LockAcquisitionError,
     LockWaitTimeoutError,
@@ -104,6 +105,7 @@ class TestConvertDBAPIError(TestBase):
                 "transaction error: exceed maximum number of transactions",
                 NumberOfTransactionsExceededError,
             ),
+            (149, "something", DistributedTransactionCommitFailureError),
         ],
     )
     def test_convert_dbapi_error(
@@ -128,3 +130,4 @@ def test_convert_dbapi_error_no_wrap(self, errorcode: int, errortext: str) -> No
         error = HdbcliError(errorcode, errortext)
         dbapi_error = DBAPIError(None, None, error)
         assert convert_dbapi_error(dbapi_error) is dbapi_error
+        assert convert_dbapi_error(dbapi_error) is dbapi_error