chore: GH pipeline refinements (#544)

* chore: GH pipeline refinements

* chore: GH pipeline refinements

---------

Co-authored-by: Christian Lechner <22294087+lechnerc77@users.noreply.github.com>

Author: lechnerc77

.github/workflows/integration-test.yml

@@ -99,7 +99,7 @@ jobs:
 
       - name: JSON inventory for Subaccount
         id: json-inventory-subaccount
-        if: ${{ success() }} || ${{ failure() }}
+        if: ${{ success() || failure() }}
         run: |
           trap 'exit_code=$?; if [ $exit_code -ne 0 ]; then echo "result=failure" >> "$GITHUB_OUTPUT"; fi' EXIT
           export BTP_USERNAME=${{ secrets.BTP_USERNAME }}
@@ -152,7 +152,7 @@ jobs:
 
       - name: JSON inventory for Cloud Foundry Org
         id: json-inventory-cforg
-        if: ${{ success() }} || ${{ failure() }}
+        if: ${{ success() || failure() }}
         run: |
           trap 'exit_code=$?; if [ $exit_code -ne 0 ]; then echo "result=failure" >> "$GITHUB_OUTPUT"; fi' EXIT
           export CF_USER=${{ secrets.BTP_USERNAME }}
@@ -296,7 +296,7 @@ jobs:
 
       - name: Export by JSON for Subaccount
         id: export-by-json-subaccount
-        if: ${{ success() }} || ${{ failure() }}
+        if: ${{ success() || failure() }}
         run: |
           trap 'exit_code=$?; if [ $exit_code -ne 0 ]; then echo "result=failure" >> "$GITHUB_OUTPUT"; fi' EXIT
           echo "====================================="
@@ -376,7 +376,7 @@ jobs:
 
       - name: Export by JSON for Cloud Foundry Organization
         id: export-by-json-cforg
-        if: ${{ success() }} || ${{ failure() }}
+        if: ${{ success() || failure() }}
         run: |
           trap 'exit_code=$?; if [ $exit_code -ne 0 ]; then echo "result=failure" >> "$GITHUB_OUTPUT"; fi' EXIT
           echo "====================================="
@@ -420,8 +420,6 @@ jobs:
     timeout-minutes: 10
     outputs:
       output_dir_export_by_res: ${{ steps.export-by-resource-directory.outputs.result }}
-      output_subacount_export_by_res: ${{ steps.export-by-resource-subaccount.outputs.result }}
-      output_cforg_export_by_res: ${{ steps.export-by-resource-cforg.outputs.result }}
     steps:
       - name: Checkout repository
         uses: actions/checkout@v6
@@ -500,9 +498,7 @@ jobs:
     runs-on: ubuntu-latest
     timeout-minutes: 10
     outputs:
-      output_dir_export_by_res: ${{ steps.export-by-resource-directory.outputs.result }}
       output_subacount_export_by_res: ${{ steps.export-by-resource-subaccount.outputs.result }}
-      output_cforg_export_by_res: ${{ steps.export-by-resource-cforg.outputs.result }}
     steps:
       - name: Checkout repository
         uses: actions/checkout@v6
@@ -540,7 +536,7 @@ jobs:
 
       - name: Export by Resource for Subaccount
         id: export-by-resource-subaccount
-        if: ${{ success() }} || ${{ failure() }}
+        if: ${{ success() || failure() }}
         run: |
           trap 'exit_code=$?; if [ $exit_code -ne 0 ]; then echo "result=failure" >> "$GITHUB_OUTPUT"; fi' EXIT
           echo "====================================="
@@ -620,7 +616,7 @@ jobs:
 
       - name: Export by Resource for Cloud Foundry Organization
         id: export-by-resource-cforg
-        if: ${{ success() }} || ${{ failure() }}
+        if: ${{ success() || failure() }}
         run: |
           trap 'exit_code=$?; if [ $exit_code -ne 0 ]; then echo "result=failure" >> "$GITHUB_OUTPUT"; fi' EXIT
           echo "====================================="

.github/workflows/publish-chocolatey-package.yml

@@ -9,7 +9,7 @@ on:
       push-to-chocolatey:
         description: 'Trigger to update Chocolatey package'
         required: true
-        default: false
+        default: "false"
   release:
     types: [published]
 permissions:
@@ -36,7 +36,7 @@ jobs:
             latest_tag=$(git describe --tags --abbrev=0 --match "v*")
             echo "TAG=$latest_tag" >> "$GITHUB_OUTPUT"
           fi
-      
+
       - name: Determine Chocolatey push
         id: determine-choco-push
         run: |
@@ -88,7 +88,7 @@ jobs:
           sed -i "s/VERSION/${RELEASE_VERSION}/g" choco/sap-btptf.nuspec
           sed -i "s/VERSION/${RELEASE_VERSION}/g" choco/tools/chocolateyInstall.ps1
           sed -i "s/CHECKSUM/${SHA256}/g" choco/tools/chocolateyInstall.ps1
-          
+
       - name: Print config
         run: |
           echo NUSPEC
@@ -102,7 +102,7 @@ jobs:
       - name: Choco package
         run: |
           choco pack choco/sap-btptf.nuspec
-      
+
       - name: Upload package artifact
         uses: actions/upload-artifact@v6
         with:

.github/workflows/update-brew-formula.yaml

@@ -25,7 +25,6 @@ jobs:
       - name: Extract SHA from release
         id: extract-sha
         run: |
-          echo "Event '${{ github.event.action }}'"
           echo "BTP Terraform binary hash:"
           tag=$(echo ${{ steps.latest-release.outputs.LATEST_TAG }} | cut -c 2-)
           darwin_amd64_sha="btptf_${tag}_darwin_amd64.sha256"