Skip to content

Commit 2989032

Browse files
committed
[INTERNAL] Apply UA review from preload-excludes PR
Follow-up of: #573
1 parent 5d33369 commit 2989032

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

lib/processors/bundlers/moduleBundler.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,10 @@ const log = require("@ui5/logger").getLogger("builder:processors:bundlers:module
4040
* @property {string} mode The embedding mode. Either 'provided', 'raw', 'preload' or 'require'
4141
* @property {string[]} filters List of modules declared as glob patterns (resource name patterns) that should be
4242
* in- or excluded.
43-
* A pattern ending with a slash '/' will, similarly to the use of a single '*' or double '**' asterisks,
43+
* A pattern ending with a slash '/' will, similarly to the use of a single '*' or double '**' asterisk,
4444
* denote an arbitrary number of characters or folder names.
45-
* Excludes should be marked with a leading exclamation mark '!'. The order of filters is relevant, a later
46-
* exclusion overrides an earlier inclusion and vice versa.
45+
* Excludes should be marked with a leading exclamation mark '!'. The order of filters is relevant; a later
46+
* exclusion overrides an earlier inclusion, and vice versa.
4747
* @example <caption>List of modules as glob patterns that should be in- or excluded</caption>
4848
* // Includes everything from "some/path/to/module/",
4949
* // but excludes the subfolder "some/path/to/module/to/be/excluded/"

lib/tasks/bundlers/generateComponentPreload.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,10 @@ const {negateFilters} = require("../../lbt/resources/ResourceFilterList");
1717
* @param {string} parameters.options.projectName Project name
1818
* @param {string[]} [parameters.options.excludes=[]] List of modules declared as glob patterns (resource name patterns)
1919
* that should be excluded.
20-
* A pattern ending with a slash '/' will, similarly to the use of a single '*' or double '**' asterisks,
20+
* A pattern ending with a slash '/' will, similarly to the use of a single '*' or double '**' asterisk,
2121
* denote an arbitrary number of characters or folder names.
22-
* Re-includes should be marked with a leading exclamation mark '!'. The order of filters is relevant, a later
23-
* inclusion overrides an earlier exclusion and vice versa.
22+
* Re-includes should be marked with a leading exclamation mark '!'. The order of filters is relevant; a later
23+
* inclusion overrides an earlier exclusion, and vice versa.
2424
* @param {string[]} [parameters.options.paths] Array of paths (or glob patterns) for component files
2525
* @param {string[]} [parameters.options.namespaces] Array of component namespaces
2626
* @returns {Promise<undefined>} Promise resolving with <code>undefined</code> once data has been written

lib/tasks/bundlers/generateLibraryPreload.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -282,10 +282,10 @@ function getSapUiCoreBunDef(name, filters, preload) {
282282
* @param {module:@ui5/builder.tasks.TaskUtil|object} [parameters.taskUtil] TaskUtil
283283
* @param {string[]} [parameters.options.excludes=[]] List of modules declared as glob patterns (resource name patterns)
284284
* that should be excluded from the library-preload.js bundle.
285-
* A pattern ending with a slash '/' will, similarly to the use of a single '*' or double '**' asterisks,
285+
* A pattern ending with a slash '/' will, similarly to the use of a single '*' or double '**' asterisk,
286286
* denote an arbitrary number of characters or folder names.
287-
* Re-includes should be marked with a leading exclamation mark '!'. The order of filters is relevant, a later
288-
* inclusion overrides an earlier exclusion and vice versa.
287+
* Re-includes should be marked with a leading exclamation mark '!'. The order of filters is relevant; a later
288+
* inclusion overrides an earlier exclusion, and vice versa.
289289
* @param {object} parameters.options Options
290290
* @param {string} parameters.options.projectName Project name
291291
* @returns {Promise<undefined>} Promise resolving with <code>undefined</code> once data has been written

0 commit comments

Comments
 (0)