Skip to content

Commit 42ce003

Browse files
committed
Change logging for missing libraryManifest to verbose
With regards to backward compatibility the libraryManifest can be missing. When --all is omitted the libraryManifest can also be missing.
1 parent 8eeab50 commit 42ce003

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

lib/processors/versionInfoGenerator.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -288,7 +288,7 @@ async function processManifestAndGetArtifactInfo(libraryManifest, name) {
288288
*/
289289
const processLibraryInfo = async (libraryInfo) => {
290290
if (!libraryInfo.libraryManifest) {
291-
log.warn(
291+
log.verbose(
292292
`Cannot add meta information for library '${libraryInfo.name}'. The manifest.json file cannot be found`);
293293
return;
294294
}

test/lib/processors/versionInfoGenerator.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,8 @@ test.serial("versionInfoGenerator simple library infos", async (t) => {
8585
]
8686
};
8787
assertVersionInfoContent(t, oExpected, result);
88-
t.is(t.context.warnLogStub.callCount, 1);
89-
t.is(t.context.warnLogStub.getCall(0).args[0],
88+
t.is(t.context.verboseLogStub.callCount, 1);
89+
t.is(t.context.verboseLogStub.getCall(0).args[0],
9090
"Cannot add meta information for library 'my.lib'. The manifest.json file cannot be found");
9191
});
9292

test/lib/tasks/generateVersionInfo.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,8 +146,8 @@ test.serial("integration: Library without i18n bundle file", async (t) => {
146146
"version": "1.33.7",
147147
}, oOptions);
148148

149-
t.is(t.context.warnLogStub.callCount, 1);
150-
t.is(t.context.warnLogStub.getCall(0).args[0],
149+
t.is(t.context.verboseLogStub.callCount, 1);
150+
t.is(t.context.verboseLogStub.getCall(0).args[0],
151151
"Cannot add meta information for library 'test.lib3'. The manifest.json file cannot be found");
152152
});
153153

0 commit comments

Comments
 (0)