FioriElementsAnalyzer: Add tests for error cases

Author: matz3

test/lib/lbt/analyzer/FioriElementsAnalyzer.js

@@ -245,6 +245,68 @@ test("_analyzeAST: get template name from ast", async (t) => {
 	t.is(templateName, "sap.fe.templates.Page.view.Page");
 });
 
+test("_analyzeAST: get template name from ast (AMD define)", async (t) => {
+	const code = `define(["a", "sap/fe/core/TemplateAssembler"], function(a, TemplateAssembler){
+		return TemplateAssembler.getTemplateComponent(getMethods,
+		"sap.fe.templates.Page.Component", {
+			metadata: {
+				properties: {
+					"templateName": {
+						"type": "string",
+						"defaultValue": "sap.fe.templates.Page.view.Page"
+					}
+				},
+				"manifest": "json"
+			}
+		});});`;
+	const ast = parseUtils.parseJS(code);
+	const analyzer = new FioriElementsAnalyzer();
+	const templateName = await analyzer._analyzeAST("sap.fe.templates.Page.Component", ast);
+	t.is(templateName, "sap.fe.templates.Page.view.Page");
+});
+
+test("_analyzeAST: unable to get template name from ast (no TemplateAssembler import)", async (t) => {
+	const code = `sap.ui.define([], // import missing
+		function(a, TemplateAssembler){
+		return TemplateAssembler.getTemplateComponent(getMethods,
+		"sap.fe.templates.Page.Component", {
+			metadata: {
+				properties: {
+					"templateName": {
+						"type": "string",
+						"defaultValue": "sap.fe.templates.Page.view.Page"
+					}
+				},
+				"manifest": "json"
+			}
+		});});`;
+	const ast = parseUtils.parseJS(code);
+	const analyzer = new FioriElementsAnalyzer();
+	const templateName = await analyzer._analyzeAST("sap.fe.templates.Page.Component", ast);
+	t.is(templateName, "");
+});
+
+test("_analyzeAST: unable to get template name from ast (no module definition)", async (t) => {
+	const code = `myDefine(["a", "sap/fe/core/TemplateAssembler"], // unsupported module definition
+		function(a, TemplateAssembler){
+		return TemplateAssembler.getTemplateComponent(getMethods,
+		"sap.fe.templates.Page.Component", {
+			metadata: {
+				properties: {
+					"templateName": {
+						"type": "string",
+						"defaultValue": "sap.fe.templates.Page.view.Page"
+					}
+				},
+				"manifest": "json"
+			}
+		});});`;
+	const ast = parseUtils.parseJS(code);
+	const analyzer = new FioriElementsAnalyzer();
+	const templateName = await analyzer._analyzeAST("sap.fe.templates.Page.Component", ast);
+	t.is(templateName, "");
+});
+
 test("_analyzeAST: get template name from ast (async function)", async (t) => {
 	const code = `sap.ui.define(["a", "sap/fe/core/TemplateAssembler"], async function(a, TemplateAssembler){
 		return TemplateAssembler.getTemplateComponent(getMethods,
@@ -305,6 +367,41 @@ test("_analyzeAST: get template name from ast (ArrowFunction with implicit retur
 	t.is(templateName, "sap.fe.templates.Page.view.Page");
 });
 
+test("_analyzeAST: unable to get template name from ast (ArrowFunction with implicit return #1)", async (t) => {
+	const code = `sap.ui.define(["a", "sap/fe/core/TemplateAssembler"],
+	(a, TemplateAssembler) => TemplateAssembler.getTemplateComponent(getMethods,
+		"sap.fe.templates.Page.Component", {
+			metadata: {
+				// No templateName provided
+				"manifest": "json"
+			}
+		}));`;
+	const ast = parseUtils.parseJS(code);
+	const analyzer = new FioriElementsAnalyzer();
+	const templateName = await analyzer._analyzeAST("sap.fe.templates.Page.Component", ast);
+	t.is(templateName, "");
+});
+
+test("_analyzeAST: unable to get template name from ast (ArrowFunction with implicit return #2)", async (t) => {
+	const code = `sap.ui.define(["a", "sap/fe/core/TemplateAssembler"],
+	(a, TemplateAssembler) => TemplateAssembler.extend(getMethods, // wrong call. should be 'getTemplateComponent'
+		"sap.fe.templates.Page.Component", {
+			metadata: {
+				properties: {
+					"templateName": {
+						"type": "string",
+						"defaultValue": "sap.fe.templates.Page.view.Page"
+					}
+				},
+				"manifest": "json"
+			}
+		}));`;
+	const ast = parseUtils.parseJS(code);
+	const analyzer = new FioriElementsAnalyzer();
+	const templateName = await analyzer._analyzeAST("sap.fe.templates.Page.Component", ast);
+	t.is(templateName, "");
+});
+
 test("_analyzeAST: get template name from ast (async factory function)", async (t) => {
 	const code = `sap.ui.define(["a", "sap/fe/core/TemplateAssembler"],
 	async (a, TemplateAssembler) => TemplateAssembler.getTemplateComponent(getMethods,