[INTERNAL][WIP] VersionInfo: with manifest infos

minor adjustments

Author: tobiasso85

lib/processors/versionInfoGenerator.js

@@ -31,7 +31,7 @@ const processManifest = async (manifestResource) => {
 		id: undefined
 	};
 
-	// sap.ui5/dependencies is used for the manifestHints
+	// sap.ui5/dependencies is used for the "manifestHints/libs"
 	if (manifestObject["sap.ui5"]) {
 		const manifestDependencies = manifestObject["sap.ui5"]["dependencies"];
 		if (manifestDependencies) {
@@ -44,7 +44,7 @@ const processManifest = async (manifestResource) => {
 		}
 	}
 
-	// sap.app/embeds is required for "components" in sap-ui-version.json
+	// sap.app/embeds is used for "components"
 	if (manifestObject["sap.app"]) {
 		const manifestEmbeds = manifestObject["sap.app"]["embeds"];
 		if (manifestEmbeds) {
@@ -59,6 +59,14 @@ const processManifest = async (manifestResource) => {
  * Library Info
  *
  * @typedef {object<string, object>} DependencyInfos
+ *
+ *  * @example
+ * {
+ *   sap.chart: {
+ *       lazy: true
+ *   },
+ *   sap.f: { }
+ * }
  */
 
 /**
@@ -120,20 +128,7 @@ const clone = (obj) => {
 	return JSON.parse(JSON.stringify(obj));
 };
 
-/**
- *
- * @param {Map<string, DependencyInfos>} libraryInfosMap
- * @param {string} libName
- * @param {object} newObject
- */
-const setManifestHints = (libraryInfosMap, libName, newObject) => {
-	const existingEntry = libraryInfosMap.get(libName);
-	const newLibs = merge(existingEntry, newObject);
-	libraryInfosMap.set(libName, newLibs);
-};
-
-const merge = (existingEntry, newObject) => {
-	const newLibs = clone(newObject);
+const merge = (existingEntry, newLibs) => {
 	if (existingEntry) {
 		Object.keys(existingEntry).forEach((libName) => {
 			if (!existingEntry[libName].lazy && newLibs[libName] && newLibs[libName].lazy) {
@@ -171,8 +166,10 @@ const resolve = (libName, libraryInfosMap, resolvedCache) => {
 		const childResolved = resolve(childLibName, libraryInfosMap, resolvedCache);
 		resolved = merge(resolved, childResolved);
 	});
-	resolved = merge(resolved, manifestHint);
-	setManifestHints(libraryInfosMap, libName, resolved);
+	resolved = merge(resolved, libraryInfosMap.get(libName));
+
+	// set a copy of the resolved libraries to avoid modifying it while iterating (recursively)
+	libraryInfosMap.set(libName, clone(resolved));
 	resolvedCache.set(libName, resolved);
 	return resolved;
 };