Skip to content

Commit a3019c8

Browse files
committed
[INTERNAL] Fix tests failing because of out-of-namespace resources
Fixed with SAP/ui5-project@6bae282
1 parent bb9e8aa commit a3019c8

File tree

5 files changed

+12
-16
lines changed

5 files changed

+12
-16
lines changed

test/expected/build/application.a/dest-depself/resources/sap-ui-custom.js

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/expected/build/application.a/dest-depself/resources/sap-ui-custom.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/expected/build/application.a/dest-self/resources/sap-ui-custom.js

Lines changed: 4 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/expected/build/application.a/dest-self/resources/sap-ui-custom.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/lib/builder/builder.js

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -281,8 +281,7 @@ test.serial("Build application.a with dependencies exclude", async (t) => {
281281
t.pass();
282282
});
283283

284-
// TODO: FIX. resources/sap-ui-custom.js is not written to dist because it's not part of the application namespace
285-
test.serial.skip("Build application.a self-contained", async (t) => {
284+
test.serial("Build application.a self-contained", async (t) => {
286285
const destPath = "./test/tmp/build/application.a/dest-self";
287286
const expectedPath = path.join("test", "expected", "build", "application.a", "dest-self");
288287

@@ -304,8 +303,7 @@ test.serial.skip("Build application.a self-contained", async (t) => {
304303
t.pass();
305304
});
306305

307-
// TODO: FIX. resources/sap-ui-custom.js is not written to dist because it's not part of the application namespace
308-
test.serial.skip("Build application.a with dependencies self-contained", async (t) => {
306+
test.serial("Build application.a with dependencies self-contained", async (t) => {
309307
const destPath = "./test/tmp/build/application.a/dest-depself";
310308
const expectedPath = path.join("test", "expected", "build", "application.a", "dest-depself");
311309

@@ -512,8 +510,7 @@ test.serial("Build application.j", async (t) => {
512510
t.pass();
513511
});
514512

515-
// TODO: FIX. resources/sap-ui-version.json is not written to dist because it's not part of the application namespace
516-
test.serial.skip("Build application.j with resources.json and version info", async (t) => {
513+
test.serial("Build application.j with resources.json and version info", async (t) => {
517514
const destPath = "./test/tmp/build/application.j/dest-resources-json";
518515
const expectedPath = path.join("test", "expected", "build", "application.j", "dest-resources-json");
519516

@@ -545,7 +542,7 @@ test.serial.skip("Build application.j with resources.json and version info", asy
545542
await builder({
546543
graph,
547544
destPath,
548-
includedTasks: ["generateResourcesJson"]
545+
includedTasks: ["generateResourcesJson", "generateVersionInfo"]
549546
});
550547

551548
const expectedFiles = await findFiles(expectedPath);

0 commit comments

Comments
 (0)