[INTERNAL] FioriElementsAnalyzer, SmartTemplateAnalyzer, XMLCompositeAnalyzer: add tests for SpreadElement handling

Author: flovogt

test/lib/lbt/analyzer/FioriElementsAnalyzer.js

@@ -315,6 +315,32 @@ test("_analyzeAST: get template name from ast (ArrowFunction with implicit retur
 	t.deepEqual(result, "donkey");
 });
 
+test("_analyzeAST: get template name from ast (with SpreadElement)", async (t) => {
+	const code = `sap.ui.define(["a", "sap/fe/core/TemplateAssembler"], (a, TemplateAssembler) => {
+		const myTemplate = {
+			templateName: {
+				type: "string",
+				defaultValue: "sap.fe.templates.Page.view.Page"
+			}
+		};
+		return TemplateAssembler.getTemplateComponent(getMethods,
+		"sap.fe.templates.Page.Component", {
+			metadata: {
+				properties: {
+					...myTemplate
+				},
+				"manifest": "json"
+			}
+		});});`;
+	const ast = parseUtils.parseJS(code);
+	const analyzer = new FioriElementsAnalyzer();
+	const templateName = await analyzer._analyzeAST("sap.fe.templates.Page.Component", ast);
+
+	t.is(templateName, "", "The TemplateName is correctly empty");
+	// TODO: Support SpreadElement
+	// t.is(templateName, "sap.fe.templates.Page.view.Page", "The TemplateName is correctly determined");
+});
+
 test("_analyzeAST: no template name from ast", async (t) => {
 	const code = `sap.ui.define(["a", "sap/fe/core/TemplateAssembler"], function(a, TemplateAssembler){
 		return TemplateAssembler.getTemplateComponent(getMethods,

test/lib/lbt/analyzer/SmartTemplateAnalyzer.js

@@ -462,6 +462,34 @@ test("_analyzeAST: get template name from ast (ArrowFunction with implicit retur
 	t.deepEqual(result, "donkey");
 });
 
+test("_analyzeAST: get template name from ast (with SpreadElement)", async (t) => {
+	const code = `sap.ui.define(["a", "sap/suite/ui/generic/template/lib/TemplateAssembler"],
+	(a, TemplateAssembler) => {
+		const myTemplate = {
+			templateName: {
+				type: "string",
+				defaultValue: "sap.fe.templates.Page.view.Page"
+			}
+		};
+		return TemplateAssembler.getTemplateComponent(getMethods,
+		"sap.fe.templates.Page.Component", {
+			metadata: {
+				properties: {
+					...myTemplate
+				},
+				"manifest": "json"
+			}
+		});});`;
+	const ast = parseUtils.parseJS(code);
+	const analyzer = new SmartTemplateAnalyzer();
+	const templateName = await analyzer._analyzeAST("sap.fe.templates.Page.Component", ast);
+
+	t.is(templateName, "", "The TemplateName is correctly empty");
+	// TODO: Support SpreadElement
+	// t.is(templateName, "sap.fe.templates.Page.view.Page", "The TemplateName is correctly determined");
+});
+
+
 test("_analyzeAST: no template name from ast", async (t) => {
 	const code = `sap.ui.define(["a", "sap/suite/ui/generic/template/lib/TemplateAssembler"],
 	function(a, TemplateAssembler){

test/lib/lbt/analyzer/XMLCompositeAnalyzer.js

@@ -20,7 +20,7 @@ test("integration: XMLComposite code", async (t) => {
 	const moduleInfo = new ModuleInfo();
 	await analyzer.analyze(ast, name, moduleInfo);
 	t.deepEqual(moduleInfo.dependencies, ["composites/ButtonList.control.xml"],
-		"Dependency should be created from component name");
+		"Dependency should be created from composite name");
 });
 
 test("integration: XMLComposite code without VariableDeclaration", async (t) => {
@@ -38,7 +38,7 @@ test("integration: XMLComposite code without VariableDeclaration", async (t) =>
 	const moduleInfo = new ModuleInfo();
 	await analyzer.analyze(ast, name, moduleInfo);
 	t.deepEqual(moduleInfo.dependencies, ["composites/ButtonList.control.xml"],
-		"Dependency should be created from component name");
+		"Dependency should be created from composite name");
 });
 
 test("integration: XMLComposite code with arrow function", async (t) => {
@@ -55,7 +55,7 @@ test("integration: XMLComposite code with arrow function", async (t) => {
 	const moduleInfo = new ModuleInfo();
 	await analyzer.analyze(ast, name, moduleInfo);
 	t.deepEqual(moduleInfo.dependencies, ["composites/ButtonList.control.xml"],
-		"Dependency should be created from component name");
+		"Dependency should be created from composite name");
 });
 
 test("integration: XMLComposite code with arrow function with implicit return", async (t) => {
@@ -70,7 +70,36 @@ test("integration: XMLComposite code with arrow function with implicit return",
 	const moduleInfo = new ModuleInfo();
 	await analyzer.analyze(ast, name, moduleInfo);
 	t.deepEqual(moduleInfo.dependencies, ["composites/ButtonList.control.xml"],
-		"Dependency should be created from component name");
+		"Dependency should be created from composite name");
+});
+
+test.only("integration: XMLComposite code with SpreadElement", async (t) => {
+	const code = `sap.ui.define([
+		'jquery.sap.global', 'sap/ui/core/XMLComposite'],
+		(jQuery, XMLComposite) => {
+		const myXMLComposite = {
+			fragment: "composites.custom.ButtonList"
+		};
+		return XMLComposite.extend("composites.ButtonList", {
+			...myXMLComposite
+		});
+	});`;
+
+
+	const ast = parseJS(code);
+
+	const analyzer = new XMLCompositeAnalyzer();
+	const name = "composites.ButtonList";
+	const moduleInfo = new ModuleInfo();
+	await analyzer.analyze(ast, name, moduleInfo);
+
+	t.deepEqual(moduleInfo.dependencies, ["composites/ButtonList.control.xml"],
+		"Dependency should be created from composite name because overriden by the 'fragment' property " +
+		" is not possible to lacking SpreadElement support");
+
+	// TODO: Support SpreadElement
+	// t.deepEqual(moduleInfo.dependencies, ["composites/custom/ButtonList.control.xml"],
+	// 	"Dependency should be created from composite name");
 });
 
 test("analyze: not an XMLComposite module", async (t) => {