[INTERNAL] ESLint: Enforce max line length

Author: RandomByte

.eslintrc.js

@@ -31,7 +31,14 @@ module.exports = {
 		"no-negated-condition": "off",
 		"require-jsdoc": "off",
 		"no-mixed-requires": "off",
-		"max-len": ["warn", 120],
+		"max-len": [
+			"error",
+			{
+				"code": 120,
+				"ignoreUrls": true,
+				"ignoreRegExpLiterals": true
+			}
+		],
 		"no-implicit-coercion": [
 			2,
 			{"allow": ["!!"]}

lib/builder/builder.js

@@ -38,7 +38,8 @@ function getElapsedTime(startTime) {
  * @private
  * @param {object} parameters
  * @param {boolean} parameters.dev Sets development mode, which only runs essential tasks
- * @param {boolean} parameters.selfContained True if a the build should be self-contained or false for prelead build bundles
+ * @param {boolean} parameters.selfContained
+ *			True if a the build should be self-contained or false for prelead build bundles
  * @param {boolean} parameters.jsdoc True if a JSDoc build should be executed
  * @param {Array} parameters.includedTasks Task list to be included from build
  * @param {Array} parameters.excludedTasks Task list to be excluded from build
@@ -207,9 +208,13 @@ module.exports = {
 	 * @param {string} parameters.destPath Target path
 	 * @param {boolean} [parameters.cleanDest=false] Decides whether project should clean the target path before build
 	 * @param {boolean} [parameters.buildDependencies=false] Decides whether project dependencies are built as well
-	 * @param {Array.<string|RegExp>} [parameters.includedDependencies=[]] List of build dependencies to be included if buildDependencies is true
-	 * @param {Array.<string|RegExp>} [parameters.excludedDependencies=[]] List of build dependencies to be excluded if buildDependencies is true. If the wildcard '*' is provided, only the included dependencies will be built.
-	 * @param {boolean} [parameters.dev=false] Decides whether a development build should be activated (skips non-essential and time-intensive tasks)
+	 * @param {Array.<string|RegExp>} [parameters.includedDependencies=[]]
+	 *			List of build dependencies to be included if buildDependencies is true
+	 * @param {Array.<string|RegExp>} [parameters.excludedDependencies=[]]
+	 *			List of build dependencies to be excluded if buildDependencies is true.
+	 *			If the wildcard '*' is provided, only the included dependencies will be built.
+	 * @param {boolean} [parameters.dev=false]
+	 *			Decides whether a development build should be activated (skips non-essential and time-intensive tasks)
 	 * @param {boolean} [parameters.selfContained=false] Flag to activate self contained build
 	 * @param {boolean} [parameters.jsdoc=false] Flag to activate JSDoc build
 	 * @param {Array.<string>} [parameters.includedTasks=[]] List of tasks to be included
@@ -367,7 +372,8 @@ module.exports = {
 									resource.getPath());
 								return; // Skip target write for this resource
 							}
-							if (projectContext.isRootProject() && project.type === "application" && project.metadata.namespace) {
+							if (projectContext.isRootProject() && project.type === "application" &&
+									project.metadata.namespace) {
 								// Root-application projects only: Remove namespace prefix if given
 								resource.setPath(resource.getPath().replace(
 									new RegExp(`^/resources/${project.metadata.namespace}`), ""));

lib/lbt/analyzer/JSModuleAnalyzer.js

@@ -554,7 +554,9 @@ class JSModuleAnalyzer {
 			} else {
 				nUnnamedDefines++;
 				if ( nUnnamedDefines > 1 ) {
-					throw new Error("if multiple modules are contained in a file, only one of them may omit the module ID " + name + " " + nUnnamedDefines);
+					throw new Error(
+						"if multiple modules are contained in a file, only one of them may omit the module ID " +
+						name + " " + nUnnamedDefines);
 				}
 				if ( defaultName == null ) {
 					throw new Error("unnamed module found, but no default name given");

lib/lbt/bundle/Resolver.js

@@ -33,7 +33,8 @@ class BundleResolver {
 	/**
 	 * @param {ModuleDefinition} bundle Bundle definition to resolve
 	 * @param {object} [options] Options
-	 * @param {string[]} [options.defaultFileTypes] List of default file types to which a prefix pattern shall be expanded.
+	 * @param {string[]} [options.defaultFileTypes]
+	 			List of default file types to which a prefix pattern shall be expanded.
 	 * @returns {Promise<ResolvedBundleDefinition>}
 	 */
 	resolve(bundle, options) {
@@ -51,7 +52,8 @@ class BundleResolver {
 			let prevLength;
 			let newKeys;
 
-			const filters = new ResourceFilterList( section.filters, fileTypes ); // resolvePlaceholders(section.getFilters());
+			// NODE-TODO resolvePlaceholders(section.getFilters());
+			const filters = new ResourceFilterList( section.filters, fileTypes );
 
 			function isAccepted(resourceName, required) {
 				let match = required;

lib/lbt/resources/ResourceCollector.js

@@ -100,7 +100,8 @@ class ResourceCollector {
 			// Note: ignores .theme files in library folders
 
 			// .theming files are not always present therefore this check is relevant for the library.source.less
-			if ( name.match("(?:[^/]+/)*themes/[^/]+/(?:\\.theming|library\\.source\\.less)") && !this._themePackages.has(prefix) ) {
+			if ( name.match("(?:[^/]+/)*themes/[^/]+/(?:\\.theming|library\\.source\\.less)") &&
+					!this._themePackages.has(prefix) ) {
 				// log.info("found new theme package %s", prefix);
 				this._themePackages.set(prefix, new ResourceInfoList(prefix));
 			}
@@ -230,7 +231,8 @@ class ResourceCollector {
 
 	createOrphanFilters() {
 		log.verbose(
-			`  configured external resources filters (resources outside the namespace): ${this._externalResources == null ? "(none)" : this._externalResources}`);
+			`  configured external resources filters (resources outside the namespace): ` +
+			`${this._externalResources == null ? "(none)" : this._externalResources}`);
 
 		const filtersByComponent = new Map();
 
@@ -260,7 +262,8 @@ class ResourceCollector {
 					list.add(resource, !isDebugBundle);
 					contained = true;
 				} else if ( orphanFilters.has(prefix) ) {
-					// log.verbose(`  checking '${resource.name}' against orphan filter '${orphanFilters.get(prefix)}' (${prefix})`);
+					// log.verbose(`  checking '${resource.name}' against orphan filter ` +
+					// 	`'${orphanFilters.get(prefix)}' (${prefix})`);
 					if ( orphanFilters.get(prefix).matches(resource.name) ) {
 						list.add(resource, !isDebugBundle);
 						contained = true;

lib/processors/bundlers/flexChangesBundler.js

@@ -10,7 +10,8 @@ const resourceFactory = require("@ui5/fs").resourceFactory;
  * @param {module:@ui5/fs.Resource[]} parameters.resources List of resources to be processed
  * @param {object} parameters.options Options
  * @param {string} parameters.options.pathPrefix Prefix for bundle path
- * @param {string} parameters.options.hasFlexBundleVersion true if minUI5Version >= 1.73 than create flexibility-bundle.json
+ * @param {string} parameters.options.hasFlexBundleVersion true if minUI5Version >= 1.73 than
+ *															create flexibility-bundle.json
  * @returns {Promise<module:@ui5/fs.Resource[]>} Promise resolving with flex changes bundle resources
  */
 module.exports = function({resources, options: {pathPrefix, hasFlexBundleVersion}}) {
@@ -38,7 +39,8 @@ module.exports = function({resources, options: {pathPrefix, hasFlexBundleVersion
 		changesContent.forEach(function(content) {
 			switch (content.fileType) {
 			case "change":
-				if (content.appDescriptorChange && (content.appDescriptorChange === "true" || content.appDescriptorChange == true)) {
+				if (content.appDescriptorChange && (content.appDescriptorChange === "true" ||
+						content.appDescriptorChange == true)) {
 					break;
 				}
 				if (content.variantReference && content.variantReference !== "") {
@@ -62,8 +64,11 @@ module.exports = function({resources, options: {pathPrefix, hasFlexBundleVersion
 			}
 		});
 
-		if (!hasFlexBundleVersion && (compVariants.length != 0 || variants.length != 0 || variantChanges.length != 0 || variantDependentControlChanges.length != 0 || variantManagementChanges.length != 0)) {
-			throw new Error("There are some control variant changes in the changes folder. This only works with a minUI5Version 1.73.0. Please update the minUI5Version in the manifest.json to 1.73.0 or higher");
+		if (!hasFlexBundleVersion && (compVariants.length != 0 || variants.length != 0 || variantChanges.length != 0 ||
+				variantDependentControlChanges.length != 0 || variantManagementChanges.length != 0)) {
+			throw new Error(
+				"There are some control variant changes in the changes folder. This only works with a " +
+				"minUI5Version 1.73.0. Please update the minUI5Version in the manifest.json to 1.73.0 or higher");
 		}
 		// create changes-bundle.json
 		if (!hasFlexBundleVersion) {

lib/processors/bundlers/moduleBundler.js

@@ -10,33 +10,40 @@ const EvoResource = require("@ui5/fs").Resource;
  * <b>Module bundle section modes</b><br>
  * <ul>
  * 	<li>
- * 		<code>provided</code>: A section of mode 'provided' defines a set of modules that should not be included in the bundle file itself, but
-			which should be assumed to be already loaded (or 'provided') by the environment into which the bundle module is loaded.
+ *		<code>provided</code>: A section of mode 'provided' defines a set of modules that should not be included in
+ * the bundle file itself, but which should be assumed to be already loaded (or 'provided') by the environment into
+ * which the bundle module is loaded.
  * 	</li>
  *	<li>
-		 <code>raw</code>: A raw section determines the set of modules that should be embedded,
-			sorts them according to their dependencies and writes them out 1:1 without any transformation or wrapping (raw). Only JavaScript sources
-				can be embedded in a raw section.
-	</li>
+ *		<code>raw</code>: A raw section determines the set of modules that should be embedded, sorts them according
+ *		to their dependencies and writes them out 1:1 without any transformation or wrapping (raw). Only JavaScript
+ *		sources can be embedded in a raw section.
+ *	</li>
  *	<li>
-		 <code>preload</code>: A preload section packages resources that should be stored in the preload cache in the client.
-			They can embed any textual resource type (JavaScript, XML, JSON and .properties files) that the bundling supports.
-			UI5 modules are wrapped into a 'sap.ui.predefine' call. Other JavaScript modules will be embedded into a 'jQuery.sap.registerPreload' call, unless the
-			asynchronous ui5loader is used. With the ui5loader 'sap.ui.require.preload' is used for other modules.
-	</li>
+ *		<code>preload</code>: A preload section packages resources that should be stored in the preload cache in the
+ *		client. They can embed any textual resource type (JavaScript, XML, JSON and .properties files) that the
+ *		bundling supports. UI5 modules are wrapped into a 'sap.ui.predefine' call. Other JavaScript modules will be
+ *		embedded into a 'jQuery.sap.registerPreload' call, unless the asynchronous ui5loader is used. With the
+ *		ui5loader 'sap.ui.require.preload' is used for other modules.
+ *	</li>
  *	<li>
-		 <code>require</code>: A 'require' section is transformed into a sequence of jQuery.sap.require calls. The list will be resolved like an include pattern list
-				in any of the other sections and for each of the resolved modules, a jQuery.sap.require will be created. In case the ui5loader is available, 'sap.ui.requireSync' is used instead.
-	</li>
+ *		<code>require</code>: A 'require' section is transformed into a sequence of jQuery.sap.require calls. The
+ *		list will be resolved like an include pattern list in any of the other sections and for each of the resolved
+ *		modules, a jQuery.sap.require will be created. In case the ui5loader is available, 'sap.ui.requireSync' is
+ *		used instead.
+ *	</li>
  * </ul>
  * </p>
  *
  * @public
  * @typedef {object} ModuleBundleDefinitionSection
  * @property {string} mode The embedding mode. Either 'provided', 'raw', 'preload' or 'require'
- * @property {string[]} filters List of modules declared as glob patterns (resource name patterns) that should be in- or excluded.
- * 		A pattern either contains of a trailing slash '/' or single '*' and double '**' asterisks which denote an arbitrary number of characters or folder names.
- * 		Exludes should be marked with a leading exclamation mark '!'. The order of filters is relevant, a later exclusion overrides an earlier inclusion and vice versa.
+ * @property {string[]} filters List of modules declared as glob patterns (resource name patterns) that should be
+ *		in- or excluded.
+ * 		A pattern either contains of a trailing slash '/' or single '*' and double '**' asterisks which denote an
+ *		arbitrary number of characters or folder names.
+ * 		Exludes should be marked with a leading exclamation mark '!'. The order of filters is relevant, a later
+ *		exclusion overrides an earlier inclusion and vice versa.
  * @example <caption>List of modules as glob patterns that should be in- or excluded</caption>
  * // Includes everything from "some/path/to/module/",
  * // but excludes the subfolder "some/path/to/module/to/be/excluded/"
@@ -47,12 +54,13 @@ const EvoResource = require("@ui5/fs").Resource;
  * 	]
  * };
  *
- * @property {boolean} [resolve=false] Whether (transitive) dependencies of modules that match the given filters should be resolved
- * 		and added to the module set
+ * @property {boolean} [resolve=false] Whether (transitive) dependencies of modules that match the given filters
+ *		should be resolved and added to the module set
  * @property {boolean} [resolveConditional=false] Whether conditional dependencies of modules should be resolved
  * 		and added to the module set for this section
  * @property {boolean} [renderer=false] Whether renderers for controls should be added to the module set
- * @property {boolean} [declareRawModules=false] Whether raw modules should be declared after jQuery.sap.global became available. With the usage of the ui5loader, this flag should be set to 'false'
+ * @property {boolean} [declareRawModules=false] Whether raw modules should be declared after jQuery.sap.global
+ *		became available. With the usage of the ui5loader, this flag should be set to 'false'
  * @property {boolean} [sort=true] Whether the modules should be sorted by their dependencies
  */
 
@@ -79,7 +87,8 @@ const EvoResource = require("@ui5/fs").Resource;
  *   a try/catch to filter out "Restart" errors
  * @property {boolean} [usePredefineCalls=false] If set to 'true', sap.ui.predefine is used for UI5 modules
  * @property {number} [numberOfParts=1] The number of parts the module bundle should be splitted
- * @property {boolean} [ignoreMissingModules=false] When searching for modules which are optional for further processing, do not throw in case they are missing
+ * @property {boolean} [ignoreMissingModules=false] When searching for modules which are optional for further
+ *   processing, do not throw in case they are missing
  */
 
 /**

lib/processors/manifestCreator.js

@@ -571,10 +571,11 @@ module.exports = function({libraryResource, resources, options}) {
 		return Promise.resolve(null); // a fulfillment of null indicates that no manifest has been created
 	}
 
-	return createManifest(libraryResource, libBundle, options.descriptorVersion, options.include3rdParty).then((manifest) => {
-		return new EvoResource({
-			path: resourcePathPrefix + "manifest.json",
-			string: JSON.stringify(manifest, null, options.prettyPrint ? "  " : undefined)
+	return createManifest(libraryResource, libBundle, options.descriptorVersion, options.include3rdParty)
+		.then((manifest) => {
+			return new EvoResource({
+				path: resourcePathPrefix + "manifest.json",
+				string: JSON.stringify(manifest, null, options.prettyPrint ? "  " : undefined)
+			});
 		});
-	});
 };

lib/processors/nonAsciiEscaper.js

@@ -90,8 +90,8 @@ const encodingMap = {
 
 /**
  * Provides a mapping from user-friendly encoding name (alias) such as "UTF-8" and "ISO-8859-1" to node
- * specific encoding name such as "utf8" or "latin1". Simplifies usage of nonAsciiEscaper encoding
- * option such that it can be used standalone without the respective task (e.g. in Splitter, Bundler and related projects).
+ * specific encoding name such as "utf8" or "latin1". Simplifies usage of nonAsciiEscaper encoding option
+ * such that it can be used standalone without the respective task (e.g. in Splitter, Bundler and related projects).
  *
  * @public
  * @alias module:@ui5/builder.processors.nonAsciiEscaper․getEncodingFromAlias
@@ -100,7 +100,8 @@ const encodingMap = {
  */
 nonAsciiEscaper.getEncodingFromAlias = function(encoding) {
 	if (!encodingMap[encoding]) {
-		throw new Error(`Encoding "${encoding}" is not supported. Only ${Object.keys(encodingMap).join(", ")} are allowed values` );
+		throw new Error(
+			`Encoding "${encoding}" is not supported. Only ${Object.keys(encodingMap).join(", ")} are allowed values` );
 	}
 	return encodingMap[encoding];
 };

lib/processors/resourceListCreator.js

@@ -107,8 +107,8 @@ function makeResourcesJSON(list, prefix) {
 	// Adjust size until it is correct
 	// This entry's size depends on the file size which depends on this entry's size,...
 	// Updating the number of the size in the content might influence the size of the file itself
-	// This is deterministic because e.g. in the content -> <code>"size": 1000</code> has the same amount of bytes as <code>"size": 9999</code>
-	// the difference might only come for:
+	// This is deterministic because e.g. in the content -> <code>"size": 1000</code> has the same
+	// amount of bytes as <code>"size": 9999</code> the difference might only come for:
 	// * adding the initial entry of resources.json
 	// * changes when the number of digits of the number changes, e.g. 100 -> 1000
 	while (resourcesJson.size !== newLength) {
@@ -193,7 +193,9 @@ module.exports = async function({resources, options}) {
 	const unassigned = collector.resources;
 	if ( unassigned.size > 0 && options.failOnOrphans ) {
 		log.error(`resources.json generation failed because of unassigned resources: ${[...unassigned].join(", ")}`);
-		throw new Error(`resources.json generation failed with error: There are ${unassigned.size} resources which could not be assigned to components.`);
+		throw new Error(
+			`resources.json generation failed with error: There are ${unassigned.size} ` +
+			`resources which could not be assigned to components.`);
 	}
 
 	return resourceLists;