Collection handling: Ignore projects of collections

To be compatible with the current behavior of the projectPreprocessor.
Apparently the open.fe setup relies on that.

Author: RandomByte

lib/graph/Module.js

@@ -104,7 +104,28 @@ class Module {
 	}
 
 	async _getSpecifications() {
-		const configs = await this._getConfigurations();
+		let configs = await this._getConfigurations();
+
+		// I'm using hacks here:
+		// Filter out project-shims to check whether the this module is a collection
+		const isCollection = configs.find((configuration) => {
+			if (configuration.kind === "extension" && configuration.type === "project-shim") {
+				// TODO create Specification instance and ask it for the configuration
+				if (configuration.shims && configuration.shims.collections &&
+						configuration.shims.collections[this.getId()]) {
+					return true;
+				}
+			}
+		});
+
+		if (isCollection) {
+			// This module is configured as a collection
+			// For compatibility reasons with the behavior of projectPreprocessor,
+			// the project contained in this module must be ignored
+			configs = configs.filter((configuration) => {
+				return configuration.kind !== "project";
+			});
+		}
 
 		const specs = await Promise.all(configs.map(async (configuration) => {
 			const spec = await Specification.create({

lib/graph/ShimCollection.js

@@ -22,14 +22,16 @@ class ShimCollection {
 	addProjectShim(shimExtension) {
 		const name = shimExtension.getName();
 		log.verbose(`Adding new shim ${name}...`);
-		// TODO: Move this into a dedicated ShimConfiguration class?
-		const {configurations, dependencies, collections} = shimExtension.getShimConfiguration();
+
+		const configurations = shimExtension.getConfigurationShims();
 		if (configurations) {
 			addToMap(name, configurations, this._projectConfigShims);
 		}
+		const dependencies = shimExtension.getDependencyShims();
 		if (dependencies) {
 			addToMap(name, dependencies, this._dependencyShims);
 		}
+		const collections = shimExtension.getCollectionShims();
 		if (collections) {
 			addToMap(name, collections, this._collectionShims);
 		}

lib/specifications/types/ProjectShim.js

@@ -10,8 +10,22 @@ class ProjectShim extends Extension {
 	/**
 	* @public
 	*/
-	getShimConfiguration() {
-		return this._config.shims;
+	getDependencyShims() {
+		return this._config.shims.dependencies;
+	}
+
+	/**
+	* @public
+	*/
+	getConfigurationShims() {
+		return this._config.shims.configurations;
+	}
+
+	/**
+	* @public
+	*/
+	getCollectionShims() {
+		return this._config.shims.collections;
 	}
 
 	/* === Internals === */