Skip to content

Commit 8385a31

Browse files
RandomByteRandomByte
committed
[INTERNAL] Schema: Allow metadata.name to be up to 80 characters long
As discussed, raise the limit since we already encountered projects using more than 60 characters for their name.
1 parent ef65682 commit 8385a31

File tree

13 files changed

+29
-29
lines changed

13 files changed

+29
-29
lines changed

‎lib/validation/schema/specVersion/kind/extension.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@
7979
"name": {
8080
"type": "string",
8181
"minLength": 3,
82-
"maxLength": 50,
82+
"maxLength": 80,
8383
"pattern": "^(?:@[0-9a-z-_.]+\\/)?[a-z][0-9a-z-_.]*$",
8484
"title": "Extension Name",
8585
"description": "Unique identifier for the extension, for example: ui5-task-fearless-rock",

‎lib/validation/schema/specVersion/kind/project.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@
101101
"name": {
102102
"type": "string",
103103
"minLength": 3,
104-
"maxLength": 50,
104+
"maxLength": 80,
105105
"pattern": "^(?:@[0-9a-z-_.]+\\/)?[a-z][0-9a-z-_.]*$",
106106
"title": "Project Name",
107107
"description": "Unique identifier for the project, for example: organization.product.project",

‎lib/validation/schema/ui5-workspace.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
"name": {
2929
"type": "string",
3030
"minLength": 3,
31-
"maxLength": 50,
31+
"maxLength": 80,
3232
"pattern": "^(?:@[0-9a-z-_.]+\\/)?[a-z][0-9a-z-_.]*$",
3333
"title": "Workspace Name",
3434
"description": "Identifier for the workspace configuration. Workspaces named 'default' will be used automatically by UI5 Tooling",

‎test/lib/validation/schema/specVersion/kind/extension.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ test("Legacy: Special characters in name (task)", async (t) => {
159159
"kind": "extension",
160160
"type": "task",
161161
"metadata": {
162-
"name": "ä".repeat(51)
162+
"name": "ä".repeat(81)
163163
},
164164
"task": {
165165
"path": "task.js"

‎test/lib/validation/schema/specVersion/kind/extension/project-shim.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ test.after.always((t) => {
180180
"kind": "extension",
181181
"type": "project-shim",
182182
"metadata": {
183-
"name": "a".repeat(51)
183+
"name": "a".repeat(81)
184184
},
185185
"shims": {}
186186
}, [{
@@ -191,9 +191,9 @@ test.after.always((t) => {
191191
errors: [{
192192
dataPath: "/metadata/name",
193193
keyword: "maxLength",
194-
message: "should NOT be longer than 50 characters",
194+
message: "should NOT be longer than 80 characters",
195195
params: {
196-
limit: 50,
196+
limit: 80,
197197
}
198198
}]
199199
},

‎test/lib/validation/schema/specVersion/kind/extension/server-middleware.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ test.after.always((t) => {
102102
"kind": "extension",
103103
"type": "server-middleware",
104104
"metadata": {
105-
"name": "a".repeat(51)
105+
"name": "a".repeat(81)
106106
},
107107
"middleware": {
108108
"path": "/bar"
@@ -115,9 +115,9 @@ test.after.always((t) => {
115115
errors: [{
116116
dataPath: "/metadata/name",
117117
keyword: "maxLength",
118-
message: "should NOT be longer than 50 characters",
118+
message: "should NOT be longer than 80 characters",
119119
params: {
120-
limit: 50,
120+
limit: 80,
121121
}
122122
}]
123123
},

‎test/lib/validation/schema/specVersion/kind/extension/task.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ test.after.always((t) => {
102102
"kind": "extension",
103103
"type": "task",
104104
"metadata": {
105-
"name": "a".repeat(51)
105+
"name": "a".repeat(81)
106106
},
107107
"task": {
108108
"path": "/bar"
@@ -115,9 +115,9 @@ test.after.always((t) => {
115115
errors: [{
116116
dataPath: "/metadata/name",
117117
keyword: "maxLength",
118-
message: "should NOT be longer than 50 characters",
118+
message: "should NOT be longer than 80 characters",
119119
params: {
120-
limit: 50,
120+
limit: 80,
121121
}
122122
}]
123123
},

‎test/lib/validation/schema/specVersion/kind/project.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ test("Legacy: Special characters in name (application)", async (t) => {
201201
"specVersion": "2.0",
202202
"type": "application",
203203
"metadata": {
204-
"name": "/".repeat(51)
204+
"name": "/".repeat(81)
205205
}
206206
});
207207
});

‎test/lib/validation/schema/specVersion/kind/project/application.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -990,7 +990,7 @@ test.after.always((t) => {
990990
"specVersion": specVersion,
991991
"type": "application",
992992
"metadata": {
993-
"name": "a".repeat(51)
993+
"name": "a".repeat(81)
994994
}
995995
}, [{
996996
dataPath: "/metadata/name",
@@ -1000,9 +1000,9 @@ test.after.always((t) => {
10001000
errors: [{
10011001
dataPath: "/metadata/name",
10021002
keyword: "maxLength",
1003-
message: "should NOT be longer than 50 characters",
1003+
message: "should NOT be longer than 80 characters",
10041004
params: {
1005-
limit: 50,
1005+
limit: 80,
10061006
},
10071007
}]
10081008
},

‎test/lib/validation/schema/specVersion/kind/project/library.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1163,7 +1163,7 @@ test.after.always((t) => {
11631163
"specVersion": specVersion,
11641164
"type": "library",
11651165
"metadata": {
1166-
"name": "a".repeat(51)
1166+
"name": "a".repeat(81)
11671167
}
11681168
}, [{
11691169
dataPath: "/metadata/name",
@@ -1173,9 +1173,9 @@ test.after.always((t) => {
11731173
errors: [{
11741174
dataPath: "/metadata/name",
11751175
keyword: "maxLength",
1176-
message: "should NOT be longer than 50 characters",
1176+
message: "should NOT be longer than 80 characters",
11771177
params: {
1178-
limit: 50,
1178+
limit: 80,
11791179
},
11801180
}]
11811181
},

0 commit comments

Comments
 (0)