Skip to content

Commit f2d3089

Browse files
authored
[INTERNAL] Fail-fast "npm ci" if deps require unsupported node version (#836)
Follows up #835. When upgrading a dependency to a newer version, it might require a different node version than before which could be unsupported by the repo. Unfortunately, this could be easily overseen. This PR adds the flag `--engine-strict` to the dependency installation step during the GH Actions job. Incase such a version requirement change, this flag will now fail-fast the job which should attract attention.
1 parent ad9956a commit f2d3089

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/github-ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
node-version: 20.11.0
2626

2727
- name: Install dependencies
28-
run: npm ci
28+
run: npm ci --engine-strict # --engine-strict is used to fail-fast if deps require node versions unsupported by the repo
2929

3030
- name: Perform checks and tests
3131
run: npm test

0 commit comments

Comments
 (0)