[INTERNAL] index: Stop exporting middleware modules

They should be retrieved from the middlewareRepository. However, neither
the modules nor the repository is publicly documented. Therefore this is
not declared as a breaking change.

Author: RandomByte

index.js

@@ -5,24 +5,9 @@
 const modules = {
 	server: "./lib/server",
 	sslUtil: "./lib/sslUtil",
-	middlewareRepository: "./lib/middleware/middlewareRepository",
-
-	// Legacy middleware export. Still private.
-	middleware: {
-		csp: "./lib/middleware/csp",
-		discovery: "./lib/middleware/discovery",
-		nonReadRequests: "./lib/middleware/discovery",
-		serveIndex: "./lib/middleware/serveIndex",
-		serveResources: "./lib/middleware/serveResources",
-		serveThemes: "./lib/middleware/serveThemes",
-		versionInfo: "./lib/middleware/versionInfo",
-	}
+	middlewareRepository: "./lib/middleware/middlewareRepository"
 };
 
-const LEGACY_MIDDLEWARE = [
-	"discovery", "nonReadRequests", "serveIndex",
-	"serveResources", "serveThemes", "versionInfo"
-];
 function exportModules(exportRoot, modulePaths) {
 	for (const moduleName in modulePaths) {
 		if (Object.prototype.hasOwnProperty.call(modulePaths, moduleName)) {
@@ -32,33 +17,11 @@ function exportModules(exportRoot, modulePaths) {
 			} else {
 				Object.defineProperty(exportRoot, moduleName, {
 					get() {
-						let m = require(modulePaths[moduleName]);
-						if (LEGACY_MIDDLEWARE.includes(moduleName)) {
-							m = mapLegacyMiddlewareArguments(m);
-						}
-						return m;
+						return require(modulePaths[moduleName]);
 					}
 				});
 			}
 		}
 	}
 }
-
-function mapLegacyMiddlewareArguments(module) {
-	// Old arguments was a single object with optional properties
-	// - resourceCollections
-	// - tree
-	return function({resourceCollections, tree} = {}) {
-		const resources = {};
-		resources.all = resourceCollections.combo;
-		resources.rootProject = resourceCollections.source;
-		resources.dependencies = resourceCollections.dependencies;
-
-		return module({
-			resources,
-			tree
-		});
-	};
-}
-
 exportModules(module.exports, modules);

test/lib/index.js

@@ -5,12 +5,4 @@ test("index.js exports all expected modules", (t) => {
 	t.truthy(index.server, "Module exported");
 	t.truthy(index.sslUtil, "Module exported");
 	t.truthy(index.middlewareRepository, "Module exported");
-
-	t.truthy(index.middleware.csp, "Module exported");
-	t.truthy(index.middleware.discovery, "Module exported");
-	t.truthy(index.middleware.nonReadRequests, "Module exported");
-	t.truthy(index.middleware.serveIndex, "Module exported");
-	t.truthy(index.middleware.serveResources, "Module exported");
-	t.truthy(index.middleware.serveThemes, "Module exported");
-	t.truthy(index.middleware.versionInfo, "Module exported");
 });